Tree Rules: Difference between revisions

From MozillaWiki
Jump to navigation Jump to search
Line 3: Line 3:
== [http://tests.themasta.com/tinderboxpushlog/ mozilla-central] - Trunk (Firefox 4.0, Gecko 2.0 work) ==
== [http://tests.themasta.com/tinderboxpushlog/ mozilla-central] - Trunk (Firefox 4.0, Gecko 2.0 work) ==


When the tree is marked '''<font color="#F88017">METERED</font>''' (see #developers topic for the current state) use the [[LandingQueue|landing queue]]. When the tree is marked '''<font color="green">OPEN</font>''', you are free to land '''approved patches''' after checking with the current sheriff. Orange and red should be stared before landing any patch.
When the tree is marked '''<font color="#F88017">METERED</font>''' (see #developers topic for the current state) use the [[LandingQueue|landing queue]]. When the tree is marked '''<font color="green">OPEN</font>''', you are free to land '''approved patches''' after checking with the current sheriff. Orange and red should be starred before landing any patch.


'''Approved patches''' must meet the [https://developer.mozilla.org/En/Developer_Guide/Committing_Rules_and_Responsibilities general checkin rules] and one of the following criteria before they can land:
'''Approved patches''' must meet the [https://developer.mozilla.org/En/Developer_Guide/Committing_Rules_and_Responsibilities general checkin rules] and one of the following criteria before they can land:

Revision as of 19:20, 8 October 2010

For comm-central tree rules, see this page.

mozilla-central - Trunk (Firefox 4.0, Gecko 2.0 work)

When the tree is marked METERED (see #developers topic for the current state) use the landing queue. When the tree is marked OPEN, you are free to land approved patches after checking with the current sheriff. Orange and red should be starred before landing any patch.

Approved patches must meet the general checkin rules and one of the following criteria before they can land:

  • The patch fixes a Gecko 2 blocker which is defined as...:
    • a bug marked blocking2.0+
    • a bug marked blocking-fennec+
    • a bug that is required by either of the above
    • a bug that is required to land on trunk before being ported to branch
  • The patch only change test code
  • The patch is not part of the set of supported builds
  • A patch that fixes tree "bustage"
  • A backout of a previously committed patch

Note that mozilla-central is now string and feature frozen. This means that any patches which:

  • add strings,
  • change the semantic meaning of strings,
  • alter APIs that can be used by extensions or third party software,
  • add new web compatibility or user facing features

must be explicitly approved by Firefox 4 drivers (beltzner, damons, johnath, shaver, roc, dbaron, sayrer, jst)

Please see #developers or today's Sheriff if you have questions.

mozilla-1.9.2 - 1.9.2 Branch (Firefox 3.6.x, Gecko 1.9.2.x work)

When open: RESTRICTED to approved checkins only

Rules

  • patches must have been checked in and "baked" on mozilla-central,
  • patches must have approval1.9.2.x+ (for whatever value of x is relevant).
  • Set the "status1.9.2" flag to the relevant "fixed .x" value when the patch has been checked into the branch

Patches nominated for approval1.9.2.x should:

  • have tests, or a strong statement of what can be done in the absence of tests
  • have landed on trunk and baked for a few days (at least)
  • have an assessment of performance impact
  • have an assessment of risk

Please see #developers or today's Sheriff if you have questions.

Patch Approval & Release Driving

The branch approval queue is being monitored by branch drivers, all of whom are usually available on IRC.

mozilla-1.9.1 - 1.9.1 Branch (Firefox 3.5.x, Gecko 1.9.1.x work)

When open: RESTRICTED to approved checkins only

Rules

  • patches must have been checked in and "baked" on mozilla-central,
  • patches must have approval1.9.1.x+ (for whatever value of x is relevant).
  • Set the "status1.9.1" flag to the relevant "fixed .x" value when the patch has been checked into the branch

Patches nominated for approval1.9.1.x should:

  • have tests, or a strong statement of what can be done in the absence of tests
  • have landed on trunk and baked for a few days (at least)
  • have an assessment of performance impact
  • have an assessment of risk

Please see #developers or today's Sheriff if you have questions.

Patch Approval & Release Driving

The branch approval queue is being monitored by branch drivers, all of whom are usually available on IRC.

Firefox3.0 - Branch (Firefox 3.0.x only)

When open: RESTRICTED to branch-approved checkins only

Rules

  • patches must have approval1.9.0.x+ (for whatever version of x we are currently approving), or not affect the Firefox build (tests, NPOTB changes)
  • add the fixed1.9.0.x keyword to the bug when it has been checked into the branch

Patches nominated for approval-1.9.0.x should:

  • have tests, or a strong statement of what can be done in the absence of tests
  • have landed on trunk and baked for a few days (at least)
  • have an assessment of performance impact
  • have an assessment of risk

This tree is not sheriff'd. Please be sure to monitor for any bustage or performance regressions on the tree and take the appropriate back out actions.

Patch Approval & Release Driving

The branch approval queue is being monitored by branch drivers, all of whom are usually available on IRC.