752
edits
Phabricator/TestPlan: Difference between revisions
Jump to navigation
Jump to search
no edit summary
DaveLawrence (talk | contribs) No edit summary |
DaveLawrence (talk | contribs) No edit summary |
||
| Line 112: | Line 112: | ||
====Results==== | ====Results==== | ||
# moz-phab should automatically detect a revision and | # moz-phab should automatically detect a current revision and update it. | ||
# The revision is updated with the new diff on Phabricator: | # The revision is updated with the new diff on Phabricator: | ||
## The History tab should have two entries, Diff 1 and Diff 2. | ## The History tab should have two entries, Diff 1 and Diff 2. | ||
| Line 138: | Line 138: | ||
# The revision is visible to the user who made it. | # The revision is visible to the user who made it. | ||
# The revision is visible to users belonging to the security groups of the bug. | # The revision is visible to users belonging to the security groups of the bug. | ||
# Visiting the bug on Bugzilla shows an entry for the new revision in the Phabricator Revisions section. | # Visiting the bug on Bugzilla shows an entry for the new revision in the Phabricator Revisions section with summary as '(secure)'. | ||
# The revision is NOT visible to the public without logging in. | # The revision is NOT visible to the public without logging in. | ||
# The revision is NOT visible to logged in members without the correct permission. | # The revision is NOT visible to logged in members without the correct permission. | ||
| Line 153: | Line 153: | ||
# Go to bugzilla and create a security bug: | # Go to bugzilla and create a security bug: | ||
#* Click "Edit Bug", open the "Security" panel, and check one of the security-sensitive boxes, e.g. "Security-Sensitive Core Bug". | #* Click "Edit Bug", open the "Security" panel, and check one of the security-sensitive boxes, e.g. "Security-Sensitive Core Bug". | ||
# Edit the revision created above, and set the Bugzilla Bug ID field to the ID of the newly created bug. | # Edit the revision created above, and set the Bugzilla Bug ID field to the ID of the newly created private bug. | ||
# Add the second, unprivileged Bugzilla user to the bug's CC list. | # Add the second, unprivileged Bugzilla user to the bug's CC list. | ||
| Line 198: | Line 198: | ||
====Test Plan==== | ====Test Plan==== | ||
# Ensure that you have 2 Phabricator accounts that log in via Bugzilla ready to go. | # Ensure that you have 2 Phabricator accounts that log in via Bugzilla ready to go. | ||
# Create a commit | # Create a commit with other account as reviewer using <code>hg commit -m "Bug <bugid>: New changes r?<reviewer>"</code. | ||
# Run <code>moz-phab</code>. | |||
# Log into Phabricator as the reviewer account. | # Log into Phabricator as the reviewer account. | ||
# Add the "Accept Revision" action at the bottom. Submit. | # Add the "Accept Revision" action at the bottom. Submit. | ||
| Line 206: | Line 205: | ||
====Results==== | ====Results==== | ||
# The Phabricator | # The Phabricator revision is visible in the Bugzilla bug. | ||
# Reviewer received an email from author with a text "{author} added a reviewer: {reviewer}" | # Reviewer received an email from author with a text "{author} added a reviewer: {reviewer}" | ||
# Author received an email from reviewer with a text "{reviewer} accepted this revision." | # Author received an email from reviewer with a text "{reviewer} accepted this revision." | ||
| Line 214: | Line 213: | ||
====Test Plan==== | ====Test Plan==== | ||
# On a previously created revision, perform the "Abandon Revision" action from the "Add Action" dropdown. | # On a previously created revision, perform the "Abandon Revision" action from the "Add Action" dropdown. | ||
| Line 225: | Line 222: | ||
====Test Plan==== | ====Test Plan==== | ||
# In the revision | # In the revision used as part of the "Abandoning a revision obsoletes the attachment" test, perform the "Reclaim revision" action. | ||
====Results==== | ====Results==== | ||
# The bug's Phabricator attachment is unobsoleted and the | # The bug's Phabricator attachment is unobsoleted and the revision is not abandoned any longer in the Phabricator revisions list. | ||
=== T11 - Creating a Diff from local git repository to remote Mercurial repository is not allowed === | === T11 - Creating a Diff from local git repository to remote Mercurial repository is not allowed === | ||