Phabricator/Bugzilla Equivalents - Revision history

Glob at 04:43, 15 June 2021

2021-06-15T04:43:12Z

← Older revision		Revision as of 04:43, 15 June 2021
Line 59:		Line 59:

	== Request '''checkin-needed''' to land your changes ==		== Request '''checkin-needed''' to land your changes ==
	~~At this time '''checkin-needed''' requests should use the current [~~https://~~developer~~.~~mozilla~~.~~org~~/en-US/~~docs~~/~~Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree checkin~~-~~needed process]~~. ~~'''checkin-needed''' can be set on~~ the ~~bug linked~~ to the ~~Phabricator revision you wish~~ to ~~land~~. ~~There is a plan~~ to ~~move '''checkin-needed''' to Phabricator fully, look out for an announcement when that is further along (Tracking [https://bugzilla.mozilla.org/show_bug.cgi?id=1514807 Bug 1514807])~~.		https://groups.google.com/g/firefox-dev/c/3JGrgQMM6lM

			We intend to phase out the “Check-in Needed” flag. Instead, reviewers should queue patches in Lando once they are satisfied with the submitted patch.

			In order to help ensure that nothing slips through the cracks, the existing autonag bot will be updated to needinfo not only the patch author but also the reviewer if it has gotten r+ but not landed within 2 weeks. The patch contribution documentation will also be updated to take into account these changes.

	= Responding to requests =		= Responding to requests =

Glob: /* Request feedback? on a patch */

2020-03-03T05:17:43Z

Request feedback? on a patch

← Older revision		Revision as of 05:17, 3 March 2020
Line 16:		Line 16:
	* Using an '''@''' mention. Including '''@<username>''' in a comment on Phabricator notifies the provided user of your message. The notification is a one-time action which does not require acknowledgement, so it is best to make it clear with your text that you are expecting feedback.		* Using an '''@''' mention. Including '''@<username>''' in a comment on Phabricator notifies the provided user of your message. The notification is a one-time action which does not require acknowledgement, so it is best to make it clear with your text that you are expecting feedback.
	[[File:At-mention.png\|479px]]		[[File:At-mention.png\|479px]]

			* If the patch is work-in-progress, be sure to mark it as such by publishing a '''changes planned''' action.

	== Make a '''needinfo?''' request ==		== Make a '''needinfo?''' request ==

Glob: /* Carry forward a review+ flag */

2019-02-27T13:35:21Z

Carry forward a review+ flag

← Older revision		Revision as of 13:35, 27 February 2019
Line 36:		Line 36:

	To ask for a re-review select "Request Review" from the actions menu at the bottom of the page.		To ask for a re-review select "Request Review" from the actions menu at the bottom of the page.

			[[File:Request-review.png\|188px]]

	== Clear a '''review?''' flag from your own patch ==		== Clear a '''review?''' flag from your own patch ==

Glob: /* Carry forward a review+ flag */

2019-02-27T13:33:38Z

Carry forward a review+ flag

← Older revision		Revision as of 13:33, 27 February 2019
Line 34:		Line 34:

	Unlike Bugzilla there is no need to manually "carry forward" reviews from older revisions of patches to updated revisions. Instead the changes will show as accepted, with an indicator that the acceptance was set on an older revision.		Unlike Bugzilla there is no need to manually "carry forward" reviews from older revisions of patches to updated revisions. Instead the changes will show as accepted, with an indicator that the acceptance was set on an older revision.

			To ask for a re-review select "Request Review" from the actions menu at the bottom of the page.

	== Clear a '''review?''' flag from your own patch ==		== Clear a '''review?''' flag from your own patch ==

Glob at 14:04, 21 February 2019

2019-02-21T14:04:02Z

← Older revision		Revision as of 14:04, 21 February 2019
Line 30:		Line 30:

	Phabricator does have the [https://phabricator.services.mozilla.com/pholio/ Pholio] application for commenting on mocks. Unfortunately it is not well integrated with the rest of our workflows and you cannot flag specific users for review. You can find Pholio in the main menu as "Design Review", and a new image can be uploaded by clicking [https://phabricator.services.mozilla.com/pholio/create/ "Create Mock"] on the main Pholio page.		Phabricator does have the [https://phabricator.services.mozilla.com/pholio/ Pholio] application for commenting on mocks. Unfortunately it is not well integrated with the rest of our workflows and you cannot flag specific users for review. You can find Pholio in the main menu as "Design Review", and a new image can be uploaded by clicking [https://phabricator.services.mozilla.com/pholio/create/ "Create Mock"] on the main Pholio page.

			== Carry forward a '''review+''' flag ==

			Unlike Bugzilla there is no need to manually "carry forward" reviews from older revisions of patches to updated revisions. Instead the changes will show as accepted, with an indicator that the acceptance was set on an older revision.

	== Clear a '''review?''' flag from your own patch ==		== Clear a '''review?''' flag from your own patch ==

Kmoir: /* Watch a component */

2019-02-06T14:35:35Z

Watch a component

← Older revision		Revision as of 14:35, 6 February 2019
Line 87:		Line 87:
	== Watch a component ==		== Watch a component ==
	Phabricator has a notification system, [https://phabricator.services.mozilla.com/herald/ Herald], which allows you to create custom notification rules. This can be used to subscribe yourself to revisions that touch certain parts of the code base, or even add yourself as a reviewer. You can view example rules other user's have created [https://phabricator.services.mozilla.com/herald/query/all/ here].		Phabricator has a notification system, [https://phabricator.services.mozilla.com/herald/ Herald], which allows you to create custom notification rules. This can be used to subscribe yourself to revisions that touch certain parts of the code base, or even add yourself as a reviewer. You can view example rules other user's have created [https://phabricator.services.mozilla.com/herald/query/all/ here].

			== How do I deal with non-mozilla branch patches after bugzilla review flags are disable on components on Feb 28? ==

			In the announcement, it states

			Initially, only code landing in mozilla-central will be required to be reviewed in Phabricator. Once we have implemented more processes in Phabricator, we will move reviews of all of the mozilla-central “branches” to Phabricator.

			What does this mean for cases where a separate branch patch needs to be written after Feb 28 before it's possible to review the other branches in Phabricator?

			You can review anything Phabricator, however Lando can't land to the other "branches" at this time. Uplift approval will also be moved at a later date.

Smacleod: Finish off last WIP items.

2019-02-06T03:11:04Z

Finish off last WIP items.

← Older revision		Revision as of 03:11, 6 February 2019
Line 83:		Line 83:

	== Upload a WIP patch ==		== Upload a WIP patch ==
	~~TODO: Not sure if this workflow should~~ be ~~integrated into~~ the ~~request feedback section~~.		Work in progress patches can be uploaded to Phabricator in the same way as a normal patch, although generally you would not add reviewers. If you'd like someone to look at your WIP patch you may add reviewers but it is best to explicitly mention what you expect from the reviewer.

	== Watch a component ==		== Watch a component ==
	~~TODO~~: Herald ~~for subscribing~~ to ~~file changes~~.		Phabricator has a notification system, [https://phabricator.services.mozilla.com/herald/ Herald], which allows you to create custom notification rules. This can be used to subscribe yourself to revisions that touch certain parts of the code base, or even add yourself as a reviewer. You can view example rules other user's have created [https://phabricator.services.mozilla.com/herald/query/all/ here].

Smacleod: Fill out checkin-needed task.

2019-02-04T16:59:39Z

Fill out checkin-needed task.

← Older revision		Revision as of 16:59, 4 February 2019
Line 1:		Line 1:
	Some common tasks in Bugzilla do not have direct analogues in Phabricator and others may not be obvious to a new user. This page serves to document these common tasks and how to handle similar situations when using Phabricator.		Some common tasks in Bugzilla do not have direct analogues in Phabricator and others may not be obvious to a new user. This page serves to document these common tasks and how to handle similar situations when using Phabricator.


	= Making requests to other users =		= Making requests to other users =
Line 19:		Line 18:

	== Make a '''needinfo?''' request ==		== Make a '''needinfo?''' request ==

	Phabricator does not have a feature directly comparable to Bugzilla's '''needinfo?''' request. We suggest one of the following alternatives:		Phabricator does not have a feature directly comparable to Bugzilla's '''needinfo?''' request. We suggest one of the following alternatives:

Line 34:		Line 32:

	== Clear a '''review?''' flag from your own patch ==		== Clear a '''review?''' flag from your own patch ==

	There are two ways to remove a patch from the queue of your reviewers:		There are two ways to remove a patch from the queue of your reviewers:

Line 52:		Line 49:

	== Request '''checkin-needed''' to land your changes ==		== Request '''checkin-needed''' to land your changes ==
	~~TODO~~: ~~Move~~ to ~~phabricator tag~~.		At this time '''checkin-needed''' requests should use the current [https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree checkin-needed process]. '''checkin-needed''' can be set on the bug linked to the Phabricator revision you wish to land. There is a plan to move '''checkin-needed''' to Phabricator fully, look out for an announcement when that is further along (Tracking [https://bugzilla.mozilla.org/show_bug.cgi?id=1514807 Bug 1514807]).



	= Responding to requests =		= Responding to requests =

Smacleod: Document Pholio as a not well integrated workflow, recommending bugzilla still.

2019-02-04T15:51:22Z

Document Pholio as a not well integrated workflow, recommending bugzilla still.

← Older revision		Revision as of 15:51, 4 February 2019
Line 29:		Line 29:

	== Request '''review?''' of an image file ==		== Request '''review?''' of an image file ==
	If you have a stand-alone image you'd like ~~to ask for review~~ on you may do so using the [https://phabricator.services.mozilla.com/pholio/ Pholio] ~~Phabricator~~ application. You can find Pholio in the main menu as "Design Review", and a new image can be uploaded by clicking [https://phabricator.services.mozilla.com/pholio/create/ "Create Mock"] on the main Pholio page.		If you have a stand-alone image you'd like feedback on you may still do so using Bugzilla. Since the '''review?''' flag may be disabled for the component, please use a '''needinfo?''' or '''feedback?''' flag.

			Phabricator does have the [https://phabricator.services.mozilla.com/pholio/ Pholio] application for commenting on mocks. Unfortunately it is not well integrated with the rest of our workflows and you cannot flag specific users for review. You can find Pholio in the main menu as "Design Review", and a new image can be uploaded by clicking [https://phabricator.services.mozilla.com/pholio/create/ "Create Mock"] on the main Pholio page.

	== Clear a '''review?''' flag from your own patch ==		== Clear a '''review?''' flag from your own patch ==

Smacleod: Clear up some whitespace.

2019-02-04T15:45:59Z

Clear up some whitespace.

← Older revision		Revision as of 15:45, 4 February 2019
Line 82:		Line 82:
	== Save a frequently used query ==		== Save a frequently used query ==
	Most query advanced query pages have a "Save Query" button on the results page. Clicking this allows you to give the query a name and add it to your personal query list. After saving a query you can share it with others by copying the URL of the results page (Note, this URL does not include the saved query name and is quite opaque).		Most query advanced query pages have a "Save Query" button on the results page. Clicking this allows you to give the query a name and add it to your personal query list. After saving a query you can share it with others by copying the URL of the results page (Note, this URL does not include the saved query name and is quite opaque).






	= Other Tasks =		= Other Tasks =