WebDriver/RemoteProtocol/Meetings/2019/07/23 - Revision history

Whimboo: Whimboo moved page Remote/Meetings/2019/07/23 to WebDriver/RemoteProtocol/Meetings/2019/07/23: Reorganization for WebDriver BiDi project documenation

2021-02-26T20:09:19Z

Whimboo moved page Remote/Meetings/2019/07/23 to WebDriver/RemoteProtocol/Meetings/2019/07/23: Reorganization for WebDriver BiDi project documenation

← Older revision	Revision as of 20:09, 26 February 2021
(No difference)

Ato: /* PTO (☀️) */ oc

2019-07-23T16:57:46Z

PTO (☀️): oc

← Older revision		Revision as of 16:57, 23 July 2019
Line 88:		Line 88:

	== PTO (☀️) ==		== PTO (☀️) ==

			* ochameau away Friday 26 July

Ato: /* Agenda */ sanitise

2019-07-23T16:57:00Z

Agenda: sanitise

← Older revision		Revision as of 16:57, 23 July 2019
Line 3:		Line 3:
	* Brief update from security review meeting (ato)		* Brief update from security review meeting (ato)
	* Puppeteer client workarounds and changes (ato)		* Puppeteer client workarounds and changes (ato)
	** Should we track what changes we need?		* Gutenberg update (jdescottes)
	** How do we see the scope of these changes in the long-term?
	* Spreadsheet for currently failing Gutenberg ~~tests is https://docs.google.com/spreadsheets/d/1rCKRDW4WNZXs2f9-Bm9CMuV9EAUXoHGHbD3GHYY6zdo/edit#gid=15969737~~ (~~julian)~~
	* Many gutenberg tests failing because of unexpected logs, opinions on the strategy to adopt: hide messages on our side or push the responsibility to the test writer? (julian)
	* Current work/coming up next		* Current work/coming up next
	* Other announcements?		* Other announcements?

Ato: /* Minutes */ do

2019-07-23T16:56:15Z

Minutes: do

← Older revision		Revision as of 16:56, 23 July 2019
Line 18:		Line 18:

	== Minutes ==		== Minutes ==

			=== Puppeteer client workarounds and changes ===

			The extent of the changes we’ve made to the Puppeteer client so far are limited to the necessary workarounds for getting the tests barely running with Firefox. The changes are almost exclusively limited to the lib/Launcher.js file, which deals with finding the browser binary, profile/<code>user-data-dir</code> tweaks, and starting it as a subprocess.

			Beyond this we’re expecting the Firefox CDP implementation not to diverge on the interface level from Chrome. For certain domains—such as console- and network logging—we may see the server return messages with varying ''content'', but the ''interaction'' from the client’s point of view should remain 1:1 comparable with Chrome.

			Maintaining a single client, with abstractions for Chrome’s and Firefox’ launcher code, would likely be beneficial. We may however have to maintain a fork of Puppeteer until we have something more tangible to upstream, since we don’t want to block upstream Puppeteer from releasing newer versions. We should however work in such a way that we maintain Chrome support in the fork, rather than replacing it.

			=== Brief update from security review meeting ===

			The security testing meeting went fine, and we answered some questions. Not heard back after this, but we expect sec-review to not be a problem.

			=== Gutenberg progress ===

			See [https://docs.google.com/spreadsheets/d/1rCKRDW4WNZXs2f9-Bm9CMuV9EAUXoHGHbD3GHYY6zdo/edit#gid=15969737 spreadsheet for currently failing Gutenberg tests].

			Many Gutenberg tests failing because of unexpected console logs. Unlike WebDriver, Puppeteer/CDP does not have ''classes'' or ''variant types'' of errors, which means tests typically rely on parsing the error message string.

			Since we can’t change the messages for these errors without risking web compat problems for the web platform, we must find a way to work around this in order to pass more Gutenberg tests. One particular worry is that Gutenberg is not an isolated case, and that other test suites in the wild do the same thing.

			Ideally, it was argued in the meeting, the different non-platform errors, for example from the CSS parser, would be uniquely identifiable and defined in a web standard. This would enable users of Puppeteer to work with console errors in a more reliable way across browsers. It is worth airing this idea with other vendors at a future point, but does not offer any practical, immediate solution.

			Other alternatives are to hide messages on the server side, or the push the responsibility on to the test writer. The conclusion from the meeting was to do the latter, which likely means in this case that we will have to upstream some patches to the WordPress project to include a couple of Firefox-specifc error ignores in order for us to pass more tests.

			=== Current work/coming up next ===

			* ato still working on fixing up Puppeteer-tests-on-try patches to address code review issues raised by build peers
			* ochameau has ceased work on the remote agent until new developers from Interop are joining, in order to maximise value of knowledge transfer
			* jdescottes has one patch that still needs review, dealing with JavaScript dialogues, but expects to transition now to work on Fission in DevTools

	== Changelog ==		== Changelog ==

Ato: /* Roster */ fill in

2019-07-23T15:50:46Z

Roster: fill in

← Older revision		Revision as of 15:50, 23 July 2019
Line 13:		Line 13:

	; Present		; Present
			: mmucci, jdescottes, ochameau, ato
	; Regrets		; Regrets
			: AutomatedTester

	== Minutes ==		== Minutes ==

Ato: /* Changelog */ fill out

2019-07-23T14:58:24Z

Changelog: fill out

@@ Line 20: / Line 20: @@
 <pre>
-TBA
+a5bfdec7f135    Bug 1563690 - Make Target class save a list of Connection rather than Session. r=remote-protocol-reviewers,jdescottes
 </pre>

Jdescottes: /* Agenda */

2019-07-23T14:55:57Z

Agenda

← Older revision		Revision as of 14:55, 23 July 2019
Line 5:		Line 5:
	** Should we track what changes we need?		** Should we track what changes we need?
	** How do we see the scope of these changes in the long-term?		** How do we see the scope of these changes in the long-term?
			* Spreadsheet for currently failing Gutenberg tests is https://docs.google.com/spreadsheets/d/1rCKRDW4WNZXs2f9-Bm9CMuV9EAUXoHGHbD3GHYY6zdo/edit#gid=15969737 (julian)
			* Many gutenberg tests failing because of unexpected logs, opinions on the strategy to adopt: hide messages on our side or push the responsibility to the test writer? (julian)
	* Current work/coming up next		* Current work/coming up next
	** Spreadsheet for currently failing Gutenberg tests is https://docs.google.com/spreadsheets/d/1rCKRDW4WNZXs2f9-Bm9CMuV9EAUXoHGHbD3GHYY6zdo/edit#gid=15969737 (julian)
	** Many gutenberg tests failing because of unexpected logs, opinions on the strategy to adopt: hide messages on our side or push the responsibility to the test writer? (julian)
	* Other announcements?		* Other announcements?

Jdescottes: /* Agenda */

2019-07-23T14:55:15Z

Agenda

← Older revision		Revision as of 14:55, 23 July 2019
Line 6:		Line 6:
	** How do we see the scope of these changes in the long-term?		** How do we see the scope of these changes in the long-term?
	* Current work/coming up next		* Current work/coming up next
			** Spreadsheet for currently failing Gutenberg tests is https://docs.google.com/spreadsheets/d/1rCKRDW4WNZXs2f9-Bm9CMuV9EAUXoHGHbD3GHYY6zdo/edit#gid=15969737 (julian)
			** Many gutenberg tests failing because of unexpected logs, opinions on the strategy to adopt: hide messages on our side or push the responsibility to the test writer? (julian)
	* Other announcements?		* Other announcements?

Ato: /* Agenda */ add back agenda item about puppeteer client

2019-07-23T14:54:18Z

Agenda: add back agenda item about puppeteer client

← Older revision		Revision as of 14:54, 23 July 2019
Line 2:		Line 2:

	* Brief update from security review meeting (ato)		* Brief update from security review meeting (ato)
			* Puppeteer client workarounds and changes (ato)
			** Should we track what changes we need?
			** How do we see the scope of these changes in the long-term?
	* Current work/coming up next		* Current work/coming up next
	* Other announcements?		* Other announcements?

Ato: Created page with "== Agenda == * Brief update from security review meeting (ato) * Current work/coming up next * Other announcements? == Roster == ; Present ; Regrets == Minutes == == Chan..."

2019-07-22T12:21:27Z

Created page with "== Agenda == * Brief update from security review meeting (ato) * Current work/coming up next * Other announcements? == Roster == ; Present ; Regrets == Minutes == == Chan..."

New page

== Agenda ==

* Brief update from security review meeting (ato)
* Current work/coming up next
* Other announcements?

== Roster ==

; Present
; Regrets

== Minutes ==

== Changelog ==

<pre>
TBA
</pre>

== Work ==

; Current milestone
: [https://bugzilla.mozilla.org/showdependencytree.cgi?id=1545057&hide_resolved=1 MVP dependency tree]
; General overview
: [https://bugzilla.mozilla.org/showdependencytree.cgi?id=1523097&hide_resolved=1 Puppeteer dependency tree]
: [https://bugzilla.mozilla.org/buglist.cgi?cmdtype=runnamed&namedcmd=Remote%20Protocol&list_id=14666841 All ze boogs]
; Velocity tracking
: [https://docs.google.com/spreadsheets/d/182H1G_KViy_2l_XA-kS9P3nLWpGvYpslDiF0D16NhUU/edit?usp=sharing Project tracking dashboard]
: [https://mzl.la/2JlLXmW All project work currently in development]
: [https://mzl.la/2VldnAk Available MVP project work]
: [https://mzl.la/2DRmpKB Completed MVP project work]

== PTO (☀️) ==