- 10:30 drs: hi everyone, looks like it's standup time. Rik davidg1 (I remembered this time) gsvelto gtorodelvalle thills
- 10:30 gsvelto: hi everybody
- 10:30 gtorodelvalle: Hey! :)
- 10:31 drs: ok so admin items
- 10:31 drs: thills and I now have wasabi devices
- 10:31 drs: which are the only cdma devices that we have
- 10:31 drs: I've been doing research to get it connected to a network here, but it's not looking good. I'm going to go to a store later today and see what they say
- 10:31 thills: drs I'm looking around to see if I can get a prepaid setup
- 10:31 drs: if anyone knows about cdma here it would be really helpful if you could give any info
- 10:32 gsvelto: drs, thills excellent, if you need a crash course on the current CDMA support just ask me because I wrote all of it
- 10:32 drs: gsvelto: ok that would be really helpful. maybe we should schedule something for the 3 of us
- 10:32 drs: we'll talk about that after
- 10:32 gsvelto: and since I didn't have a device to test I did everything against the specs & with unit-tests
- 10:32 drs: right
- 10:32 drs: that's it for my admin updates, gtorodelvalle has one too
- 10:33 gtorodelvalle: Just mentioning that whenever you consider it appropriate do not hesitate to contact me for IRC-reviews ;) since I feel bad going through many iterations of your comments :D
- 10:33 drs: ok, any more admin?
- 10:34 drs: my update: I again have nothing to draw attention to. I've been pretty light on reviews lately though so feel free to ask me for review if you need it (though remember I'm not a peer yet so it should probably go through Rik first)
- 10:34 drs: next is Rik
- 10:35 Rik: I think we should move to using a datastore for call log insertion, opened bug 1042576 about it
- 10:35 firebot: https://bugzil.la/1042576 — NEW — Move the insertion in call log to a datastore
- 10:35 Rik: the bug contains the reasons why I think it's a good idea
- 10:35 drs: seems like something we could take next sprint
- 10:36 Rik: if you have ideas for or against this, please say so there
- 10:36 Rik: (ping etienne_s for that)
- 10:36 drs: Rik: please remember to update this: https://wiki.mozilla.org/FirefoxOS/Comms/Dialer#Long-Term_Project_Ideas
- 10:36 Rik: that's it for me
- 10:36 drs: since we don't have every idea having a bug yet, we should keep them in sync
- 10:36 drs: once we have all the ideas either rejected or filed as bugs, we can remove that list
- 10:36 drs: next is davidg1
- 10:37 Rik: done
- 10:37 drs: thanks
- 10:37 davidg1: Hi, I have been looking at bug 976678. I am going to propose this patch https://github.com/mozilla-b2g/gaia/pull/22075. I will ni mchen and julienw, because they said it wasn't possible to use telephony channel from system
- 10:37 firebot: https://bugzil.la/976678 — UNCONFIRMED — [zffos1.3][P3](Local) During voice calls the sound alert for new SMS does not beep.
- 10:37 drs: is that something anyone here would know about?
- 10:37 davidg1: but I tried, and it works perfectly… so maybe I'm missing something
- 10:38 davidg1: done :)
- 10:38 drs: ok, gsvelto ^ not sure if you would know, but let's move on
- 10:38 drs: anyways it's your update time regardless
- 10:38 gsvelto: still working on bug 1002327
- 10:39 firebot: https://bugzil.la/1002327 — FIXED, gsvelto — We are trying to get imei by dialing the number *#06# on a device, which has two sim card slots, bu
- 10:39 gsvelto: I had to prepare a v1.3t uplift that used callbacks instead of promises (ugh)
- 10:39 gsvelto: I hope this is the last one
- 10:39 drs: fun
- 10:39 gsvelto: and I went through the first iteration with bug 1006592, I'm now preparing what I hope will be the final patch
- 10:39 firebot: https://bugzil.la/1006592 — ASSIGNED, gsvelto — While sending USSD code, last dialed number by user appears in dialer app
- 10:39 Rik: davidg1: you should put your patch on the bug and ask for feedback
- 10:39 gsvelto: and this is pretty much it
- 10:40 Rik: gsvelto: the bug is 1.4+, why a 1.3t patch?
- 10:40 drs: Rik: yeah, he said he's going to propose that patch
- 10:40 gsvelto: Rik, because I should have fixed that bug in another one which was a 1.3T+
- 10:40 drs: Rik: it's a regression from bug 990003
- 10:40 firebot: https://bugzil.la/990003 — FIXED, etienne — [Dolphin][Tarako][Perf][Dialer] It takes a long time for the call screen shows up
- 10:40 gsvelto: Rik, but I misunderstood the scope of the original bug and so the fix ended up split in two different bugs
- 10:41 Rik: gsvelto: have you verified that this will be taken in 1.3t? wouldn't want you to work on something that relman refuses
- 10:41 gsvelto: and I'm actually mixing things up, the uplift I'm preparing is for bug 1019783
- 10:41 firebot: https://bugzil.la/1019783 — FIXED, gsvelto — Output from *#06# on FLAME DIALER used to return 2 IMEI
- 10:41 gsvelto: and should have been in bug 1002327
- 10:41 gsvelto: it's requested by a vendor for certification so that's why I'm doing it
- 10:41 davidg has joined (Adium@53EF5629.3416E031.E21948B5.IP)
- 10:41 davidg1 has left IRC (Connection reset by peer)
- 10:42 gsvelto: these uplits are driving me nuts
- 10:42 drs: yeah...
- 10:42 drs: ok, let's move on
- 10:42 mariaoteo has joined (mariaoteo@moz-F6843A97.red-83-61-225.dynamicip.rima-tde.net)
- 10:42 drs: gtorodelvalle
- 10:42 gtorodelvalle: On my side just mentioning and sharing, mainly with Doug, that I will land the patch for bug 1010104 as soon as this meeting finishes since after 3 re-runs of a Travis task that got stuck, the only failure is due to a third party app. The rest is in the Etherpad page :)
- 10:42 firebot: https://bugzil.la/1010104 — ASSIGNED, gtorodelvalle — [Dialer][Call Screen] Baseline of the contact name when applying the fluid font size
- 10:43 drs: gtorodelvalle: link please?
- 10:43 gtorodelvalle: If no comments, next is thills :)
- 10:43 thills: bug 998147 landed on mozilla-central, but I believe (someone correct me if I'm wrong) that we need it to land on the release branch as well before we land the gaia portion.
- 10:43 firebot: https://bugzil.la/998147 — ASSIGNED, thills — [Dialer] A Missed Call notification is given when chosing to hang up on an incoming call
- 10:43 drs: thills: I took a look at it, and it doesn't look like it would break anything to land the gaia portion even if the gecko portion isn't landed
- 10:43 drs: but we can wait anyways, there's no rush
- 10:43 drs: it should get merged into central soon
- 10:43 thills: ok, yeah, let's wait
- 10:44 Rik: (I'll have one more admin note)
- 10:44 thills: and then still working on unit tests
- 10:44 thills: and that's it from my side
- 10:44 drs: thills: Bug 1039643
- 10:44 firebot: https://bugzil.la/1039643 — ASSIGNED, thills — Write some unit tests for shared/js/dialer/contacts.js
- 10:44 drs: Rik: go ahead
- 10:44 Rik: thills: 998147 is already on central, so you can land the gaia part
- 10:45 Rik: admin notes: we plan to turn off Travis pull request builds (see m.d.gaia). so you should get used to watch Gaia-try more than travis now
- 10:45 drs: oh yeah, look at comment 35
- 10:45 drs: ok thanks Rik
- 10:45 drs: meeting over, thanks everyone
- 10:45 drs: btw, if anyone needs help with gaia-try, let me know
- 10:45 gsvelto: thanks!
- 10:46 drs: it's a bit different than travis
|