WebDriver/RemoteProtocol/Meetings/2019/07/02

From MozillaWiki
Jump to: navigation, search

Agenda

  • Security review update (ato)
    • Meeting Wednesday at 15:30 BST
  • Inter-domain IPC calls (jdescottes)
  • Current work/coming up next
  • Other announcements
    • Summer intern deadline (ato)

Roster

Present
jdescottes, mmucci, AutomatedTester, ato, jeinbinder, past
Regrets

Minutes

Security review

There is a security review meeting tomorrow at 15:30–16:30 BST. Let ato know if you want to be there.

Inter-domain IPC calls

jdescottes has two proposals for inter-domain IPC calls. The most promising proposal (showcased in D36625) ensures parent domains are always instantiated/called first.

It also makes it possible for a parent domain implementation to delegate some of its work to the corresponding domain in the child process. In this particular example, Page.enable in the parent domain calls the child domain to set up some necessary DOM event listeners.

Alex notes that this should make it easier to switch to Fission, because we avoid the code duplication involved in delegating to the right process.

Current/upcoming work

Puppeteer tests on try

ato explains that he rebased the patches this morning, and figured out how to get Node.js on the test machine. The tests are timing out on try, presumably because we fail to start Firefox. This is because it does not have mozharness to set up the environment, but the idea is that we can circumvent that by running it headlessly (as Chrome does).

Key events progress

jdescottes and ochameau have done a lot of work on key events, and barring some of the more complex key combinations, it seems to be working well.

The more complicated cases require special-casing on non-Windows platforms, as explained in a comment on bug 1543142. Masayuki-san indicated that it would be good if EventUtils supported these, but that he did not have time to work on it now.

We may be able to argue that this is hindering web compatibility, if important websites are relying on these in their testing.

Basic browser context support

Alex has added basic browser context support to the remote agent by using contextual identities in the same fashion that Juggler did. This is strictly not a requirement for the Gutenberg tests, but is a fundamental requirement for running the Puppeteer tests. In fact, we now pass one Puppeteer test from end-to-end.

ato noted that we will know more once this patch and his to run the Puppeteer tests on try lands on central.

Other announcements

The deadline for applying for summer interns is in two weeks (17th July). We should make sure we put in one or two proposals.

Changelog

% git log --date=iso --pretty=format:'%ad%x09%H' -- remote/ | awk '$0 >= "2019-06-25" && $0 <= "2019-07-02"' | awk -F $'\t' '{print $2}' | xargs git show -s --format='%h%x09%s'
95ab7f31f930    Bug 1543185 - Implement Input.dispatchMouseEvent. r=remote-protocol-reviewers,ato
bb7878bac434    Bug 1562205 - Enable selectionchange on inputs for test browser_input_dispatchKeyEvent.js
3db4109b2fc2    Bug 1552325 - Implement Network.requestWillBeSent. r=remote-protocol-reviewers,ato
bef4776b91a6    Bug 1552325 - Land juggler's network observer. r=remote-protocol-reviewers,ato
d242e50d7508    Bug 1543142 - Wait for explicit events in dispatchKeyEvent test r=ochameau
0dd9803c007e    Bug 1543142 - Add basic test for dispatchKeyEvent r=remote-protocol-reviewers,ochameau
55f6ec5a527c    Bug 1543142 - Implement basic dispatchKeyEvent in parent Input domain r=ato
2f780b84a0a6    Bug 1536862 - Register RemoteAgent JS XPCOM by using new registration method. r=ato
e8ff3378345a    Bug 1545726 - Implement DOM.getBoxModel. r=remote-protocol-reviewers,ato
4f2b0a6061a9    Bug 1543151 - Implement DOM.getContentQuads. r=remote-protocol-reviewers,ato

Work

Current milestone
MVP dependency tree
General overview
Puppeteer dependency tree
All ze boogs
Velocity tracking
Project tracking dashboard
All project work currently in development
Available MVP project work
Completed MVP project work

PTO (☀️)

  • Note that Thursday 4th July is a US holiday
  • Alex away Friday 5th July