Gaia/SMS/Scrum/2.2S11: Difference between revisions

From MozillaWiki
< Gaia‎ | SMS‎ | Scrum
Jump to navigation Jump to search
Line 137: Line 137:
* Will handle review/feedback/need-info requests;
* Will handle review/feedback/need-info requests;
* Will work on review comments and assigned bugs.
* Will work on review comments and assigned bugs.
====Teja====
* Absent/no report


=== Day 3: 20th April ===
=== Day 3: 20th April ===

Revision as of 07:26, 20 April 2015

List of bugs

SMS issues handled by the SMS subteam (blocks the sprint bug 1156177)

Bugzilla link

Full Query
ID Assigned to Summary Blocking b2g Feature-b2g Whiteboard Resolution
1084298 Steve Chung [:steveck] [Messages] Decoupling the all inputs query logic from DOM tree structure --- No cf_feature-b2g [p=1] FIXED
1152758 Julien Wajsberg [:julienw] [Messages] Empty report panel when opening it for an SMS that has been sent/received from a SIM that's not in the device anymore - No cf_feature-b2g [p=1] FIXED
1153808 Oleg Zasypkin [:azasypkin] [Messages] Thread is not marked as read (in UI only) when thread is opened from notification 2.2+ No cf_feature-b2g [p=1] FIXED
1154993 Julien Wajsberg [:julienw] [flame][3.0]Can't view SMS that has no phone number associated --- No cf_feature-b2g [p=1] FIXED
1155509 [Messages][NG] Separated views should be able to handle all required system messages --- No cf_feature-b2g [p(2.2S11)=5] WONTFIX
1155534 [Messages][NG] Extract NewMessage view from Conversation view --- No cf_feature-b2g [p(2.2S13)=1][p(2.2S11)=5] WONTFIX

6 Total; 6 Open (100%); 0 Resolved (0%); 0 Verified (0%);


Remaining points and burndown chart

google chart api url for Sprint 2.2S11

Burndown chart
Remaining points
Start 11
Day 2
Day 3
Day 4
Day 5
Day 6
Day 7
Day 8
Day 9
Day 10
Day 11
Day 12
Day 13
End


SMS issues handled by the SMS subteam outside of the sprint (contains whiteboard "sms-sprint-2.2S11")

Full Query
ID Assigned to Summary Blocking b2g Feature-b2g Whiteboard Resolution
1010216 Oleg Zasypkin [:azasypkin] [Messages][Drafts] Improve consistency of the draft code in ThreadUI and ThreadListUI --- No cf_feature-b2g [sms-sprint-2.2S11][p=2] FIXED
1050823 Oleg Zasypkin [:azasypkin] [Messages][Refactoring] Revise "ThreadUI.updateHeaderData" call while retrieving threads --- No cf_feature-b2g [sms-sprint-2.2S11][p=1] FIXED
1148152 Oleg Zasypkin [:azasypkin] Intermittent conversion_banner_test.js | Message Type Conversion Banner Message Type Conversion Banner for new threads MMS to email conversion and reminders --- No cf_feature-b2g [sms-sprint-2.2S11] FIXED
1155542 Steve Chung [:steveck] [Messages][New Gaia Architecture] Centralizing the global components/styling into a folder --- No cf_feature-b2g [sms-sprint-2.2S11] FIXED
1156625 Oleg Zasypkin [:azasypkin] [Messages] ThreadList&Thread separation: separate JS files --- No cf_feature-b2g [sms-sprint-2.2S11] FIXED
1156631 Oleg Zasypkin [:azasypkin] [Messages] ThreadList&Thread separation: separate CSS and image files --- No cf_feature-b2g [sms-sprint-2.2S11] FIXED
1156711 Steve Chung [:steveck] [Messages][New Gaia Architecture] remove static attachment menu markup and replace with shared widget --- No cf_feature-b2g [sms-sprint-2.2S11] FIXED

7 Total; 7 Open (100%); 0 Resolved (0%); 0 Verified (0%);


All SMS issues tracked for this sprint (target milestone)

Bugzilla link

Full Query
ID Assigned to Summary Blocking b2g Feature b2g Resolution
1084298 Steve Chung [:steveck] [Messages] Decoupling the all inputs query logic from DOM tree structure --- --- FIXED
1148152 Oleg Zasypkin [:azasypkin] Intermittent conversion_banner_test.js | Message Type Conversion Banner Message Type Conversion Banner for new threads MMS to email conversion and reminders --- --- FIXED
1153808 Oleg Zasypkin [:azasypkin] [Messages] Thread is not marked as read (in UI only) when thread is opened from notification 2.2+ --- FIXED
1156177 SMS sprint 2.2S11 --- --- WONTFIX
1156625 Oleg Zasypkin [:azasypkin] [Messages] ThreadList&Thread separation: separate JS files --- --- FIXED

5 Total; 5 Open (100%); 0 Resolved (0%); 0 Verified (0%);


Sprint planning

Minutes are on a separate page.

Daily meetings

Day 2: 17th April

Steve

  • bug 1113466 - [Network Alert] Support CDMA CMAS Alert
    • Still waiting Carol's feedback, will ping Ansul to see if it's still urgent or not.
  • bug 1084298 - Select all patch updated with draft issue fixing
    • Hope it's the final update for the patch :p

bug 1155088 - [Messages] FDN error warnning dialog will not be displayed while resending the message

    • Small bug for resend part and small patch provided for review.
  • bug 1155507 - [Meta][Messages][New Gaia Architecture] View panel separation for content wrapper part
    • Create meta bug and other related items for view separation task
  • bug 1155542 - [Messages][New Gaia Architecture] Centralizing the global components/styling into a folder
    • Per discussion yesterday we'll prefer to split views into different views and this first step should be doable for current master

Today:

  • Creation panel separation bugs and take some items.
  • Push for CDMA CMAS patch feedback
  • Refactor the css part if I have time on this.

Julien

  • Moved forward on bug 1142540 (contacts.js move to promises)
    • was landed (and already 1 regression ;) )
  • bug 1015194: started refactoring how recipients valid/invalid are handled. Moving a lot of code around
    • progressed and got feedback
  • reviewed Oleg's patch about integration tests: bug 1043903
  • continued the discussion with Bevis about retrying sending SMS (bug 1152730). This is one of the pain points for Alexandre Lissy (gerard-majax).
    • Gecko does not want to do any change...
  • reviewed bug 1084298 about decoupling select interfaces from DOM
  • reviewed bug 1126279 about separating the UI and the action parts of markThreadRead and deleteThread actions in thread_list_ui (for the "undo" work by Rishav)
  • gave feedback on bug 1127398 to display the correct thread when tapping a phone number in a message + good cleanup

Today: I want to:

If I have more time :

  • continue the prototype caching the thread list to a single db (including contacts/drafts/etc).
  • move forward some background matters (organize group MMS bugs, and drafts handling issues started some weeks ago)
  • I'd like to work on the deduplication logic for network alerts, it seems important for users (bug 1067938)

Oleg

  • bug 1043903 - [Messages][Tests] Add integration tests for the thread panel with a large number of messages
    • Got feedback/review, will fix review comments when I have some brain-switch time (in background).
  • bug 1151843 - [Messages][Refactoring] Use notification "data" attribute instead of icon URL query string parameters
    • Got r+ and landed (landed).
  • bug 1153808 - [Messages] Thread is not marked as read (in UI only) when thread is opened from notification
    • Prepared patch, tried to keep it simple (in review)
  • bug 1155509 - [Messages][New Gaia Architecture] Split ThreadList view from current structure
    • Started to work on this, more thinking than code yet (in progress)

Today:

  • Will handle review/feedback/need-info requests;
  • Will work on review comments and assigned bugs.

Day 3: 20th April

Steve

  • bug 1113466 - [Network Alert] Support CDMA CMAS Alert
    • Got some feedback from Carol , will update patch will unit test for review/feedback later.
  • bug 1084298 - Select all patch updated with draft issue fixing
    • Fix the last nits for landing

bug 1155088 - [Messages] FDN error warnning dialog will not be displayed while resending the message

    • Got r+ and apply the suggestion
  • bug 1155542 - [Messages][New Gaia Architecture] Centralizing the global components/styling into a folder
    • Create a WIP that move the global assets into another subfolder and with some polishing

Today:

  • App folder structure polish.
  • Update CDMA CMAS patch for review
  • Refactor the css part if I have time on this.

Julien

  • bug 1015194: started refactoring how recipients valid/invalid are handled. Moving a lot of code around
    • no progress -- will progress in background during the sprint but not at full speed
  • reviewed bug 1084298 about decoupling select interfaces from DOM
    • still one small issue: "function xxx(id = +id)" doesn't do what Steve thought :)
  • reviewed small bug 1153808 about marking a thread read when loading from the notification
  • gave feedback on bug 1144612 about refactoring CSS building blocks
    • I need to speak with Wilson about Web Components (trying to see if the work to refactor CSS will last or would be replaced soon). My opinion is that some part will last (we won't replace everything now) and anyway we'll learn useful things in the process.
  • tried to reproduce bug 1136211 before/after patch but I couldn't reproduce before... so I can't verify the bug. But I'm sure I could reproduce earlier on so I'll need to remember how I did :p

Others:

  • spent a good part of the day working on a lightsaber patch (took a lot more time than I wanted...).
  • created the sprint's bug and wiki page but haven't finished marking dependencies yet

Today: I want to:

If I have more time :

  • take a new bug in the sprint

If all this moves forward well, I could:

  • continue the prototype caching the thread list to a single db (including contacts/drafts/etc).
  • move forward some background matters (organize group MMS bugs, and drafts handling issues started some weeks ago)
  • I'd like to work on the deduplication logic for network alerts, it seems important for users (bug 1067938)

Oleg

  • bug 1043903 - [Messages][Tests] Add integration tests for the thread panel with a large number of messages
    • No progress (in background).
  • bug 1153808 - [Messages] Thread is not marked as read (in UI only) when thread is opened from notification
    • Got review, will fix review comment and ask for review today (in progress)
  • bug 1155654 - [Messages] Use bower to manage gaia web components dependencies
    • Thought it may be convenient to use bower in sms since both threads.js and little-browser are web components and in active development (+ switched gaia-header, gaia-theme, gaia-icons to bower as well), but looks like Julien doesn't like the idea :) Do you guys think we should manually update our own copy of threads.js and little-browser.js or put it into /shared?
      (Julien) I'd be fine with adding threads/little-browser.js to the bower components we already have in /shared. I think we could have our own bower components only when having a separate repository. Otherwise it's really a mess when the libs are updated, and we always stay on a old version... And these days the libs will be updated often.
      (Oleg) IIRC Wilson was eager to get rid of shared/elements, do you think we'll forget to update bower folder in time?
      (Steve) I think we'll need to use bower for management in long tern, and updating the bower folder is not really a good way IMO.
      (Julien) Yes I think this is just another task we'll need to do and remember :/
      (Oleg) Just question, is it possible to have pre-commit hook for one folder (apps/sms) only for example that can update bower components?
      (Julien) I don't think so.. and requesting network when committing is not really a good practice anyway :)
      (Julien) I really don't object for it longterm, but I think it's too soon. If Wilson really wants to kill /shared/elements then we can revisit for sure.
      (Oleg) Okay, let's leave it alone for now :) We need to ask Wilson then to maintain shared/threads and little-browser and keep it updated.
      (Julien) for gaia-header, usually we were updating /shared/ in the normal process of landing patches to gaia-header.
      (Oleg) Yeah, that's why dev who changes threads/little-browser should take care about it.
  • bug 1155509 - [Messages][New Gaia Architecture] Split ThreadList view from current structure
    • Hope to have smth ready for feedback today\tomorrow (in progress)
  • bug 1127398 - [Messages] Display existing thread when sending a message using phone-number-/email-link context menu
    • Got feedback, will handle feedback comments in the background (in background).

Other:

  • Reviewed Steve's "FDN error dialog" PR, looks good, r+'ed.

Today:

  • Will handle review/feedback/need-info requests;
  • Will work on review comments and assigned bugs.

Day 4: 21st April

Day 5: 22nd April

Day 6: 23rd April

Day 7: 24th April

Day 8: 27th April

Day 9: 28th April

Day 10: 29th April

Day 11: 30th April

Day 12: 1st May

Day 13: 4th May

Demos

Retrospective