TPE-Layout/2017-03-07: Difference between revisions

From MozillaWiki
Jump to navigation Jump to search
 
(7 intermediate revisions by 6 users not shown)
Line 5: Line 5:
==Weekly Status==
==Weekly Status==
===Astley Chen===
===Astley Chen===
* Campus Program
** NTU campus program meet-up.
* Webcompat bugs
** {{bug|1344395}} - Reported from https://webcompat.com/issues/4893. Regressing from {{bug|605985}}


===Boris Chiou===
===Boris Chiou===
Line 10: Line 14:
* {{Bug|1343753}} - stylo: Update CSS transitions with servo's computed values instead of nsStyleContext
* {{Bug|1343753}} - stylo: Update CSS transitions with servo's computed values instead of nsStyleContext
** study
** study
<b>Release Engineering - stylo</b>
* {{Bug|1344144}} - Trychooser: Add the option for linux64-stylo in TryChooser Syntax Builder
** file | r?
<b>Animations</b>
<b>Animations</b>
* {{Bug|1248340}} - Implement frames() timing function
* {{Bug|1248340}} - Implement frames() timing function
Line 15: Line 22:
** ready to land
** ready to land
* [https://github.com/servo/servo/issues/15740 servo/issues/15740] - Implement frames timing function
* [https://github.com/servo/servo/issues/15740 servo/issues/15740] - Implement frames timing function
** wip
<b>Reviews</b>
<b>Reviews</b>
* {{Bug|1344533}} - Replace OwningElementRef::GetRenderedPresContext with nsContentUtils::GetContextForContext()
* {{Bug|1344533}} - Replace OwningElementRef::GetRenderedPresContext with nsContentUtils::GetContextForContext()
Line 21: Line 29:


===Cameron McCormack===
===Cameron McCormack===
PTO, plus:
* {{Bug|1341230}} - add nsIDOMWindowUtils methods to add and remove EventStates for an element
** land
* {{Bug|1330843}} - Allow JS to create NAC pseudo-elements.
** WIP
'''Stylo reviews'''
* {{Bug|1339627}} - stylo: nsXULPrototypeCache needs to be able to hold ServoStyleSheets
* {{Bug|1342869}} - Assertion failure: child->mParent == this (We have a unique inner!), at StyleSheet.cpp:86
* {{Bug|1344135}} - ServoDeclarationBlock_SetPropertyById returns true in some cases when it should return false
* {{Bug|1341985}} - stylo: Mark element which needs to create/remove/modify CSS animations during traversal and create/remove/modify the animations after the parallel traversal
* {{Bug|1344964}} - stylo: Add atom "scroll-position" to nsGkAtomList


===CJ Ku===
===CJ Ku===


===Farmer Tseng===
===Farmer Tseng===
* {{Bug|1345710}} - [Mortar] [Windows] Implement Emf, PDFEngineExports and PdfPrintHelperWin
**WIP


===Jeremy Chen===
===Jeremy Chen===
Line 39: Line 64:
** file | land
** file | land
* {{Bug|1343512}} - Let CSS text-justify property ride the train
* {{Bug|1343512}} - Let CSS text-justify property ride the train
** file | r+
** file | r+ | land


===Shing Lyu===
===Shing Lyu===
Line 54: Line 79:


===Tingyu Lin===
===Tingyu Lin===
'''shape-outside'''
* {{Bug|1326409}} - Implement the rendering of basic shape polygon() for CSS shape-outside
** r?
'''Layout'''
'''Layout'''
* {{Bug|1341981}} - Convert frame completion and inline break in nsReflowStatus from double-bools bit flags to tri-state enum
* {{Bug|1341981}} - Convert frame completion and inline break in nsReflowStatus from double-bools bit flags to tri-state enum
** file | land
** file | land
* {{Bug|1342994}} - Convert nsPrintObject "mKids" array to use UniquePtr
** r?
'''Other'''
'''Other'''
* {{Bug|1341962}} - ccache stats parser breaks with ccache 3.3.3
* {{Bug|1341962}} - ccache stats parser breaks with ccache 3.3.3
Line 62: Line 92:


===Tommy Kuo===
===Tommy Kuo===
* {{Bug|1343819}} - Implement CSS property `line-height-step`
** file | WIP
** Pass 5 test cases and fail 3 test cases on spec (https://drafts.csswg.org/css-rhythm/).
* {{Bug|1344638}} - The behaviors of text-top / text-bottom are different to Blink and Edge.
** file


==Rule of Thumb==
==Rule of Thumb==

Latest revision as of 05:18, 28 March 2017

Weekly Announcement

Weekly Sharing

Weekly Status

Astley Chen

Boris Chiou

stylo animations

  • bug 1343753 - stylo: Update CSS transitions with servo's computed values instead of nsStyleContext
    • study

Release Engineering - stylo

  • bug 1344144 - Trychooser: Add the option for linux64-stylo in TryChooser Syntax Builder
    • file | r?

Animations

Reviews

  • bug 1344533 - Replace OwningElementRef::GetRenderedPresContext with nsContentUtils::GetContextForContext()
  • bug 1344598 - Use nsIDocument::IsStyledByServo to check we are using servo or not
  • bug 1344603 - Make Stop{Animations|Transitions}ForElement as a member function of CommonAnimationManager

Cameron McCormack

PTO, plus:

  • bug 1341230 - add nsIDOMWindowUtils methods to add and remove EventStates for an element
    • land
  • bug 1330843 - Allow JS to create NAC pseudo-elements.
    • WIP

Stylo reviews

  • bug 1339627 - stylo: nsXULPrototypeCache needs to be able to hold ServoStyleSheets
  • bug 1342869 - Assertion failure: child->mParent == this (We have a unique inner!), at StyleSheet.cpp:86
  • bug 1344135 - ServoDeclarationBlock_SetPropertyById returns true in some cases when it should return false
  • bug 1341985 - stylo: Mark element which needs to create/remove/modify CSS animations during traversal and create/remove/modify the animations after the parallel traversal
  • bug 1344964 - stylo: Add atom "scroll-position" to nsGkAtomList

CJ Ku

Farmer Tseng

  • bug 1345710 - [Mortar] [Windows] Implement Emf, PDFEngineExports and PdfPrintHelperWin
    • WIP

Jeremy Chen

CSS hyphens property

  • bug 1056516 - presence of explicit soft-hyphen in a word should override automatic hyphenation
    • r+/r?
    • pending review
  • bug 1343516 - Clean up the mess of PropertyProvider and its implementations
    • file

CSS text-justify property

  • bug 276079 - Implement text-justify property (with values: auto | none | inter-word | inter-character)
    • land
  • bug 1343593 - stylo: Update mochitest expectations after text-justify landed
    • file | land
  • bug 1343512 - Let CSS text-justify property ride the train
    • file | r+ | land

Shing Lyu

Stylo

Evangelism

  • Mentoring NTCU student servo project
  • Prepare STICON talk about Stylo
  • NTU course collaboration

Tingyu Lin

shape-outside

  • bug 1326409 - Implement the rendering of basic shape polygon() for CSS shape-outside
    • r?

Layout

  • bug 1341981 - Convert frame completion and inline break in nsReflowStatus from double-bools bit flags to tri-state enum
    • file | land
  • bug 1342994 - Convert nsPrintObject "mKids" array to use UniquePtr
    • r?

Other

  • bug 1341962 - ccache stats parser breaks with ccache 3.3.3
    • file | land

Tommy Kuo

Rule of Thumb

Status code:

  • OOAD: In analysis or design phase.
  • WIP: working on WIP patch.
  • feedback(f): feedback a patch
  • feedback?(f?): WIP is ready for feedback grant.
  • feedback+(f+): Get positive feedback.
  • feedback-(f-): Get negative feedback.
  • review(r): review a patch.
  • review?(r?): patch is under review
  • review+(r+): get review+ and ready to check-in
  • review-(r-): get negative review feedback. Fix problems and switch back to r? again.
  • land: patch check in.
  • debug: Figure out the root cause of a bug/ try to repro that bug, etc...
  • file: file a bug
  • PTO: take personal leave
  • interview(I)
  • study: Spend time on domain knowledge study, such as multimedia transport technology, compress format, real-time rendering.
  • presentation
    • Write a personal blog, which is relative to work, such as articles on MozTech, or what you experience in a work week.
    • WIKI/ MDN article writing.
    • If you write a technical blog or anything relative to work, it's welcome to share it on weekly report.
    • Do a presentation of technical topics