Sheriffing/How To/Backouts: Difference between revisions

From MozillaWiki
Jump to navigation Jump to search
No edit summary
No edit summary
Line 1: Line 1:
[[Category:Sheriffing:HowTo]]
{{Sheriffing How To|Backouts}}
When a patch is landed that causes build or test failures, it must be backed out to restore the tree to a passing or green state again.  
When a patch is landed that causes build or test failures, it must be backed out to restore the tree to a passing or green state again.  



Revision as of 16:45, 28 July 2017

When a patch is landed that causes build or test failures, it must be backed out to restore the tree to a passing or green state again.

How to perform backouts

With unified repos, backouts are now easier to perform. Please follow the instructions for backing out from unified repos.

Best Practices and Communication

Based on Feedback from the Sheriff Survey, when you have to do a backout, here are some best practices:

  • Ping the Developer in IRC if possible and when the developer is around, this gives the developer a chance to fix the problem and so avoid a backout. Some of the sheriffs use a 5 minute rule for the waiting of a response of the developer. Note: this is done as a courtesy to developers. You can and should backout patches if you feel it's being abused, e.g. the developer is not using the Try server
  • Set the NEEDINFO flag in bugzilla. This is very important! Developers get a lot of bugmail and backout comments can be missed. Please make sure that you set a NEEDINFO to the developer in the bug when doing a backout.
  • Make sure that the failures that lead to the backout are starred in Treeherder. This helps the next sheriff on duty.