Tree Rules: Difference between revisions

From MozillaWiki
Jump to navigation Jump to search
No edit summary
No edit summary
Line 1: Line 1:
== [http://tinderbox.mozilla.org/showbuilds.cgi?tree=Firefox mozilla-central] - Trunk (Firefox 3.2, Gecko 1.9.2 work) ==
== [http://tinderbox.mozilla.org/showbuilds.cgi?tree=Firefox mozilla-central] - Trunk (Firefox 3.2, Gecko 1.9.2 work) ==


'''Current status: <font color="red">CLOSED</font>'''
'''Current status: <font color="green">OPEN</font>''' for business


=== Rules ===
=== Rules ===
Line 13: Line 13:
== [http://tinderbox.mozilla.org/showbuilds.cgi?tree=Firefox3.1 mozilla-1.9.1] - 1.9.1 Branch (Firefox 3.1, Gecko 1.9.1 work) ==
== [http://tinderbox.mozilla.org/showbuilds.cgi?tree=Firefox3.1 mozilla-1.9.1] - 1.9.1 Branch (Firefox 3.1, Gecko 1.9.1 work) ==


'''Current status: <font color="red">CLOSED</font>'''
'''Current status: <font color="green">OPEN</font>''' for business


=== Rules ===
=== Rules ===
Line 31: Line 31:
== [http://tinderbox.mozilla.org/showbuilds.cgi?tree=Firefox3.0 Firefox3.0] - Branch (Firefox 3.0.x only) ==
== [http://tinderbox.mozilla.org/showbuilds.cgi?tree=Firefox3.0 Firefox3.0] - Branch (Firefox 3.0.x only) ==


'''Current status: <font color="red">CLOSED</font>'''
'''Current status: Branch-approved checkins only'''


=== Rules ===
=== Rules ===

Revision as of 16:55, 2 December 2008

mozilla-central - Trunk (Firefox 3.2, Gecko 1.9.2 work)

Current status: OPEN for business

Rules

  • checkins require proper reviews and should come with tests for any new or modified function;
  • before checking in, make sure that automated unit tests, mochitests and leak tests pass (you can check this locally);
  • after checking in, the committer *must* watch for regressions and be ready to back out if they appear;
  • checkins must adhere to standard tree rules, or not affect the Firefox builds (ex: NPOTB, tests)

Please see #developers or today's Sheriff if you have questions.

mozilla-1.9.1 - 1.9.1 Branch (Firefox 3.1, Gecko 1.9.1 work)

Current status: OPEN for business

Rules

  • patches must have been checked in and "baked" on mozilla-central,
  • patches must fix a blocker, be marked approval1.9.1+, or not affect Firefox builds
  • any string changes must be marked with the "late-l10n" keyword and have approval1.9.1+,
  • any add-on or theme compatibility changes must be marked with the "late-compat" keyword and have approval1.9.1+

Patches nominated for approval-1.9.1 should:

  • have tests, or a strong statement of what can be done in the absence of tests
  • have landed on trunk and baked for a few days (at least)
  • have an assessment of performance impact
  • have an assessment of risk

Please see #developers or today's Sheriff if you have questions.

Firefox3.0 - Branch (Firefox 3.0.x only)

Current status: Branch-approved checkins only

Rules

  • patches must have approval1.9.0.x+ (for whatever version of x we are currently approving), or not affect the Firefox build (tests, NPOTB changes)

Patches nominated for approval-1.9.0.x should:

  • have tests, or a strong statement of what can be done in the absence of tests
  • have landed on trunk and baked for a few days (at least)
  • have an assessment of performance impact
  • have an assessment of risk

This tree is not sheriff'd. Please be sure to monitor for any bustage or performance regressions on the tree and take the appropriate back out actions.

Patch Approval & Release Driving

The branch approval queue is being monitored by branch drivers, all of whom are usually available on IRC.