Bureaucrats, canmove, Confirmed users
645
edits
Firefox3/Viewport Security Review: Difference between revisions
Firefox3/Viewport Security Review (view source)
Revision as of 19:40, 13 August 2008
, 13 August 2008→Review Comments
(→Data) |
|||
| (5 intermediate revisions by 2 users not shown) | |||
| Line 40: | Line 40: | ||
== Reliability == | == Reliability == | ||
* What failure modes or decision points are presented to the user? | * What failure modes or decision points are presented to the user? | ||
** none | |||
* Can its files be corrupted by failures? Does it clean up any locks/files after crashes? | * Can its files be corrupted by failures? Does it clean up any locks/files after crashes? | ||
** no | |||
== configuration == | == configuration == | ||
* Can the end user configure settings, via a UI or about:config? Hidden prefs? Environment variables? | * Can the end user configure settings, via a UI or about:config? Hidden prefs? Environment variables? | ||
** no | |||
* Are there build options for developers? [#ifdefs, ac_add_options, etc.] | * Are there build options for developers? [#ifdefs, ac_add_options, etc.] | ||
** no | |||
* What ranges for the tunable are appropriate? How are they determined? | * What ranges for the tunable are appropriate? How are they determined? | ||
** n/a | |||
* What are its on-going maintenance requirements (e.g. Web links, perishable data files)? | * What are its on-going maintenance requirements (e.g. Web links, perishable data files)? | ||
** none | |||
== Relationships to other projects - are there related projects in the community? == | == Relationships to other projects - are there related projects in the community? == | ||
no, though it's based on an apple spec for the iPhone | |||
* | |||
== Review Comments == | |||
* Values are stored as pseudo-headers on the document which might conflict with real HTTP headers in the future -- not hard to imagine that if this concept catches on it might standardize as headers rather than <meta> tags. Should change names to some kind of namespace ("X-Moz-" prefix?) just in case. [https://bugzilla.mozilla.org/show_bug.cgi?id=450474 Bug 450474] | |||
* obeying "user-scalable=no" seems contrary to the Mozilla spirit of keeping the user in control (just an observation, this review didn't cover the chrome implementation which uses the parsed settings) | |||
* The implementation should be sure the underlying layout already deals with extreme values (size and scaling) in a reasonable manner, or perhaps even enforce it's own caps for sanity. | |||