Bureaucrats, canmove, Confirmed users
647
edits
Firefox3/OfflineApps Security Review: Difference between revisions
Firefox3/OfflineApps Security Review (view source)
Revision as of 22:06, 8 September 2008
, 8 September 2008→Review Comments
(→Data) |
|||
| (4 intermediate revisions by 2 users not shown) | |||
| Line 1: | Line 1: | ||
== Overview == | == Overview == | ||
| Line 20: | Line 19: | ||
== Security and Privacy == | == Security and Privacy == | ||
* A manifest can list an explicit entry that is not same-origin with the application. Say we have a manifest at http://application.com/app.manifest that looks like: | * A manifest can list an explicit entry that is not same-origin with the application. Say we have a manifest at http://application.com/app.manifest that looks like: | ||
| Line 49: | Line 45: | ||
== Module interactions == | == Module interactions == | ||
* What other modules are used (REQUIRES in the makefile, interfaces) | * What other modules are used (REQUIRES in the makefile, interfaces) | ||
** The implementations of nsSecurityManager::SecurityCompareURIs and nsContentUtils::OfflineAppAllowed were moved into nsNetUtil.h so that it could be used in netwerk/ | |||
** content/base/src added a REQUIRES on nkcache to access nsICachingChannel.h during cache selection. | |||
== Data == | == Data == | ||
| Line 78: | Line 76: | ||
* If so, what is the proposal's relationship to their work? Do you depend on others' work, or vice-versa? | * If so, what is the proposal's relationship to their work? Do you depend on others' work, or vice-versa? | ||
* Are you updating, copying or changing functional areas maintained by other groups? How are you coordinating and communicating with them? Do they "approve" of what you propose? | * Are you updating, copying or changing functional areas maintained by other groups? How are you coordinating and communicating with them? Do they "approve" of what you propose? | ||
== Review Comments == | |||
* caching rules differ from regular cache? Will always load cached copy if there is one. | |||
* are SSL pages cached, even though we normally don't? | |||
* What about cache-control: settings? | |||
* Once a page has an "offlineable" cache, all network loads must be specified in the manifest. | |||
* opt-in is per domain... | |||
** Should AT LEAST be scheme-host-port origins. | |||
** should it be per-manifest? | |||
* if we crash during caching, file will be written but not indexed. Will it get cleaned up? | |||
* fallback mode seems under-specified | |||
* fallback must be limited to same-origin | |||