Confirmed users
74
edits
DevTools/Code Review Checklist: Difference between revisions
m
typo
(First draft) |
m (typo) |
||
| Line 39: | Line 39: | ||
* User facing changes | * User facing changes | ||
** If a new piece of UI or new user interaction is added/modified, then Helen is ui-review? on the bug | ** If a new piece of UI or new user interaction is added/modified, then Helen is ui-review? on the bug | ||
** If a user facing string has been added, it is localized and follows the localization | ** If a user facing string has been added, it is localized and follows the localization guidelines at : https://wiki.mozilla.org/DevTools/Hacking#Guidelines | ||
** If a user-facing string has changed meaning, the key has been updated : https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings | ** If a user-facing string has changed meaning, the key has been updated : https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings | ||
** If a new image is added, it is a SVG image or there is a reason for not using a SVG | ** If a new image is added, it is a SVG image or there is a reason for not using a SVG | ||