Sheriffing/How To/Landing patches: Difference between revisions

Sheriffing/How To/Landing patches (view source)

Revision as of 11:40, 28 August 2018

11 bytes removed , 28 August 2018

→‎Landing patches via Lando- Autoland

NataliaCs

Confirmed users

79

edits

@@ Line 26: / Line 26: @@
 '''Manually''', from the <span style="color:#14866d">'''console'''</span> – and the patches will land on '''INBOUND'''
-== Landing patches via mozreview (reviewboard) - Autoland ==
+== Landing patches via Lando - Autoland ==
-*These patches will have an additional section on the bug, right above '''“Attachments”''', called <span style="color:#14866d">'''“MozReview Requests”'''</span>
+'''Steps:'''
-[[File:Mozreview.png|frame|center]]
+# Access the bug and go directly to the comment with the phabricator patch '''positively reviewed''', and open the given link:
-*'''Click the link''' under '''“MozReview Requests”''' and you will be redirected to another page, from where the commit can be landed:
+[[File:Phabricator review.png|thumb|center]]
-[[File:Land1.jpg|frame|center]]
+# On the right side of the page, under ''Edit Related Objects'', click on the '''View in Lando''' option:
-*Click on the '''dropdown menu''' from <span style="color:#14866d">'''Automation'''</span>, and then click on <span style="color:#14866d">'''Land Commits'''</span>.
+[[File:Phabricator lando link.png|thumb|center]]
+# To land this patch use the bottom right corner button. If the patch has not yet been landed, it will appear as ''“Land DXXXX”'' otherwise, it will appear as ''“Re-land”''
+[[File:Lando green button.png|thumb|center]]
+For more in-depth info regarding Phabricator, go to the [https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html#quick-start Mozilla Phabricator User Guide]
 <span style="color:#b32425">'''Note:  If you cannot land the patch from GUI:'''</span>
-# '''Comment''' this message on the bug: ''“The patch doesn't meet the review requirements in MozReview needed for Autoland to push it - see http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/autoland.html#landing-commits“''
+# '''Comment''' on the bug that the patch could not be applied.
 # '''Needinfo''' the developer
 # '''Remove''' the checkin-needed tag