139
edits
Media/WebRTC/libwebrtc Update Process Transition Plan: Difference between revisions
Media/WebRTC/libwebrtc Update Process Transition Plan (view source)
Revision as of 10:03, 9 March 2021
, 9 March 2021Adding process flow summary
(Correcting section break) |
(Adding process flow summary) |
||
| Line 41: | Line 41: | ||
Additionally there exists a fork of the WebRTC native library repository on Github at [https://github.com/mozilla/libwebrtc mozilla/libwebrtc]. As changes are made to libwebrtc within the merge, those changes will be gathered into a set of git commits to upstream. A second set of commits to retain but not upstream can also be maintained, but this set should be as close to empty as possible. During future libwebrtc merges the Github repository will be updated from the upstream google repository and our retained patches will be rebased on top of the new head. | Additionally there exists a fork of the WebRTC native library repository on Github at [https://github.com/mozilla/libwebrtc mozilla/libwebrtc]. As changes are made to libwebrtc within the merge, those changes will be gathered into a set of git commits to upstream. A second set of commits to retain but not upstream can also be maintained, but this set should be as close to empty as possible. During future libwebrtc merges the Github repository will be updated from the upstream google repository and our retained patches will be rebased on top of the new head. | ||
=====Process Flow===== | =====Process Flow===== | ||
Developers will work on top of the merge repository. Those changes will be pushed to Phabricator for review. Once approved, a change set is push on top of the current tip of the merge repository, and the revision is closed in Phabricator. If further changes need to be made to the contents of the revision, those should be done in a new change set. | |||
=====Reviews===== | =====Reviews===== | ||
=====Finalizing a Patch===== | =====Finalizing a Patch===== | ||
=====Shortcomings and Criticism===== | =====Shortcomings and Criticism===== | ||
* The user Mercurial repositories are non-publishing which leaves pushed commits in a draft state. | * The user Mercurial repositories are non-publishing which leaves pushed commits in a draft state. | ||