68
edits
Firefox/Projects/TabCandy/Work: Difference between revisions
Firefox/Projects/TabCandy/Work (view source)
Revision as of 21:27, 27 September 2010
, 27 September 2010→Landing
(→Bugs) |
|||
| Line 110: | Line 110: | ||
# Regardless of whether you're adding a test, try all the browser chrome tests locally: '''make -C ''<objdir>'' mochitest-browser-chrome''' | # Regardless of whether you're adding a test, try all the browser chrome tests locally: '''make -C ''<objdir>'' mochitest-browser-chrome''' | ||
# Attach your patch to the bug and assign it for feedback from one of the Panorama team | # Attach your patch to the bug and assign it for feedback from one of the Panorama team | ||
# Once you've got f+, mark it r? for review (ask in #tabcandy if you're not sure who to assign it to) | # Once you've got f+, mark it r? for review (dietrich, dolske, gavin are good candidates; ask in #tabcandy if you're not sure who to assign it to) | ||
# Once they've given you an r+, you'll need approval (unless it's already marked as a blocker, which means it's already approved for landing): | # Once they've given you an r+, you'll need approval (unless it's already marked as a blocker, which means it's already approved for landing): | ||
## Mark it with a question mark under "approval 2.0", if the reviewer hasn't already done so | ## Mark it with a question mark under "approval 2.0", if the reviewer hasn't already done so | ||