AMO:Editors/EditorGuide/AddonReviews: Difference between revisions

AMO:Editors/EditorGuide/AddonReviews (view source)

Revision as of 21:21, 19 January 2011

524 bytes removed , 19 January 2011

Added table for feature testing.

Jorge.villalobos

canmove, Confirmed users

1,448

edits

@@ Line 317: / Line 317: @@
 The link points directly to the add-on file.<br>
-[[Image:Install-link.png|center|Install link]]And these are the things that you should always check for:<br>
+=== [[Image:Install-link.png|center|Install link]]Policies and actions <br> ===
-*Keep the Error Console open at all times. JS errors in chrome scripts are unnaceptable. If you see any errors, make sure to copy the full error and include it in the message to the author, with indications on how to reproduce, when possible.<br>
-*The startup experience is very important. Many add-ons open dialogs or new tabs at startup, mostly offering information on getting started. This is useful, but it shouldn't block the user from using the browser. Opening modal (blocking) dialogs at startup is not allowed. Non-modal dialogs, separate windows or new tabs are allowed.<br>
-** One important thing to keep in mind is that most startup flows happen only once, and add-ons set preferences not to run them again. Since many add-ons leave their preferences after uninstall, you need to clean up your testing profile every now and then to get rid of lingering prefs and test all add-ons like it's the first time.
-*If the add-on is difficult to use, there should be instructions included in the add-on descriptions, or in a startup page or window. If the add-on is too difficult or impossible to figure out, it should be rejected.<br>
-*The [https://addons.mozilla.org/en-US/developers/docs/policies/reviews#section-defaults No Surprises policy] must be respected at all times. Changes to the homepage, default search engine, or other default settings without user consent is strictly forbidden. Whenever that decision is presented to the user, the default should always be not to perform any changes.<br>
-*Visit HTTPS sites like addons.mozilla.org and make sure the identity button is unchanged. This is specially important for add-on that insert scripts into sites. If site identity is broken, the add-on must be rejected.<br>
+{| width="650" cellspacing="0" cellpadding="1" border="1"
+|-
+! scope="col" | Policy
+! scope="col" | Action
+! scope="col" | Notes
+|-
+| Security violations
+| Reject
+| Adding HTTP content to secure pages. Visit HTTPS sites like addons.mozilla.org and make sure the identity button is unchanged. This is specially important for add-on that insert scripts into sites.
 [[Image:Identity-button.png|center|Identity button]]
+|-
+| [https://addons.mozilla.org/en-US/developers/docs/policies/reviews#section-defaults No Surprises] violation
+| Preliminary Review
+| Changing homepage, default search provider, including unexpected ads or content changes without explicit user opt-in.
+|-
+| Privacy violations
+| Preliminary Review
+| Incorrect or insufficient privacy policies, not respecting Private Mode.
+|-
+| Showing a modal dialog at startup
+| Preliminary Review
+| Many add-ons open dialogs or new tabs at startup, mostly offering information on getting started. This is useful, but it shouldn't block the user from using the browser. Opening modal (blocking) dialogs at startup is not allowed. Non-modal dialogs, separate windows or new tabs are allowed.
+|-
+| Errors in the Error Console
+| Preliminary Review
+|
+|-
+| Add-on is very hard to use without instructions
+| Preliminary Review
+| If the add-on is difficult to use, there should be instructions included in the add-on descriptions, or in a startup page or window.
+|-
+| Toolbar buttons are not customizable
+| Preliminary Review
+|
+|-
+| Affiliate linking
+| Preliminary Review
+| See details below.
+|-
+| Uses Geolocation without asking the user
+| Preliminary Review
+|
+|-
+| Requires third party software or paid registration
+| Admin Review
+|
+|}
+Other tests to perform:
 *Visit a very simple website like example.org and inspect its DOM, looking for any changes. Again, this is particularly important for extensions that insert scripts or make DOM changes.<br>
 *Open the add-on's preferences window, from the Add-ons Manager and elsewhere, and verify that preference changes apply properly. Make sure the window fits all of its contents (a common problem in Mac OS).<br>
 *Test all add-on features, within reason. If there too many, focus on the main features.<br>
-*If the add-on adds toolbars or toolbar buttons, try removing them using the toolbar customization dialog and then restarting Firefox. If they reappear, the add-on should be rejected for not respecting user choice.<br>
+*Affiliate linking. Some add-ons add affiliate codes to Amazon links (or similar) in order to make money. At the moment we allow this as long as (1) the add-on follows the No Surprises policy, (2) the feature doesn't replace or remove any existing affiliate codes, (3) the affiliate codes aren't inserted in the merchant website's links (inserting Amazon affiliate codes in Amazon.com pages).
-*Affiliate linking. Some add-ons add affiliate codes to Amazon links (or similar) in order to make money. At the moment we allow this as long as (1) the add-on follows the No Surprises policy, (2) the feature doesn't replace or remove any existing affiliate codes, (3) the affiliate codes aren't inserted in the merchant website's links (inserting Amazon affiliate codes in Amazon.com pages).<br>
-*If the add-on requires third-party software to be installed in order to function, flag it for admin review.
-*[[AMO:Editors/InfoEditors#Geolocation|Geolocation policies]], when applicable.<br>
 === Step 5: Resolution<br>  ===