Confirmed users
395
edits
Gaia/Hacking: Difference between revisions
→Contributing Code
Benfrancis (talk | contribs) No edit summary |
Benfrancis (talk | contribs) |
||
| Line 114: | Line 114: | ||
See [https://developer.mozilla.org/en-US/docs/Mozilla/Boot_to_Gecko/Gaia_Unit_Tests here] for more information on writing and running unit tests for Gaia. | See [https://developer.mozilla.org/en-US/docs/Mozilla/Boot_to_Gecko/Gaia_Unit_Tests here] for more information on writing and running unit tests for Gaia. | ||
== Filing Bugs == | |||
Bugs are filed on Bugzilla under [https://bugzilla.mozilla.org/buglist.cgi?product=Boot2Gecko&component=Gaia&resolution=--- Boot2Gecko > Gaia]. | |||
File a new bug under the Gaia component (or one of the sub-components) [https://bugzilla.mozilla.org/enter_bug.cgi?product=Boot2Gecko here] | |||
== Contributing Code == | == Contributing Code == | ||
| Line 148: | Line 153: | ||
(ideally the commit message should have r=REVIEWER_NAME added to the commit message of a the squashed commit and your patch includes a passing unit test) | (ideally the commit message should have r=REVIEWER_NAME added to the commit message of a the squashed commit and your patch includes a passing unit test) | ||
=== Reviewers === | |||
Gaia does not have formal module owners, but the following developers are good candidates to review patches to the following modules and apps: | |||
{|border=1 | |||
!Module | |||
!Reviewers (irc nick/github username) | |||
|- | |||
|Dialer | |||
|etienne_s/etiennesegonzac | |||
|- | |||
|Messages | |||
|timdream | |||
|- | |||
|Browser | |||
|benfrancis/benfrancis | |||
|- | |||
|Camera | |||
|benfrancis/benfrancis | |||
|- | |||
|Gallery | |||
|djf/davidflanagan, benfrancis/benfrancis | |||
|- | |||
|Video | |||
|djf/davidflanagan, kaze/fabi1cazenave | |||
|- | |||
|Homescreen | |||
|djf/davidflanagan | |||
|- | |||
|Keyboard | |||
|timdream | |||
|- | |||
|Settings | |||
|kaze/fabi1cazenave | |||
|- | |||
|Calculator | |||
|daleharvey/daleharvey | |||
|- | |||
|Music | |||
|djf/davidflanagan | |||
|- | |||
|Clock | |||
|etienne_s/etiennesegonzac | |||
|} | |||
=== Coding Style === | |||
* Background: | |||
** [[MDC:Developer Guide/Coding Style#General practices]] | |||
** [[MDC:Developer Guide/Coding Style#JavaScript practices]] | |||
** [[MDC:Developer Guide/Coding Style#Naming and formatting code]] | |||
* make sure HTML files are declared <!DOCTYPE html> (i.e., HTML5). IE9+ will load them in compatibility mode otherwise. | |||
* add a <code>"use strict";</code> statement (exactly that!) to the top of your JS files | |||
* 2 spaces for indentation - do not use tab. | |||
* Line break are free (I promise) don't hesitate to use them to separate logical block inside your functions. | |||
* Files are named <code>like_this.js</code>. | |||
* Use single quote instead of double quotes. | |||
* Additional rules: | |||
Bad: | |||
if (expression) doSomething(); | |||
Correct: | |||
if (expression) | |||
doSomething(); | |||
=== Before submitting a patch === | |||
On each javascript files you are adding or you have modified, run: | |||
gjslint --nojsdoc my_file.js | |||
http://code.google.com/closure/utilities/docs/linter_howto.html | |||
Set of smoke tests to run before you check-in a patch: | |||
[[media:PatchSmokeTests.pdf|PatchSmokeTests.pdf]] | |||
== Contacting The Team == | == Contacting The Team == | ||