Gecko:DeCOMtamination Algorithm: Difference between revisions

← Older edit

Gecko:DeCOMtamination Algorithm (view source)

Revision as of 02:14, 21 February 2007

266 bytes added , 21 February 2007

no edit summary

Tglek

Confirmed users

381

edits

@@ Line 1: / Line 1: @@
-#Select a candidate for DeCOMtamination (using Olmar or Oink)
+This algorithm is being implemented in [[Squash]]
-## Find all classes that inherit from ISupports
-## Filter out classes scriptable via XPConnect. ''How to detect them?''
+#Collapse the XPCom interface nsIClass class and the child nsClass that implements it.
-## Order them by the number of descendants.
+##Header Inference. Not all member variables are defined in public headers, find out what member variables are declared in nsClass that are not defined in public headers and can not use a forward declaration. Some options:
-## Select one with the least descendants
+##* Move Non-internal members into the base class, declare functions that use internal members as virtual. This also requires a factory method in the base class to return the derived class.
-#Collapse the XPCom interface nsIClass class and the child nsClass that implements it
+##* Make headers public, try again?
-##To avoid header pollution, find out what member variables are declared in nsClass that do not have headers for in the nsIClass and can not use a forward declaration.
+##'''Adds overhead:''' Rewrite them to form foo var to nsAutoPtr<foo> var. And add initializers for them to the constructor
-##Rewrite them to form foo var to nsAutoPtr<foo> var. And add initializers for them to the constructor
+##'''Adds overhead:''' Update code that uses var. Eg var.member becomes var->member, var passed in an argument by value/const reference becomes *var.
-##Update code that uses var. Eg var.member becomes var->member, var passed in an argument by value/const reference becomes *var.
 ##Place nsClass members into nsIClass removing virtual unless there are derivatives of nsClass
 ##* replace macros like NS_IMETHOD with nsresult
+##* If possible change code to return through return values instead of returning nsresults and results in an out parameter. See [[Gecko:Interface Style Guide]]
 ##Remove xpcom initializer like NS_NewClass(..)
 ##Remove nsIClass declaration