Update:Archive/1.0/Developers: Difference between revisions

no edit summary
No edit summary
 
(8 intermediate revisions by 3 users not shown)
Line 1: Line 1:
[[Update:Home_Page|Update Home Page]] » [[Update:Development|Development]] » Audit
{{AmoArchive}}


== Introduction ==
== Introduction ==
Line 237: Line 237:
=== Code Adjustments ===
=== Code Adjustments ===
* <strike>[https://bugzilla.mozilla.org/show_bug.cgi?id=283215 Patch branch to include local modifications in prod.] (under review)</strike>
* <strike>[https://bugzilla.mozilla.org/show_bug.cgi?id=283215 Patch branch to include local modifications in prod.] (under review)</strike>
* Update code based on quantified 'needed changes'(delayed until 03/16)
* Patching
** <strike>Rewrite VersionCheck.php</strike> (morgamic)
** <strike>Rewrite VersionCheck.php</strike> (morgamic)
*** This is currently being reviewed. (mconnor)
*** <strike>This is currently being reviewed. (mconnor)</strike>
** Update UMO configuration and structure to make development easier. (morgamic)
** <strike>Update UMO configuration and structure to make development easier.</strike> (morgamic)
*** Stripping out stuff like hard-coded paths
*** <strike>Stripping out stuff like hard-coded paths</strike>
*** Adding needed directories to CVS
*** <strike>Adding needed directories to CVS</strike>
*** Documenting requirements and installation procedure
*** Documenting requirements and installation procedure in Wiki (need help with this)
** Get PFS into CVS (morgamic, jst, kveton)
** <strike>Get PFS into CVS (morgamic, jst, kveton)</strike>
*** uniqueUrl.php needs to be excluded  
*** <strike>uniqueUrl.php needs to be excluded</strike>
*** it should probably be put into the private CVS
** <strike>Analyze</strike>, optimize PFS scripts. (morgamic, pending import being cleared by jst)
*** other scripts can go into CVS
** <strike>Prioritize needed work and create TODO lists.  (morgamic, alanjstr, pending patches)</strike> -- see hitlist below
** Analyze, optimize PFS scripts. (morgamic)
 
** Prioritize needed work and create TODO lists.  (morgamic, alanjstr)
** Deal out important patching (based on audit log) to community based on wiki information. (kveton, morgamic,alanjstr)
** Deal out important patching to community based on wiki information. (kveton, morgamic,alanjstr)
** <strike>Unfreeze branch and open it up for patching. (kveton)</strike>
** Unfreeze branch and open it up for patching. (kveton)
 
* If possible, update code for readability and efficiency
=== Hit list ===
# Developer Sessions, making sure login works correctly, nav options for admins are hidden (morgamic)
# Comment spam prevention for user ratings, reenabling comments for extensions and themes (chip)
# <strike>Set up -dev,-staging to automatically pull from branch, trunk(kveton)</strike>
# QA for submitted patches (Ctho, alanjstr)
# Run through remaining items in audit log that are important mainly (but not limited to):
## missing input validation
## bad loops
# Work through workflows for developers and admins (everyone)
# Merge branch with trunk (kveton)
# Push trunk into production (justdave,kveton)


=== Assessment ===
=== Assessment ===
Line 549: Line 559:


====/plugins/download.php====
====/plugins/download.php====
* [61-78] PHP is not for serving files.  Use a redirect that sends them to a URL instead.
* [61-78] PHP is not for serving files.  Is there a better way to get the user to their file?


====/plugins/PluginFinderService.php====
====/plugins/PluginFinderService.php====
canmove, Confirmed users, Bureaucrats and Sysops emeriti
1,043

edits