TPE-Layout/2017-02-14

Weekly Sharing

• Astley Chen
  • Quantum Release Countdown shared by heycam.
• Tommy Kuo
  • CSS Rhythmic Sizing
  • Blur shadow discussion (bug 1229979)

Weekly Status

Boris Chiou

stylo animations

• bug 1335942 - stylo: Need a way to convert RawServoAnimationValue to layers::Animatable
  • land
• bug 1337313 - stylo: Use RawServoAnimationValue for KeyframeEffectReadOnly::GetProperties()
  • land
• bug 1338087 - stylo: Stop storing StyleAnimationValue
  • wait for servo vcs sync
• bug 1337693 - stylo: Pass the hashtable into Servo_AnimationValues_Uncompute directly
  • file
• bug 1334036 - stylo: Support off-main-thread animations
  • wip

Animations

• bug 1334399 - Assertion failure: !mozilla::IsNaN(mValue.mFloat), at nsCSSValue.cpp:467
  • can not reproduce

Cameron McCormack

Stylo

• bug 1334735 - move mNeedStyleRefresh and mNeedLayoutRefresh flags from nsIDocument to nsIPresShell
  • r+ | land
• bug 1337656 - stylo: allow layout.css.servo.enabled to be read early on in content process life
  • r+ | land
• bug 1331294 - stylo: value from getComputedStyle is not updated after selector matching changes
  • r+ | land
• bug 1338461 - stylo: use eRestyle_StyleAttribute rather than converting it to eRestyle_Self/Subtree
  • r+
• bug 1338763 - stylo: bump restyle generation only when we do restyle things
  • r+ | land
• bug 1297899 - stylo: Share append/insert/remove restyle logic with Gecko code
  • r+
• bug 1338982 - stylo: NODE_HAS_SLOW_SELECTOR_LATER_SIBLINGS is not set correctly
  • WIP
• final mozilla-central -> incubator merge, some test greening

Stylo reviews

• bug 1335308 - stylo: Add some assertions to document our invariants and aid the static analysis
• bug 1337637 - stylo: dynamic atom leaks with non-zero refcount
• bug 1329919 - [Stylo] crash while loading cnn.com snapshot
• bug 1290218 - stylo: Cache servo stylesheets

CJ Ku

• bug 1338393 - Filter: have the coordinates in the FilterDescription be independent of the filter resolution
  • file + WIP
• bug 577824 - An HTML element attach to the DOM is not render if an SVG filter apply to it
  • WIP
• bug 1335876 - transform-box property is affecting SVG positioning attributes
  • r?
• bug 1336924 - Add more invalid test cases in property_database for shape-box and transform-box
  • file + land

Farmer Tseng

• Debug mortar crash while setting sandbox level = 2 for content process in windows
  • Comment resolve method on bug 1291539 - [Mortar] Gecko Patch
• Design doc: https://docs.google.com/a/mozilla.com/document/d/1i09UtM67XH274MtQXZc1pLQYgoTqffOxQFZ3nI2HDuw/edit?usp=sharing
  • f+ - Discuss with Bobowen, from a sandbox perspective, he doesn't have much concern.
  • f? - Send proposal to Jwatt to review
• Config printing job in Mac

Tingyu Lin

• bug 1336905 - Replace StyleShapeOutsideShapeBox by StyleGeometryBox
  • review
• bug 1336388 - [RTL] Text selection handles appear inverted under some circumstances
  • land
• bug 1326407 - Implement the rendering of basic shape inset() for CSS shape-outside
  • r?
• bug 1338443 - Convert nsAutoFloatManager::new to use UniquePtr
  • file | land

Tommy Kuo

• Study CSS Rhythmic Sizing
  • https://drafts.csswg.org/css-rhythm/
  • bug 1339311 - Implemt CSS Rhythmic Sizing
• Study Text Module Level 3
  • line-break
    • https://drafts.csswg.org/css-text/#propdef-line-break
    • bug 1011369 - Implement line-break property of CSS3 Text
  • hanging-punctuation
    • https://drafts.csswg.org/css-text/#propdef-hanging-punctuation
    • bug 1253615 - Implement hanging-punctuation from CSS Text Module Level 3

Rule of Thumb

Status code:

• OOAD: In analysis or design phase.
• WIP: working on WIP patch.
• feedback(f): feedback a patch
• feedback?(f?): WIP is ready for feedback grant.
• feedback+(f+): Get positive feedback.
• feedback-(f-): Get negative feedback.
• review(r): review a patch.
• review?(r?): patch is under review
• review+(r+): get review+ and ready to check-in
• review-(r-): get negative review feedback. Fix problems and switch back to r? again.
• land: patch check in.
• debug: Figure out the root cause of a bug/ try to repro that bug, etc...
• file: file a bug
• PTO: take personal leave
• interview(I)
• study: Spend time on domain knowledge study, such as multimedia transport technology, compress format, real-time rendering.
• presentation
  • Write a personal blog, which is relative to work, such as articles on MozTech, or what you experience in a work week.
  • WIKI/ MDN article writing.
  • If you write a technical blog or anything relative to work, it's welcome to share it on weekly report.
  • Do a presentation of technical topics