Confirmed users
729
edits
Security/ReviewTopics: Difference between revisions
m
Rearrange sections
m (Rearrange sections) |
|||
| Line 17: | Line 17: | ||
* How are transitions in/out of Private Browsing mode handled? | * How are transitions in/out of Private Browsing mode handled? | ||
* How is "Clear Recent History" handled? | * How is "Clear Recent History" handled? | ||
== Data == | == Data == | ||
| Line 49: | Line 34: | ||
* Are there build options for developers (e.g. #ifdefs, ac_add_options) | * Are there build options for developers (e.g. #ifdefs, ac_add_options) | ||
* What are its on-going maintenance requirements (e.g. Web links, perishable data files)? | * What are its on-going maintenance requirements (e.g. Web links, perishable data files)? | ||
== C and C++ == | == C and C++ == | ||
| Line 64: | Line 44: | ||
* What would make you more confident in the code's safety? | * What would make you more confident in the code's safety? | ||
* When calling scripts (or firing events), is it [http://mxr.mozilla.org/mozilla-central/source/content/base/public/nsContentUtils.h safe to run scripts]? Are you holding any raw pointers that might disappear on you? (Smaug's area of expertise) | * When calling scripts (or firing events), is it [http://mxr.mozilla.org/mozilla-central/source/content/base/public/nsContentUtils.h safe to run scripts]? Are you holding any raw pointers that might disappear on you? (Smaug's area of expertise) | ||
== Exported APIs == | |||
Please provide a table of exported interfaces (APIs, ABIs, protocols, UI, etc). | |||
Explain the significant file formats, names, syntax, and semantics. | |||
* Does it interoperate with a web service? | |||
** How will it do so (by which protocols or techniques)? | |||
* Are the externally visible interfaces documented clearly enough for a non-Mozilla developer to use them successfully? | |||
* Does it change any existing interfaces? | |||
== Module/Library interactions == | |||
* What other modules are used (REQUIRES in the makefile, interfaces)? | |||
* What third-party libraries are used (.so, .dll, source code libraries/modules, etc)? | |||
** Have these third-party sources been reviewed for security? | |||
** How will we keep up-to-date with upstream? | |||
== Relationships to other projects == | |||
Are there related projects in the community? | |||
* If so, what is the proposal's relationship to their work? Do you depend on others' work, or vice-versa? | |||
* Are you updating, copying or changing functional areas maintained by other groups? How are you coordinating and communicating with them? Do they "approve" of what you propose? | |||