canmove, Confirmed users
432
edits
(Initial archive from etherpad) |
(Archive more meeting notes.) |
||
| Line 1: | Line 1: | ||
Tracker: https://bugzilla.mozilla.org/showdependencytree.cgi?id=1244854&hide_resolved=1 | Tracker: https://bugzilla.mozilla.org/showdependencytree.cgi?id=1244854&hide_resolved=1 | ||
'''March 14''' | |||
* GIF du jour: details, details http://i.imgur.com/6OqNGeh.gifv | |||
* Status updates | |||
** Dao | |||
*** Bug 1343330 - some icons are display as encoding in print preview window | |||
**** landed | |||
*** Bug 1340115 - Cap the amount of history we import from Chrome | |||
**** uplifted | |||
*** Bug 1345716 - Dev Edition (compact dark/light) theme: solid grayscale circle appears instead of blue (i) icon in location bar for icons used by add-on | |||
**** landed | |||
*** Bug 1341048 - Remove obsolete border and background fallback styling from XUL widgets | |||
**** steady progress continues | |||
**** Bug 1345432 - Clean up XUL checkbox styling on Linux | |||
***** landed | |||
**** Bug 1347113 - Use CSS outline instead of border for XUL checkbox focus ring on Windows | |||
***** landed | |||
** Gijs | |||
*** Bookmarks stuff getting closer to landing | |||
*** Meetings about URL bar stuff from Svetlana's internship to see how best to get that shipped | |||
*** Not a lot else at this time. | |||
*** | |||
** Jared | |||
*** In progress | |||
**** 1345375 - Use the FullZoomChange event to update zoom controls | |||
***** landed but bounced due to test failure on linux, should have it relanded today | |||
**** 1346440 - [e10s] Background or text color of options in drop-down defined by web page are not respected (sometimes) | |||
***** patch up for review | |||
**** Bug 1347089 - [e10s] Background on <select> options is transparent | |||
***** should be a simple patch, will put one up today | |||
**** 1343682 - Create temporary killswitch for preference reorg | |||
***** ready to land, waiting on the reorg/search patches to get finished first | |||
**** 1319821 - Themes should allow for multiple background images in the toolbar | |||
***** work about half-way complete here, on the back burner while chasing down the above bugs | |||
*** Fixed: | |||
**** 1318830 - Clicking a zoomed in / out image resets the zoom but not the zoom level in urlbar / toolbar | |||
**** 1343570 - [e10s] <option> elements don't inherit background-color attribute from parent <select> on Mac OS X | |||
**** 1344574 - Dropdown menu list is completely unreadable due to broken style caused by patches from bug #910022 | |||
** Mike | |||
*** Theming API | |||
**** Removed DSS support | |||
**** Fixed persisting theme when opening new windows | |||
**** Handover to addons team preparation - another meeting after this one! | |||
*** Photon | |||
**** Future stuff, man. | |||
*** Findbar | |||
**** Stalled, man. Quantum is more important. | |||
*** Reviews! | |||
*** GSoC students 'getting to know each other' phase | |||
** Verdi | |||
** pdol | |||
** markus | |||
** sfoster: | |||
*** Bug 1346280 - Replace yosemiteFocusRingShadow macro with --focus-ring-box-shadow variable in OSX theme. | |||
**** I'm still seeing some glowy focus rings, who is UX contact for this stuff? | |||
***** shorlander, I guess? | |||
*** 1334642 - Synchronous flush when activating/deactivating a window | |||
**** working on a mochitest and back/forth with review of implementation | |||
*** Fixed/Landed: | |||
**** Bug 1287763 - [10.10+] update remaining OS X textbox focus styling | |||
**** Bug 1344308 - Share and extend toolkit's eslint rules in PSM | |||
** Jim (squib) | |||
*** Bug 1346671 - Enable the no-useless-concat eslint rule in toolkit/ | |||
**** Patch up, has r+ (with comments), should land today | |||
**** Figured out the `firefoxtree` HG extension and how to push to MozReview and kick off a try build | |||
**** Just need to figure out the right way to amend a commit in HG and push it to MozReview... | |||
***** [jaws] i use the `hg histedit` command along with 'edit'. If you run `hg histedit`, then you should see your list of commits, and you can change the "pick" text to "edit", which will then allow you to edit your commit. Once you are done making your changes, you run `hg histedit --continue` and it will update your commit and allow you to change your commit message | |||
***** [jaws] if you want to squash multiple commits, you can use `hg histedit`, and use the 'roll' command to "roll-up" your commits, replacing "pick" with "roll" on the changeset that you want to roll-up (choose "roll" on the lowest in the list, and the one that you choose roll will get merged with the one above it in the list) | |||
***** [squib] Ok, so it's basically `git rebase -i`. Cool! Looks like there's an `--amend` option for `hg commit` in newer versions too... | |||
**** (Only spent 3 hours tweaking my zsh config to display HG bookmarks!) | |||
***** 'hg wip' gives you a treeview of draft phase (ie things you're working on) commits and any ancestors. @ used for the current commit. Very useful to keep track of where you are, how to rebase on top of new incoming csets off m-c, etc. This also lists bookmarks, I think. If it doesn't work when you try this, ./mach mercurial-setup can create the alias for you. :-) | |||
*** Bug 1222032 - Improve copy for disambiguating login update | |||
**** Started looking at this, should have a patch ready today | |||
*** Bug 1247363 - Replace "password manager" language in the HTTP Auth prompt | |||
**** Ditto | |||
*** Bug 1322876 - "contextmenu" event has mozInputSource == MOZ_SOURCE_MOUSE even when hitting the context menu key on the keyboard | |||
**** DOM bug I found a few weeks back | |||
**** Patch up but no tests yet | |||
**** Next up: figure out how to write tests and land it! | |||
* Roundtable | |||
** hoodie count: 4 | |||
** future meeting status w/ Photon | |||
** mitigation plan for desktop onboarding funnelcake | |||
'''March 7''' | |||
* GIF du jour: http://i.imgur.com/jbJRVEV.gifv | |||
* Status updates | |||
** Dao | |||
*** Bug 1300376 - Zoom indicator (urlbar-zoom-button) is gone when moved to new window | |||
**** landed, uplifted | |||
*** Bug 1343528 - Remove --toolbarbutton-vertical-outer-padding | |||
**** landed | |||
*** Bug 1344178 - Remove obsolete outline-color rule for .customization-target outlines that are never displayed | |||
**** landed | |||
*** Bug 1344189 - Stop removing non-existent borders and backgrounds from the navigation toolbox and toolbars | |||
**** landed | |||
*** Bug 1344307 - Clean up lightweight theme footer handling | |||
**** landed | |||
** Gijs | |||
*** perfffffff (for migrating bookmarks) | |||
**** https://bugzilla.mozilla.org/show_bug.cgi?id=1344282 | |||
***** I have a local patch to batch-insert bookmarks, which is very promising | |||
**** https://bugzilla.mozilla.org/show_bug.cgi?id=1344759 | |||
***** This (updating all the consumers) takes longer... | |||
**** https://bugzilla.mozilla.org/show_bug.cgi?id=1344644 - QE filed this; opening migration dialog hangs for seconds++ if opened when Edge is running | |||
***** Not sure this affects automigration | |||
****** expect either way we're not measuring this jank right now | |||
***** I have a fix! | |||
*** History improvements landed on 54 and 53 | |||
*** Sveta's outreachy internship finished! | |||
**** https://bugzilla.mozilla.org/show_bug.cgi?id=1211726 + deps | |||
**** We now have the Alexa top 20 available on Nightly (restricted to Nightly) | |||
**** Going to talk with folks about how to get this to ship | |||
*** Revieeeewwwsss... | |||
** Jared | |||
*** Theming API | |||
**** Fixed bug 864562 to implement Lightweight Themes as CSS variables | |||
**** Fixed bug 1343921 to implement support for icons (hidden behind a pref extensions.webextensions.themes.icons) | |||
**** Going through bugs blocking enabling the Theming API on nightly | |||
*** URL bar zoom | |||
**** Going to finish working on the patch for bug 1318830 | |||
***** Bug 1318830 - Clicking a zoomed in / out image resets the zoom but not the zoom level in urlbar / toolbar | |||
*** <select> work | |||
**** Put up a patch on bug 1344574 to fix another issue with select styling | |||
*** Preferences | |||
**** Hoping to land reorg and search work this week on mozilla-central | |||
**** Will be meeting later today with one of the students who is fixing up his patches related to review feedback | |||
** Mike | |||
*** Sorry I wasn't muted just know :P | |||
*** Theming API | |||
**** Addon Manager integration landed | |||
***** working on a followup bug https://bugzilla.mozilla.org/show_bug.cgi?id=1344926 | |||
**** Will make sure the tree of filed bugs, covering the MVP in its entirety, is filed | |||
**** Will move into hand-over phase asap | |||
*** Findbar | |||
**** No progress :( | |||
*** Sessionstore | |||
**** GSOC student reaching out - sent out introduction email to all | |||
*** Photon | |||
**** Will start on that some time in the near future? :) | |||
*** Quite a bit of review action | |||
** Verdi - see Peter's update below :) | |||
** pdol | |||
*** FC 98, 99, 100 heartbeat study results: https://docs.google.com/document/d/1ZpXl3v6DXapjHmjHH4Vl5vUfRW7vfWNIdpanB21fTJY/edit#heading=h.btyua7n7nk8 | |||
*** Working with Verdi on plan for onboarding experiments and shipment plans leading into v57. | |||
*** Schalk to help us with tour while migration hang issues being resolved, but want to make sure his work is useful to move to productization | |||
** markus | |||
** Sfoster | |||
*** Some eslint bugs to get warmed up with: | |||
**** Bug 1344308 - Share and extend toolkit's eslint rules in PSM: https://bugzilla.mozilla.org/show_bug.cgi?id=1344308 | |||
**** Bug 1343945 - Fix eslint errors in browser/base/content/browser-social.js https://bugzilla.mozilla.org/show_bug.cgi?id=1343945 | |||
*** Starting to look at Bug 1287763 - [10.10+] update remaining OS X textbox focus styling - https://bugzilla.mozilla.org/show_bug.cgi?id=1287763 | |||
* Roundtable | |||
'''Feb 28''' | |||
'''GIF du jour: [oops, forgot]''' | |||
* Status updates | |||
** Dao | |||
*** back from PTO today -- nothing to report (also may be late to or miss the meeting) | |||
** Gijs | |||
*** Perf fixes for history import landed on m-c | |||
**** Uplift to beta/release denied | |||
**** Uplift to aurora still pending | |||
*** Looking at perf fixes for bookmarks next | |||
*** Outreachy location bar stuff still going strong | |||
** Jared | |||
*** Moving lwts to css variables is a bigger project than it sounds. There are lots of places that are/were setting inline styles to implement as lwt, and switching to lwt means setting those as styles in the stylesheets, which are now affected by the cascade, and content security issues with loading external files in non-system principal stylesheets. Yay! /s | |||
** Mike | |||
*** Theming API | |||
**** Addon Manager integration still ongoing | |||
**** Next up: | |||
***** Deprecating DSS | |||
***** Extending LWT with Chrome manifest properties | |||
*** Sessionstore | |||
**** GSOC applicants are requesting info | |||
*** Find toolbar | |||
**** Brad Werth is still working on platform things - most important patch is still pending review tho | |||
**** I'm working on a few small bugs whilst waiting cycles of Theming API project | |||
** Verdi - will miss today - at workweek in Toronto. | |||
*** Can/should we appeal this? https://bugzilla.mozilla.org/show_bug.cgi?id=1341097#c44 | |||
**** [dolske] probably not, RC2 is pretty late to land a significant change like this for an alaready-shipped issue. | |||
** pdol | |||
** markus | |||
* Roundtable | |||
** ~5 regressions related to zoom-controls in the urlbar, possibly 4 or 5 of them will be fixed by the patch described in https://bugzilla.mozilla.org/show_bug.cgi?id=1300376#c25 but it gets called potentially twice as necessary. Though we don't have any numbers that show it is actually hurting perf. Can we land that patch? The only pushback is related to worries about not doing this in the most efficient way, but in the meantime we are actually broken. | |||
'''Feb 21''' | |||
* GIF du jour: typing http://i.imgur.com/fzdSvua.gifv vs typing http://i.imgur.com/VVrTReq.gif | |||
* Status updates | |||
** markus | |||
*** Design Systems Survey Results (carryover from last week) https://docs.google.com/a/mozilla.com/presentation/d/1lFSmzDDhucN3LS9zn3_Xzz3iN15IEIswJ2E1nz_C_hs/edit | |||
** Dao | |||
*** back on PTO this week -- actually moving now | |||
*** Bug 1338522 - Add telemetry for UI responsiveness during migration of profile data from another browser | |||
**** landed | |||
*** Bug 1339413 - Cap the amount of history we import from Chrome for the next onboarding funnelcake | |||
**** landed, uplifted | |||
*** Bug 1340115 - Cap the amount of history we import from Chrome | |||
**** landed | |||
*** Bug 1336434 - "Your Top Sites" should say "Top Sites" when we're using the default set | |||
**** landed, uplifted | |||
*** Bug 1340173 - Hover feedback for zoom reset button is too tall | |||
**** landed, uplifted | |||
*** Bug 1340436 - [Linux] Clicking on zoom buttons positioned in Toolbar makes it move a few pixels to the left | |||
**** landed | |||
*** Bug 1340495 - Remove fallback styling from toolbarbutton.css | |||
**** landed | |||
*** Bug 1340626 - Remove fallback styling from dropmarker.css. | |||
**** landed | |||
** Gijs | |||
*** https://bugzilla.mozilla.org/show_bug.cgi?id=1341097 | |||
**** hangs when importing history from chrome | |||
**** This took 80-90% of my last week | |||
***** basically, our tools for detecting/profiling UI starvation are not great | |||
**** patches are up, try looks... a bit meh, probably need to fix some jetpack and other test issues ( https://treeherder.mozilla.org/#/jobs?repo=try&revision=9d516f443183&selectedJob=79103182 ) | |||
***** hoping to get this landed in m-c this week | |||
***** unclear whether we'll be able to uplift all/part of it | |||
**** "are we doing anything about bookmarks hanging?" next step / followup | |||
***** data (https://bugzilla.mozilla.org/show_bug.cgi?id=1332225#c14) shows similarly bad times for bookmarks as history | |||
*** Outreachy! | |||
**** Svetlana landed initial versions of patches to improve initial experience of the awesomebar | |||
***** https://bugzilla.mozilla.org/show_bug.cgi?id=1211726 | |||
***** And a followup to store these in a file: | |||
****** https://bugzilla.mozilla.org/show_bug.cgi?id=1336946 | |||
**** This is currently limited to the nightly channel | |||
**** We have 2 other remaining followups: | |||
***** https://bugzilla.mozilla.org/show_bug.cgi?id=1340108 - handling 'www.' prefix correctly (not as trivial as it sounds...) | |||
***** https://bugzilla.mozilla.org/show_bug.cgi?id=1341081 - need to de-duplicate the items we suggest correctly (internal unifiedcomplete mechanics work in interesting ways) | |||
****** already has a patch, might want a test | |||
**** Need to work out how to create a realistic set of prefilled sites to provide to users to have useful autocomplete options | |||
***** If you think there are people who need to be involved in this please let me know. | |||
**** Marco filed a bug on what we need to make this ride the train | |||
***** https://bugzilla.mozilla.org/show_bug.cgi?id=1340663 | |||
** Jared | |||
*** Theming | |||
**** Got r+ on CSS variables for lightweight themes on tabs, have a follow-up patch to remove browser-lightweighttheme.css and will land once that gets r+ | |||
**** Need to take a look at how the other lwtheme properties are set and move those to CSS variables | |||
**** Will next start working on support for other properties of new Themes that will be using CSS variables | |||
*** Preferences | |||
**** Students now have specs for search and reorg | |||
**** Demo video of the two together is at https://youtu.be/QFZxR6gCGZc | |||
**** Will start working with the students this week about getting the search patches ready to land | |||
***** Filed bug 1340643 about some xul items not having a descendant textNode that includes the visible text, meaning that we won't be able to highlight the matching text there | |||
**** The reorg patches will wait until the start of 55 to land, but we can start getting those ready too now. They need to go through the preferences and manually test links and buttons, then write tests to cover the links and buttons that were broken by the reorg. | |||
** Mike | |||
*** Theming API | |||
**** Writing unit tests for Addon Manager integration | |||
*** Work on frequent intermittents (findbar) | |||
*** Reviews | |||
** Verdi- Test Day - (last minute - sorry!!) | |||
*** Prep: Today 12:30 - 1 PDT | |||
*** Test day: Tomorrow 8am - Noon PDT | |||
*** We're testing this new copy and interaction for automigration https://dl.dropboxusercontent.com/u/105549/aitng3.framer/index.html | |||
** pdol | |||
* Roundtable | |||
** | |||
'''Feb 14''' | |||
* GIF du jour: 2-for-1 http://i.imgur.com/MFyN6aM.gifv | |||
* Status updates | |||
** Dao | |||
*** Bug 1338522 - Add telemetry for responsiveness during auto migration of profile data from another browser | |||
*** Bug 1338812 - Call TelemetryStopwatch only once per item (history / bookmarks / logins) rather than for each resource. | |||
** Gijs | |||
*** Working on fixing the hangs when importing data | |||
*** Updating notification bar messaging ( https://bugzilla.mozilla.org/show_bug.cgi?id=1335349 ) | |||
**** landed, need to write a branch patch, which is slightly tricky. | |||
*** Tour bar on new tab page | |||
**** on hold because of the hanging | |||
*** Finally managed to nail down an annoying regression caused by some docshell work by :ckerschb that broke some links, which we could fix by code removal which of course promptly caused completely unrelated tests to fail. | |||
**** https://bugzilla.mozilla.org/show_bug.cgi?id=1332595 | |||
*** Reviews | |||
*** Slooowly got going on deps of https://bugzilla.mozilla.org/show_bug.cgi?id=1320124 | |||
**** Now on hold again | |||
** Jared | |||
*** Preferences search and reorg made a lot of progress this weekend: | |||
**** video of search: https://youtu.be/7dVcj2PoubY | |||
**** screenshots or reorg: http://imgur.com/a/isaVq | |||
** Mike | |||
*** Firefox Theming | |||
**** Working on Addon Manager integration all the way in one go | |||
***** Going well, expecting patches and second review cycle this week, hopefully landable next week | |||
***** Plenty of discussions, architecture reviews and coordination | |||
*** Findbar | |||
**** Paused, pending platform fixes, | |||
**** Ehsan filed perf issue, plenty of discussion and progress there | |||
***** Will work on it in-between Theming API work | |||
*** Some work on fixing frequent intermittents | |||
*** Reviews | |||
** Verdi | |||
** pdol | |||
*** Hang discussions | |||
*** Discussions with Activity Stream to determine home for onboarding tour | |||
*** New user engagement queries | |||
**** Hoping to ultimately get to dashboards comparing more granular usage than retention in the first x weeks of usage (eg. pageviews, active session hours, searches, etc.) | |||
*** Welcome Nicole Yee | |||
**** EPM helping with onboarding coordination, schedule | |||
** markus | |||
*** Design Systems Survey Results | |||
* Roundtable | |||
** | |||
'''Feb 7''' | |||
* GIF du jour: gold is best*ouch* https://gfycat.com/AdeptFamousAustraliankestrel | |||
* Status updates | |||
** Dao | |||
*** PTO | |||
*** Bug 1335451 - Improve the look of tiles for which we don't have a favicon | |||
**** landed, uplifted | |||
*** Bug 1336072 - [compact layout] Rearranging and deleting tiles are broken | |||
**** landed, uplifted | |||
*** Bug 1319513 - Disabled "Clear Downloads" text is not grayed on Linux | |||
**** landed | |||
** Gijs | |||
*** Allow doing surveys from the 'undo' notification bar - https://bugzilla.mozilla.org/show_bug.cgi?id=1335349 - landed on autoland (not nightly yet) | |||
*** Update notification bar messaging - https://bugzilla.mozilla.org/show_bug.cgi?id=1335442 - waiting for review + info from verdi | |||
*** Looked at new tab tour stuff - https://bugzilla.mozilla.org/show_bug.cgi?id=1332774 - waiting for info from verdi | |||
*** Prepping another beta automigration run - https://bugzilla.mozilla.org/show_bug.cgi?id=1335709 - has r+, waiting for uplift approval | |||
*** Add telemetry for undo errors + perf - https://bugzilla.mozilla.org/show_bug.cgi?id=1333233 - landed, uplifted to 52 | |||
*** Misc: | |||
**** https://bugzilla.mozilla.org/show_bug.cgi?id=1335272 - fix about:cache regression I caused | |||
***** landing ASAP after I fix nits | |||
**** Reader mode + SHIELD add-on + file:-access-in-its-own-process reviews | |||
** Jared | |||
*** <select> work | |||
**** wrote patches to fix a few follow-ups related to <select> styling (bug 1335483, bug 1336301) | |||
**** met with QA to go over testing plan for search-in-select, and got feedback from ux on some designs | |||
**** have a few bugs to get fixed / delegated | |||
*** filed bug 1337160 about performance regressions related to webextensions, which got duped to a bug already on file, though there doesn't seem to be an easy way to track this work (multiple bugs, not all on file) | |||
*** compared to an empty webextension, having icons applied still results in a 19% tresize opt regression on win7-32, a 12.51% tp5n nonmain_startup_fileio opt regression on win7-32, a 6.18% cart opt e10s regresson on win7-32, and a 5.4% tart opt regression on win7-32 | |||
*** we see some perf regressions when comparing PNG -> SVG icons | |||
**** https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=0ba6c1655ba948e589dd1c64a94d37bf5dfde1b9&newProject=try&newRevision=4d6c65f54321ab9a735797a92c01f31f3c885bab&framework=1 | |||
** Mike | |||
*** Theming API | |||
**** Worked on a version of the Engineering Plan that will be world-viewable | |||
***** "With a little help from my friends" | |||
**** Worked a bit on addon manager integration | |||
***** https://bugzilla.mozilla.org/show_bug.cgi?id=1330349 | |||
***** Blocked on politics | |||
*** Findbar highlighter | |||
**** Worked on a few small bugs | |||
**** Will address high ranking findbar intermittent failure | |||
**** Pinged :mstange for platform bug review | |||
** Verdi - when we test automigration in beta can we do it by opening about:newtab instead of about:home on first run but don't change the home page setting? | |||
*** Gijs: that would require code changes. Once we change code, of course we can do anything (OK, I mean, not *any*thing, but...). | |||
**** Actually, clarification: we could potentially set the first run page to 'about:newtab', replacing whatever firstrun page we use, and use browser.startup.firstrunSkipsHomepage to avoid opening about:home . But then we don't show the normal first run page. I'm not sure we could show both (the normal firstrun page + about:newtab). Yes - this is what I mean. Show about:newtab and skip opening about:home. I think this should be ok for a beta test. | |||
***** Still not sure now: would it be OK that we're no longer showing the normal first run page? I think that would be ok for the period of our test in beta. <== Peter? | |||
** pdol | |||
** markus | |||
* Roundtable | |||
** | |||
'''Jan 31''' | |||
* GIF du jour: round and round http://i.imgur.com/LYzZsxu.gifv | |||
* Status updates | |||
** Dao | |||
*** on PTO most of last and this week | |||
*** Bug 1334444 - [compact layout] Add "Your Top Sites" heading | |||
**** landed, uplift requested | |||
**** question for verdi: should the heading read "Top Sites" initially when there are no history tiles? | |||
***** Yes - no history or default sites it should say "Top Sites" and when your stuff is imported it should say "Your top sites" | |||
*** Bug 1334429 - Remove fallback styling from button.css | |||
**** landed | |||
** Gijs | |||
*** Text-only updates from me today due to scheduling conflicts | |||
*** https://bugzilla.mozilla.org/show_bug.cgi?id=1333233 | |||
**** Telemetry for 'undo' stuff | |||
*** https://bugzilla.mozilla.org/show_bug.cgi?id=1335349 | |||
**** Surveying 'undo' users | |||
*** Compact theme initial list of bugs | |||
*** Reviews | |||
*** Security (regression!) bugs :-( | |||
** Jared | |||
*** landed lwtheme support for new themes | |||
*** got r+ on chrome compat properties for lwthemes, will land it today | |||
*** working on evaluating performance of icons with new themes | |||
**** new try pushes with svg icons only defined for default toolbar icons, and using png instead of svg | |||
*** preference work continues | |||
** Mike | |||
*** Theming API | |||
**** reviews | |||
**** Addon Manager integration work going well | |||
***** most work is reading into Addon Manager codebase - not terribly complex | |||
**** On and off working on finishing up Engineering Plan appendices. | |||
**** Updated wording: Extending LWT, not replacing them | |||
*** Findbar highlighting bugfixes (small) | |||
**** platform fixes stuck in review mode - will ping mstange today | |||
** Verdi - Filed a bunch of bugs blocking https://bugzilla.mozilla.org/show_bug.cgi?id=1332318 | |||
*** Gijs (who won't be at the meeting): could you please add priorities to these, either whiteboard or actual priority field, to help us decide what to work on? It likely won't be possible to fix all of them in this cycle, and I would like to avoid disappointment by us working on the 'wrong' things. :-) | |||
**** Will this work? https://docs.google.com/spreadsheets/d/1vsLukVaGEWy_0u4kuuLD8ZYEjnRzJMnwnOwZUltsFDQ/edit#gid=0 - I guess we can add this to the bugs - everyone hasn't agreed on this yet - just me taking a stab | |||
*** If you haven't seen it - check out my video about onboarding - https://mozilla.michaelverdi.com/february-2017-onboarding-test/ | |||
** pdol | |||
*** Planning an experiment with add-ons team around hypothesis that surfacing add-ons will improve retention: | |||
**** Improving discover-ability of add-ons mechanism | |||
**** Suggesting specific add-ons | |||
**** Preloading market-specific add-ons | |||
** markus | |||
* Roundtable | |||
** Rapidly testing onboarding work with users as we go along. | |||
'''Jan 24''' | |||
* GIF du jour: hold my beer http://i.imgur.com/ShLJ5za.gifv | |||
* Status updates | |||
** Dao | |||
*** Bug 1332225 - Investigate Firefox hanging while importing bookmarks/history/passwords from Google Chrome | |||
**** QA can't reproduce the problem anymore | |||
**** I'll see if I have more luck | |||
*** Bug 1306561 - Restore Defaults button is enabled and has undesired effects on a clean profile using Aurora | |||
**** backed out for failing tests on aurora | |||
**** investigating options | |||
**** AFAIK the patch was working as expected on aurora IRL but some tests don't cope and there's no obvious fix | |||
** Gijs | |||
*** Ongoing migration funnelcake investigations relating to speed / brokenness in some edgecases (cause still unknown) | |||
*** Troubleshooting and fixing merge day blockers | |||
*** Reviews | |||
*** Security bugs | |||
** Jared | |||
*** Theming API | |||
**** Patch up for review on bug 1330340 for lightweight theme support in the Theming API | |||
**** Going to pick up the icon-perf investigations for the Theming API again (I had put them on hold) | |||
*** Select dropdowns | |||
**** Got feedback from Enn about keeping the select popup from flipping while typing in the search box. Should have time to work on the patch on Thursday or Friday | |||
*** Bookmark popup | |||
**** Landed a fix for https://bugzilla.mozilla.org/show_bug.cgi?id=1327938 which is about the bookmark popup closing prematurely | |||
**** Support for "select" events is enabled for chrome code so we can use those events to see if a selection is created and not close the popup | |||
*** Preferences reorg | |||
**** Students are busy at work getting their first bugs fixed, will start assigning them reorg patches next. | |||
**** One student is working on a Telemetry probe to track how users are getting to the Preferences | |||
**** We now have data for which Preference categories are visited most. See https://mzl.la/2jQtHoU | |||
***** Are we capturing the entry point into about:preferences to see where users are coming from? (eg. if we add direct links to certain sections in places like our Privacy Policy, can we track engagement through those methods?) | |||
** Mike | |||
*** Did large sessionstore triage and bug categorization | |||
**** Will result in GSOC plan and other things during the course of this year | |||
*** Findbar highlighter is moving forward again | |||
**** Regression fixes landed | |||
**** Performance fixes landed | |||
**** Platform fixes about to landed and are looking quite good | |||
**** Hopeful for Fx54 release | |||
*** Firefox Theming | |||
**** I started on Addon Manager integration | |||
***** few unknows, so I'm exploring the code | |||
*** Looking at fixing https://bugzilla.mozilla.org/show_bug.cgi?id=1261233 intermittent | |||
*** Reviews. Duh! :-P | |||
** Stephen | |||
** Verdi - Next onboarding funnelcake! https://bugzilla.mozilla.org/show_bug.cgi?id=1332318 | |||
** pdol | |||
*** Mainly supporting @verdi | |||
*** Onboarding Q1 OKR draft: https://docs.google.com/document/d/1Gmhb0t2NS2C8glv1MwA-6099xhr--N90TzQtS6gdhrw/edit | |||
*** Asking UR to move forward with a study on the session restore (button in chrome) implementation | |||
**** Jared could likely help out, pdol to follow-up offline | |||
** markus | |||
*** reading QX bugs | |||
* Roundtable | |||
** Design Systems Survey - for designers and developers (about 3min) - https://tori90.typeform.com/to/wl2XU8 | |||
'''Jan 17''' | |||
'''No meeting due to conflict with MoCo meeting. Feel free to add notes here anyway!''' | |||
* GIF du jour: don't know what it is but i want to pet it https://media.giphy.com/media/l0CRBpcYyerszuEVi/giphy-downsized-large.gif | |||
* Status updates | |||
** Dao | |||
*** Bug 1330303 - Rearranging an existing tab tile in about:newtab is sluggish | |||
**** landed, uplifted to fix this funnelcake-related regression | |||
*** Bug 1330611 - [compact layout] icons look vertically misaligned in alternative default tiles | |||
**** landed, uplifted for funnelcake | |||
*** Bug 1322922 - Addon doorhanger icon is black instead of grey | |||
**** landed, uplifted | |||
** Mike | |||
** Stephen | |||
** Verdi | |||
** pdol | |||
** markus | |||
* Roundtable | |||
** | |||
'''Jan 10''' | |||
* GIF du jour: almost 45 years ago http://i.imgur.com/8jionrA.gifv | |||
* Status updates | |||
** Dao | |||
*** Bug 1322737 - Do something better than showing blank squares for the initial about:newtab experience with migrated history | |||
**** last major patch in our list uplifted for beta 13 | |||
*** Bug 1329941 - [compact layout] Increase tile title background opacity to improve legibility | |||
**** landed, not yet uplifted | |||
*** Bug 1330001 - Remove browser code behind Windows XP and Vista version checks | |||
**** in review | |||
** LV QA (Grover / Justin) | |||
*** funnelcake test plan: https://docs.google.com/spreadsheets/d/1q0Z_dKADg2P9R9f5A45EjF_o1M-UKNrpiHuSGjxrnZY/edit#gid=0 | |||
** Gijs | |||
*** Migration funnelcake stuff | |||
**** Looks like it's all done | |||
*** Some regressions I've been looking at | |||
**** https://bugzilla.mozilla.org/show_bug.cgi?id=1329220 (print preview, yuck) | |||
**** https://bugzilla.mozilla.org/show_bug.cgi?id=1328410 (focus vs. popups) | |||
**** https://bugzilla.mozilla.org/show_bug.cgi?id=1328605 (docshell changes made add-ons very unhappy) | |||
*** Random other stuff: | |||
**** https://bugzilla.mozilla.org/show_bug.cgi?id=1321247 (sec-low, but it's public - form element injection in the rss reader) | |||
*** Lots of reviews | |||
**** including exciting things like: | |||
***** the web compat reporter system addon: | |||
****** https://bugzilla.mozilla.org/show_bug.cgi?id=1308271 | |||
***** Dev edition -> compact themes renaming + shipping in release | |||
****** https://bugzilla.mozilla.org/show_bug.cgi?id=1314091 | |||
***** app update UI changes! We will start using the menu button badging instead of the big ugly dialog in more cases | |||
****** https://bugzilla.mozilla.org/show_bug.cgi?id=893505 | |||
***** web storage / site data manager changes | |||
*** Mentoring on a few different bugs including outreachy | |||
*** Upcoming: | |||
**** Need to do some triage of devedition theme issues | |||
**** Talk to Matt Grimes about migration survey | |||
** Jared | |||
*** Waiting on theme blog post before starting work on theme implementation. Will start in earnest once it's posted (may start before anyways but would be polite to wait) | |||
*** Mentoring the Preferences project | |||
**** Will start ramping up quickly | |||
**** Students will be assigned to the project today | |||
**** Two other students (one a former Capstone student) are active and fixing bugs in Preferences too | |||
** Mike | |||
*** Future of Firefox Theming - Engineering Plan | |||
**** https://docs.google.com/document/d/1ueD6V7aLLTuc1GAOxxQYcwl2HR-k62HHu3q8knTJ4FU/edit?pli=1# | |||
**** Ready for review round | |||
**** Plan to file first bugs this week and start implementing them! | |||
*** Worked on Findbar regressions and followup issues | |||
**** https://bugzilla.mozilla.org/show_bug.cgi?id=1302470 apparently Brad expected me to work on this, whereas I understood he would. | |||
***** Enter game of ping-pong | |||
** Stephen | |||
** Verdi - Getting started on next bunch of onboarding stuff this week. What does that include? Good question. At least the "things to try" bar. Need to figure it out with pdol and make a proposal. | |||
** pdol | |||
** markus | |||
* Roundtable | |||
'''Jan 3 (2017)''' | |||
* GIF du jour: | |||
* Status updates | |||
** Dao | |||
*** no audio | |||
*** Bug 1322738 - Update about:newtab tile shapes / organization to match activity stream | |||
**** needs review, not sure if adw is available, may switch to Gijs | |||
** Gijs | |||
*** Back from PTO | |||
*** Asked for uplift on funnelcake patches | |||
*** Still waiting for dolske's r+ on bug 1322730 | |||
*** Also waiting on info from the new tab team in bug https://bugzilla.mozilla.org/show_bug.cgi?id=1322731 to figure out impact on metrics / if we need our own metrics | |||
*** https://bugzilla.mozilla.org/show_bug.cgi?id=1322737 is the only remaining non-taken bug right now for the funnelcake. | |||
*** wading through bugmail + review backlog | |||
** Jared | |||
*** got review on bug 1323618 to add more capabilities for turning off pseudo classes, need to figure out a test failure there before that can land | |||
*** mentored multiple changes to the preferences as part of the 2017 redesign project (lacking a better name): https://bugzilla.mozilla.org/show_bug.cgi?id=1324168 | |||
**** a telemetry probe landed too, using the new hotness of 'categorical' probes, except... they aren't displayed on t.m.o yet (bug 1316031) | |||
*** investigating a memory leak due to object-shorthand change (bug 1326305) | |||
*** will be starting on theme work this week | |||
** Mike | |||
*** Working on findbar stuff before Theming API work kicks off again | |||
*** Creating Official(tm) Engineering Plan for Theming API | |||
*** Session store coordination planned for this week | |||
**** Basically I need to file a bunch of bugs! | |||
** Stephen | |||
** Verdi - | |||
*** This seems legit https://bugzilla.mozilla.org/show_bug.cgi?id=1326712 | |||
*** How do I review - https://bugzilla.mozilla.org/show_bug.cgi?id=1235547 | |||
** pdol | |||
** markus | |||
*** theming ux? | |||
* Roundtable | |||
'''Dec 27 (2016)''' | |||
* No meeting! Ho ho ho! | |||
** but you still get a gif! http://i.imgur.com/AFJp1D5.gifv | |||
'''Dec 20''' | |||
* GIFs du jour: 🎄 [leave your favorite xmas gif under the tree!] | |||
** http://i.imgur.com/dNkX4QH.gifv | |||
** https://31.media.tumblr.com/09d6b7acbfc4aff259c0f091c4172f18/tumblr_nh3a8oaeiL1rb5w2mo1_400.gif | |||
** https://gifspace.net/image/YfcI.gif | |||
** https://chelseareil.files.wordpress.com/2013/02/anigif_enhanced-buzz-29585-1359754656-5.gif | |||
* Status updates | |||
** Dao | |||
** Gijs | |||
*** Onboarding for 51: | |||
**** Better undo (with an undo state file) ready to land (after mtg) \o/ | |||
***** https://bugzilla.mozilla.org/show_bug.cgi?id=1285577 | |||
**** Main meta: | |||
***** https://bugzilla.mozilla.org/show_bug.cgi?id=1322718 | |||
***** Fixed: | |||
****** https://bugzilla.mozilla.org/show_bug.cgi?id=1322719 (replace default homepage work) | |||
****** https://bugzilla.mozilla.org/show_bug.cgi?id=1322720 (avoid showing about:home/about:newtab on first startup) | |||
****** https://bugzilla.mozilla.org/show_bug.cgi?id=1322726 (UITour API to show about:newtab in current tab) | |||
***** Patched (waiting for review) | |||
****** https://bugzilla.mozilla.org/show_bug.cgi?id=1322730 (display migration notification on about:newtab) | |||
******* waiting for r?dolske | |||
***** Looking at | |||
****** https://bugzilla.mozilla.org/show_bug.cgi?id=1322731 (change default tiles) | |||
******* waiting for ni?dolske | |||
*** Automigration now turned off on 51 beta at the request of QE (who are testing manual migration stuff) | |||
**** I expect this will also help with some of the uplift stuff for the funnelcake as it now won't affect anything but the funnelcake | |||
*** Slowly working towards reducing our security exposure through chrome-privileged pages/frames we load in various places | |||
**** Taking a backseat at the moment in the face of all the 51-onboarding stuff | |||
**** Previously, previously: | |||
***** https://bugzilla.mozilla.org/show_bug.cgi?id=1322414 | |||
***** https://bugzilla.mozilla.org/show_bug.cgi?id=1322609 | |||
*** Misc other stuff | |||
**** Some security bugs | |||
**** Some regressions I caused or reviewed: | |||
***** https://bugzilla.mozilla.org/show_bug.cgi?id=1322701 | |||
***** https://bugzilla.mozilla.org/show_bug.cgi?id=1320502 | |||
***** https://bugzilla.mozilla.org/show_bug.cgi?id=1318664 | |||
***** https://bugzilla.mozilla.org/show_bug.cgi?id=1316863 | |||
**** Some fun other things: | |||
***** https://bugzilla.mozilla.org/show_bug.cgi?id=1122124 - we'll keep custom/non-"default" profile names if you use Firefox refresh | |||
***** https://bugzilla.mozilla.org/show_bug.cgi?id=1044586 - using page refresh (F5/accel-r) used to break about:preferences and maybe other things :-\ | |||
*** On PTO end of week until Jan 3. | |||
** Jared | |||
*** Preferences refresh 2017 | |||
**** This will be a student/volunteer driven project | |||
**** Met with Tina from UX while in Hawaii, she and her team have completed user research as well as user tested various designs and organizations | |||
**** She has some specs for a reorg and some inconsistencies [see attachments of bug 1324168] | |||
**** I have filed the first set of telemetry and inconsistency bugs blocking bug 1324168 [https://bugzilla.mozilla.org/show_bug.cgi?id=1324168] | |||
***** I have put up a patch for the first telemetry probes since we'll want to get those uplifted as high as possible to help verify the user tests once we change the organization: see https://bugzilla.mozilla.org/show_bug.cgi?id=1324167 | |||
**** More will be filed once these get moving | |||
**** Students working on the project so far: Jalen Adams [LeftySolara], and possibly the students who have been working on the select dropdown | |||
***** https://bugzilla.mozilla.org/show_bug.cgi?id=1324171 | |||
*** Select dropdown | |||
**** Mike Conley just landed https://bugzilla.mozilla.org/show_bug.cgi?id=1321376 which was the last blocker to removing the non-e10s implementation of the select popup | |||
**** The other ongoing work is to enable webpages to style select dropdowns | |||
***** This is mainly complete, but there is a bug about the :checked option having the wrong colors | |||
***** I have been working on https://bugzilla.mozilla.org/show_bug.cgi?id=1323618 to introduce a new argument to inIDOMUtils.addPseudoClassLock which will allow a pseudoclass lock to be set to "off" so we can disable :checked for sampling the colors | |||
**** Fixed bug 1316404, so the e10s select dropdown will now use the correct font-family | |||
*** Video controls | |||
**** Met with Ray Lin while in Hawaii | |||
**** We fixed numerous video controls bugs | |||
***** I fixed bug 1319598 to prevent the time label from shifting around on OSX | |||
***** I fixed bug 1323767 to clean up videocontrols.xml indentation, brace usage, and use ES6 method definitions | |||
***** Ray fixed bug 1319301 about gray overlays being left on top of the video | |||
***** Ray fixed bug 1319587 to reduce the shadow around the scrubber thumb | |||
***** Ray fixed bug 1321416 to remove scrollbars from standalone video documents | |||
***** Ray fixed bug 1319569 to remove dead code from videocontrols.xml | |||
*** Add-on Manager | |||
**** Got review on a patch for bug 934205 to add a link to the Appearance tab to take users to AMO to get more themes | |||
*** Themes API | |||
**** | |||
** Mike | |||
*** Sessionstore meetup in Hawaii | |||
**** H1 2017 focus around reliability and performance | |||
**** Compression of sessionstore JSON blobs underway | |||
**** Fun amount of reviews and mentoring | |||
***** https://bugzilla.mozilla.org/show_bug.cgi?id=1306294 and https://bugzilla.mozilla.org/show_bug.cgi?id=1323987 | |||
*** Findbar | |||
**** Range visibility detection patches were backed out due to regressions | |||
**** bwerth working on that again | |||
**** I'm working on reducing the amount of other issues | |||
*** Theming API | |||
**** Large Hawaii meeting went well - product, engineering, addons, QA, AMO, UX - everyone attended | |||
**** Community outreach next on the agenda | |||
**** Working on engineering plan complete doc | |||
***** Outline complete and reviewed by Mossop, will be done by abr as well | |||
*** Will be on PTO between X-mas and new years! | |||
** Stephen | |||
*** Mostly Photon, all things Photon | |||
** Verdi - Onboarding onboarding onboarding. Also, onboarding. Will be out starting Thurs. If there is a question I can answer, ping me on irc or slack and it will buzz my phone. | |||
** pdol | |||
*** Working with @verdi and UR on getting onboarding user research and v2.0 plans in place | |||
*** Asked UR to prioritize session restore user testing | |||
*** PTO until Jan. 9th | |||
** philipp | |||
* Roundtable | |||
** Telemetry for the automigration stuff is expiring with 53: | |||
*** https://bugzilla.mozilla.org/show_bug.cgi?id=1324525 | |||
*** Will go through this in the next few days, if people have thoughts please put them in the bug. | |||
'''Dec 13''' | |||
* Preemptively canceling, since we'll all have just been in Hawaii together and won't likely have much new to discuss. | |||
'''Dec 6''' | |||
* No meeting! Hawaii! Woo! | |||
'''Nov 29''' | |||
* GIF du jour: wat https://media.giphy.com/media/3o85xsGXVuYh8lM3EQ/200.gif | |||
* Status updates | |||
** Dao | |||
*** Bug 1320049 - Checkbox looks inconsistent (10 px too wide) in "Insecure Connection" warning, | |||
**** landed | |||
*** Bug 658467 - Fade out tab label on overflow instead of ellipsis | |||
**** landed & bounced | |||
**** hitting a layout assertion in various mochitests, being fixed in bug 1320364 | |||
** Gijs | |||
*** Working on allowing undo of automigration despite bookmarks/sync changes | |||
**** Writing unit tests as I go along. | |||
**** Fixing this is turning out to be 'fun' because of (e.g.) how last modified times propagate | |||
***** So naively, I was hoping to have some wrappers to the bookmarks insertion being able to take care of determining last modified dates for the items. Then when you undo, you check that things haven't been modified and then you remove the items that haven't been modified. Unfortunately, if you add a bookmark to a folder, that propagates the last modified time of that bookmark to the folder. So straight after calling into a wrapper to insert a bookmark into a folder, now the folder's LM time will change, and my backup of that LM time no longer matches, meaning we'll keep the folder. | |||
****** This is fixable, it's just hairier than I expected. | |||
*** Working on a document to explain preliminary telemetry from the 51 experiment. Expect email later this week. | |||
*** Misc. sec bugs, regressions I caused, etc. | |||
*** Mentoring Evan on reader mode bugs | |||
**** some nice improvements coming for RTL users, slowly fixing some website reading issues as well | |||
** Jared | |||
*** Working on measuring the impact of SVG icons for the theming API | |||
**** attempts so far: | |||
***** using a single icon for all buttons | |||
***** using separate icons that are stored in a single sprite using the use-not-target approach | |||
**** planned attempts: | |||
***** system add-on that doesn't do anything (system addon baseline) | |||
***** lightweight theme system addon (lwtheme baseline) | |||
***** complete theme system addon (complete theme baseline) | |||
***** separate files for each icon (more true baseline for svg icons) | |||
***** separate sprite sheet for "default toolbar icons" and one for secondary icons | |||
**** comparison matrix https://docs.google.com/a/mozilla.com/spreadsheets/d/1k42sfRWCu8FYkJOmKM2derVfw2UArN_54tmdBAjfdAw/edit?usp=sharing | |||
**** only have results for "single icon for all buttons" so far, https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=7eec6e43a9665f214707e56fe970aa7df783a3f0&newProject=try&newRevision=4d6c65f54321ab9a735797a92c01f31f3c885bab&framework=1&showOnlyImportant=0 | |||
** Mike | |||
*** Worked on addressing feedback on the Firefox Theming Engineering Plan outline | |||
**** Ready for additional feedback rounds (Mossop up first) | |||
**** Will start on actual Engineering Plan this today/ tomorrow and plane for Hawaii | |||
*** Working on sessionstore frequent intermittents | |||
** Stephen | |||
** Verdi - can I answer questions about scope of onboarding work? | |||
** pdol | |||
** markus | |||
* Roundtable | |||
** find-in-page progress update? looking at the bugs blocking "shipping the feature" (bug 1291278), the last one was resolved on November 15 | |||
*** https://bugzilla.mozilla.org/buglist.cgi?bug_id=1302032%2C1281421%2C1280978%2C1279751%2C1310196%2C1304292%2C1310161%2C1279704%2C1302011%2C1196479%2C1279843%2C1312008%2C1302178%2C1305420%2C1282752%2C1290914%2C1302794%2C1302551%2C1302244%2C1279802%2C1300824%2C1316516%2C1311839%2C1280354%2C1302386%2C1304313%2C1302018%2C1301941%2C1248148%2C1279683%2C1304893%2C1283042%2C1282070%2C1279708%2C1295759%2C1283041%2C1302033%2C1306599%2C1308728%2C1311320%2C1231193%2C1280534%2C1316513%2C1308928%2C1302522%2C1290842%2C1298323%2C1280876%2C1316515%2C1308214%2C1281171%2C1305194%2C1302019%2C1314315%2C1302387%2C1304497%2C1302534%2C1296822%2C1310797%2C1305071%2C1294644%2C1295539%2C1305057%2C1306320%2C1308187%2C1303874%2C1304477%2C1309208%2C1279803%2C1316043%2C1317694%2C1316514%2C1307328%2C1316459%2C1302382%2C1304311%2C1231923%2C1302967%2C1311360%2C1279682%2C1302046%2C1279723%2C1306289%2C1315428%2C1302939%2C1305033%2C1279715%2C1303287%2C1309155%2C1302029%2C1242718%2C1290913%2C1304073%2C1280149%2C1279652%2C1302749%2C1303008%2C1298435%2C1295540%2C1319560%2C1305059%2C1309275%2C1054845%2C1310613%2C1302470%2C1068740%2C1291284%2C1103153%2C1303359%2C1310423%2C1279707%2C1297543%2C1279742%2C1310606%2C1302969%2C1298438%2C1300869%2C1279695%2C1294392%2C995352%2C1301953%2C1298434%2C1306234%2C1303207%2C1305020%2C1311663%2C1311742%2C1298970%2C1302170%2C1302035%2C1314080%2C1303248&list_id=13332879 | |||
'''Nov 22''' | |||
* GIF du jour: riding the train. https://i.imgur.com/xkC4p7C.gifv | |||
* Status updates | |||
** Dao | |||
*** landed: | |||
**** Bug 1317961 - Remove the browser.tabs.dontfocusfordialogs pref | |||
**** Bug 1318104 - History panel should expose keyboard shortcuts for restoring the last closed tab / window | |||
**** Bug 1318276 - Clean up CustomizableUIInternal.addShortcut | |||
*** in review: | |||
**** Bug 1318640 - Closing the captive portal tab should go back to the previously selected tab | |||
** Gijs | |||
*** PTO | |||
*** Fixing automigration undo vs. sync | |||
*** Investigating early telemetry from beta 51 automigration experiment | |||
**** too soon to say much. | |||
*** Misc. other bugs | |||
** Jared | |||
*** landed: | |||
**** fixes to font and padding of select dropdowns | |||
**** select dropdowns will now attach to the selected item on osx | |||
**** icon support for webextension themes landed | |||
*** Looking into gathering resources to make our SVG icon story faster (potentially restarting bug 1054016 and talking to Jet about getting more resources for fixing bug 1058040) | |||
** Mike | |||
*** Firefox Theming | |||
**** Finished dominant color extraction demo | |||
**** Spent quite a bit of time on Engineering Plan bullets | |||
***** https://docs.google.com/document/d/1C22KmfaG4DVcvnyI0b9F3y3yMR-Q6mgY1uIWYnconZs/edit# | |||
**** PRD bullet list approved (by current theme stakeholders group) | |||
***** Now slowly turning into official PRD draft 0.0.0.0.1 alpha | |||
***** https://docs.google.com/document/d/1ebB02HHc5Ni_ZyUwA41vJ9OlZsTEAMFOpXCaCqvuGTE/edit?ts=582dc369# | |||
*** Findbar | |||
**** Fixed highlighting regressions ('arni-bugs') | |||
***** uplifted up to 51 now. | |||
**** Worked a bit on modal highlighting, pushing :bwerth's work forward | |||
***** Found issues he'll need to fix... | |||
** Stephen | |||
** Verdi - A question came up today about onboarding work and iterations | |||
** pdol | |||
*** Examining/analyzing usage patterns of Firefox users | |||
**** Particularly: 1-5 day users (in a 28 day period), "heavy users" | |||
***** Results will be used as part of success criteria for a number of projects | |||
**** Strong evidence that press cycles re-engage inactive users | |||
***** Implication: "onboarding" likely needs to consider users moving from inactive > active, not just new downloads <= Verdi - I would love to address this | |||
** markus | |||
*** announcement for: engineering perspective on a Firefox UI System (in Hawaii) | |||
* Roundtable | |||
** | |||
'''Nov 15''' | |||
* GIF du jour: pair programming? http://i.imgur.com/L6ETtE2.gif | |||
* Status updates | |||
** Dao | |||
*** Bug 1315948 - Simplify openLinkIn | |||
**** landed | |||
** Gijs | |||
*** Telemetry experiment landed in time for 51b1 | |||
*** Telemetry for recency & defaultness of manual migration: | |||
**** https://telemetry.mozilla.org/new-pipeline/dist.html#!cumulative=0&end_date=2016-11-04&keys=ie!chrome!edge!safari&max_channel_version=beta%252F50&measure=FX_STARTUP_MIGRATION_USED_RECENT_BROWSER&min_channel_version=null&product=Firefox&sanitize=0&sort_keys=submissions&start_date=2016-09-20&table=0&trim=1&use_submission_date=0 | |||
***** Basically, people who import from IE or Edge are usually importing from the most recent browser (ie IE or Edge is actually the most recent), split 85-90 / 15-10. | |||
***** People who import from Chrome usually have it as *not* the most recent (65-35). | |||
**** https://sql.telemetry.mozilla.org/queries/1671/source and https://docs.google.com/spreadsheets/d/1HBmGxKfAALje-hcRYypO3pEp2lqA3y_FvsfW5pPVfFI/edit#gid=1616169466 | |||
***** 38% of people don't import anything | |||
***** For default browser X, percentage who actually imports from that browser: | |||
****** IE: 71% | |||
****** 360SE: 69% (very small sample size) | |||
****** Chrome: 61% (another 5-6% imported from IE) | |||
****** Safari: 41% | |||
****** Edge: 23% (! - another 20-odd % imported from IE) | |||
***** Potentially there are issues that we don't show the default browser (esp. Edge) if there is no data to import from, which could explain why so many Edge users choose to import from IE | |||
***** Other concern: there's a lot of people whose default browser we fail to detect | |||
****** Unsure of how to proceed. Could potentially use the executable name of the default browser as a telemetry key and get data that way. Not sure if that would pass privacy review. | |||
*** Other qx-related bugs | |||
**** https://bugzilla.mozilla.org/show_bug.cgi?id=1276705 | |||
***** rm settings importer for IE/Safari | |||
**** some rtl fixes | |||
**** some fixes to async link opening and focus (also related to bug 1315948) | |||
*** | |||
** Jared | |||
** Mike | |||
*** Range.getClientRectsAndTexts() method landed and now used | |||
**** Support for more complex text layouts possible now - also landed | |||
*** Proper range visibility checking almost ready to land - will fix plenty issues | |||
*** Regressions of old-style highlighting filed & fixed, will uplift soon | |||
**** Note: was very buggy and untested to begin with. Hrm. | |||
*** Disabled state for findbar navigation buttons implemented & landed | |||
**** Nice cleanup of behavior established | |||
*** Finished 'Extreme Theme Demo' | |||
*** Finished end-to-end demo if Chrome theme import directly into Fx | |||
*** Did a quick & dirty demo of extracting dominant colors from an image using a JS quantizer and using that for a theme | |||
*** TODO: Proof-read Theme API PRD | |||
**** https://docs.google.com/document/d/1Lb2gHDsR4bLIakHj0vaT9lF8LT02L1ViliGZf8iUX_4/ | |||
*** Working on fixing frequent intermittent browser_privatetabs.js | |||
*** Mucho reviews and mentoring wrt sessionstore | |||
*** Next: 2017 planning | |||
** Stephen | |||
** Verdi | |||
** pdol | |||
** philipp | |||
* Roundtable | |||
'''Nov 8''' | |||
* GIF du jour: spinny! http://i.imgur.com/eLNUeVR.gifv | |||
* Status updates | |||
** Dao | |||
*** Quick update, not going to try to read it out since I'm probably VoIPing again, but let me know if you have questions | |||
*** Bug 1287330 - Insert tabs' linkedBrowser lazily into the document | |||
**** helping out investigating obscure test failures to get this landed | |||
*** Bug 1308377 - Intermittent non-Win 8 browser/base/content/test/general/browser_tab_dragdrop2.js | Test timed out | |||
**** investigated this since it's become the second-most frequent orange | |||
**** disabled browser_tab_dragdrop.js again as a result | |||
** Gijs | |||
*** automigration stuff | |||
**** Patch for the 51 test up for uplift in https://bugzilla.mozilla.org/show_bug.cgi?id=1309613 | |||
**** everything else is now uplifted and ready on 51 | |||
**** sent out an email to the www.m.o folk about the startup page change, expect no issue on their side given previous comms for the 50 experiment. | |||
*** Outreachy | |||
**** Lots of administrivia email back and forth, should now hopefully be sorted | |||
*** Misc. | |||
**** reviews | |||
**** Helping Evan with reader mode things. | |||
***** Nasty perf regression in https://bugzilla.mozilla.org/show_bug.cgi?id=1315490 - looks like it might need to be backed out while we fix it. :-( | |||
**** Other reader mode improvement from a contributor: | |||
***** https://bugzilla.mozilla.org/show_bug.cgi?id=1189491 | |||
****** had a few hiccups due to test movement (sigh, I should have known better), but looks like it's now stuck | |||
**** Some RTL stuff: | |||
***** https://bugzilla.mozilla.org/show_bug.cgi?id=1315550 | |||
****** contributor patch, landed | |||
***** https://bugzilla.mozilla.org/show_bug.cgi?id=1313751 | |||
****** suggestions from a contributor, ended up fixing differently after talking to Neil. Patch now up. | |||
**** devedition theme issue: | |||
***** https://bugzilla.mozilla.org/show_bug.cgi?id=1308407 | |||
****** landed | |||
**** regression I caused with focus in the url bar | |||
***** https://bugzilla.mozilla.org/show_bug.cgi?id=1313403 | |||
****** try looks OK, going to land after the mtg | |||
**** some investigations for some on-screen keyboard issues: | |||
***** https://bugzilla.mozilla.org/show_bug.cgi?id=1233006 | |||
** Jared | |||
*** Fading the tab audio indicator on a delay now, bug 1311799 | |||
**** Landed | |||
*** worked on Theming API | |||
**** icons in the toolbar, looks really cool and easy. all widgets can get different icons, everything that fits on the navbar is customizable | |||
** Mike | |||
*** (Not present today, had an appointment early this evening) | |||
*** Theming API Demos | |||
**** Dev Edition theme support demo landed | |||
**** Current state: https://vimeo.com/190708433 | |||
*** Findbar bugs triage | |||
*** Sessionstore reviews & mentoring | |||
** Stephen | |||
** Verdi | |||
** pdol | |||
*** Stuck in PrivSec planning (to be moved going forward, soon, hopefully) | |||
** philipp | |||
** markus | |||
*** Design Systems Workweek (Emanuela, Tina, Tori, Markus) | |||
***** wiki https://wiki.mozilla.org/Firefox/QX | |||
***** QX-Tracking Bug https://bugzilla.mozilla.org/showdependencytree.cgi?id=1244854&hide_resolved=1 | |||
***** QX-Holding Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1270272 | |||
***** QX-Bug List: https://bwinton.github.io/d3Experiments/qx.html | |||
**** Any QX bugs need UX attention? We will start familiarizing ourselves with the backlog. | |||
***** bug 1219725 -> possible user testing (philipp, blake and others involved) | |||
****** https://bugzilla.mozilla.org/show_bug.cgi?id=1219725 | |||
***** onboarding bugs are covered by mverdi and sevaan | |||
***** anything is good. currently no eng capacity to work on additinal stuff, but we can help pic next clusters to focus on. | |||
* Roundtable | |||
** | |||
'''Nov 1''' | |||
* GIF du jour: 👀 http://i.imgur.com/UDFoIEy.gif | |||
* Status updates | |||
** Dao | |||
*** Bug 1164954 - Both Dev Edition and Default theme are showing up as selected in Customize mode | |||
**** landed | |||
*** helped mentoring new contributors at https://wikimedia.de/wiki/Ladies_that_FOSS | |||
**** bugs we worked on: | |||
***** Bug 1308931 - Better Fallback for Command+K when search bar has been removed from the toolbar | |||
***** Bug 1305676 - In some circumstances passive mixed content indicator will override active mixed content indicator | |||
***** Bug 1256887 - [ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_webconsole_dont_navigate_on_doubleclick.js | |||
***** Bug 1313830 - Replace @media not all and (-moz-windows-default-theme) with @media (-moz-windows-default-theme: 0) | |||
***** Bug 1299967 - Page Permissions are no longer sorted alphabetically | |||
***** Bug 1286080 - tstclnt: incorrect error message for -H flag (requireDHNamedGroups) | |||
***** Bug 1307676 - Intermittent browser/base/content/test/urlbar/browser_urlbarCopying.js | loaded expected URL - Got about:blank, expected http://example.com/ | |||
** Gijs | |||
*** Back after some PTO | |||
*** Automigration adjustments all landed on 52 | |||
**** Almost everything uplifted to 51, | |||
**** Need 1 more uplift for 51 (https://bugzilla.mozilla.org/show_bug.cgi?id=1279501 ) | |||
**** Telemetry about homepage/session restore usage is already present, but hard to read, see: | |||
***** https://bugzilla.mozilla.org/show_bug.cgi?id=1309619 | |||
***** https://bugzilla.mozilla.org/show_bug.cgi?id=1274008 | |||
***** net result is that I have to go learn spark in order to use / correlate this data with everything else, will likely take a while. | |||
*** Outreachy - made decision who to accept, need to ping Larissa about some of the finer details, another intro meeting on Wednesday in 2 weeks | |||
*** Helping Evan deal with reader mode bugs | |||
*** Misc: | |||
**** OS X download quarantining ( https://bugzilla.mozilla.org/show_bug.cgi?id=1305339 ) | |||
**** Cleaning up tab groups migration code ( https://bugzilla.mozilla.org/show_bug.cgi?id=1312406 ) | |||
**** et al. | |||
** Jared | |||
*** Back after moving and a good chunk of PTO | |||
*** Audio indicator | |||
**** Landed | |||
***** Bug 1232357 - Delay hiding the sound indicator by a few seconds after audio has stopped | |||
**** Got r+, will land shortly | |||
***** Bug 1311799 - Fade the tab audio icon when the audio has stopped but before it has been removed | |||
*** URLBar Zoom indicator | |||
**** Landed and will get uplifted to Aurora 51 | |||
***** Bug 1310882 - Urlbar zoom button in dark devedition has poor hover support | |||
**** Got r+, will land shortly | |||
***** Bug 1300376 - Zoom indicator (urlbar-zoom-button) is gone when moved to new window | |||
*** Developer Productivity | |||
**** New patch uploaded for bug 1312050 - loadAndRegisterSheet should give a helpful error message if the CSS contains an unescaped #id | |||
**** Landed bug 1312486 - Enable no-extra-boolean-cast, no-new-object, no-shadow-restricted-names, and spaced-comment rules for eslint | |||
**** Landed bug 1312436 to actually enable browser_tab_dragdrop.js in e10s debug mode | |||
*** <select> dropdown | |||
**** Landed bug 1311450 - Only show the 'touch' padding for the select dropdown when opened via touch | |||
**** Michael and Fred uploaded a new patch to bug 1300784 - Combine e10s and non-e10s implementations of the <select> dropdown | |||
**** Tyler is working on fixing the tests for bug 1309935 - Add ability to find items within select dropdown when the list has over 40 items | |||
**** beachjar is assigned to https://bugzilla.mozilla.org/show_bug.cgi?id=430745 but I haven't heard from him what the status is, shouldn't be a hard bug to fix. | |||
**** jaws - will write a blog post with an update on the select dropdown work | |||
** Mike | |||
*** Findbar modal highlighting feature gets platform engineering support! | |||
*** Worked on Theme API | |||
**** Finished & landed chrome theme support (initial) on cedar | |||
**** Worked on DevEdition theme demo some more | |||
**** Worked on Extreme demo | |||
***** ntim is working on Vivaldi theme port, https://github.com/nt1m/vivaldi-fox/tree/webextension | |||
***** https://bugzilla.mozilla.org/show_bug.cgi?id=1313325 | |||
****** Please join in! :-D | |||
*** Many reviews & mentoring ppl | |||
**** Sessionstore is a cute timesink | |||
**** But I like it ;-) | |||
** Stephen | |||
** Verdi | |||
*** Breakdown: Allow a like-new experience for returning users - https://bugzilla.mozilla.org/show_bug.cgi?id=1268708 | |||
*** Onboarding plans for q1 experiment includes doing stuff on the new tab | |||
** pdol | |||
*** 2017 Firefox topline goal: increase pageviews by 1% (through new downloads, retention and engagement) | |||
*** Examining data for infrequent FIrefox users (engagement) | |||
**** Initial query: https://sql.telemetry.mozilla.org/queries/1524/source#2725 | |||
**** Looking into impact of the profile age on the distribution - what proportion of 1/2/3 day users are new profiles vs. older? | |||
*** Will be working w/ Verdi on onboarding plans | |||
** philipp | |||
* Roundtable | |||
'''Oct 25''' | |||
* GIF du jour: *tooot* http://i.imgur.com/0oaGJMo.gifv | |||
* Status updates | |||
** Dao | |||
*** gotta run, will miss the meeting | |||
*** birthday-PTO on Thursday | |||
*** Bug 1164954 - Both Dev Edition and Default theme are showing up as selected in Customize mode | |||
**** trying to figure this out | |||
*** Bug 1311988 - Bookmarks button sub menus don't use the correct text color | |||
**** landed | |||
*** Bug 582951 - Visual indication of checkbox focus insufficient when in Windows High Contrast Mode | |||
**** landed | |||
*** Bug 1310894 - Remove tags from default Nightly bookmarks | |||
**** landed | |||
*** Bug 1309604 - The webcam favicon is very faded when the call is in a background tab | |||
**** landed, uplifted | |||
*** Bug 1304617 - [Regression] Bookmark menu context menu item order is reversed after right click a folder | |||
**** uplifted | |||
** Gijs | |||
*** [PTO] | |||
** Jared | |||
*** [PTO] | |||
** Mike | |||
*** Demo: developer edition theme experiment | |||
*** Landed LWT compat and Chrome theme compat experiments | |||
*** [K-9] dynamic theme support | |||
** Stephen | |||
** Verdi | |||
** pdol | |||
*** Working on 2017 OKRs for Firefox | |||
*** Draft: | |||
**** Grow and sustain Firefox Desktop market share by 1% (or 7.5M incremental dau) | |||
***** Increase new downloads of Firefox by 20M | |||
***** 3% improvement in retention (increase retention to x) | |||
***** 5% increase in lead users (have to figure out how to measure this and what the real metric is) | |||
** philipp | |||
** markus | |||
* Roundtable | |||
'''Oct 18''' | |||
* GIF du jour: seems wasteful. https://i.imgur.com/p1RrD2r.gifv | |||
* Status updates | |||
** Dao | |||
*** Bug 582951 - Visual indication of checkbox focus insufficient when in Windows High Contrast Mode | |||
**** in review | |||
*** Bug 1310894 - Remove tags from default Nightly bookmarks | |||
**** in review | |||
*** Bug 1309604 - The webcam favicon is very faded when the call is in a background tab | |||
**** in review | |||
*** Bug 1304617 - [Regression] Bookmark menu context menu item order is reversed after right click a folder | |||
**** landed, going to uplift | |||
** Gijs | |||
*** Tracking bug for migration work for 51: https://bugzilla.mozilla.org/show_bug.cgi?id=1309613 | |||
**** Uplifts on previously-fixed bugs done, I think | |||
**** Started work on additional telemetry | |||
*** Regression from previous telemetry work on migration: | |||
**** https://bugzilla.mozilla.org/show_bug.cgi?id=1310596 - patched & landed today (thanks mikedeboer!), already asked for uplift as it will affect 50 | |||
**** To prevent this happening again, https://bugzilla.mozilla.org/show_bug.cgi?id=1311043 (moar eslint - already found a bug) | |||
***** still need to file a followup to nuke homepage imports + settings from orbit for everywhere we currently implement that per repeated previous discussion with dolske etc. | |||
****** will ask for a+ from verdi on that | |||
*** Outreachy administrivia - new project: initial pages to use for URL bar autocomplete. | |||
**** Will need to come up with some initial contribution tasks to pick our intern (several applicants!) | |||
***** I'd welcome suggestions! | |||
*** Other stuff: | |||
**** Tried to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1308407 | |||
***** feedback from dao to structurally address the devedition dark/light mess | |||
****** which might also fix https://bugzilla.mozilla.org/show_bug.cgi?id=1310421, maybe? | |||
** Jared (on PTO Tuesday Oct 18, back on Wednesday) | |||
*** URL Bar Zoom | |||
**** Requested uplift for | |||
***** Bug 1305195 - URL bar zoom button unreadable in devedition dark-mode private browsing windows | |||
**** QA has tentatively signed off on the new feature, but there are three bugs that they would like fixed before it ships | |||
***** I investigated https://bugzilla.mozilla.org/show_bug.cgi?id=1310758 and I think it might be due to a race condition from either using getBrowser (deprecated) or some timing issue of iframes taking longer to adjust their zoom | |||
***** Gijs was investigating https://bugzilla.mozilla.org/show_bug.cgi?id=1297970 last week, not sure if he was able to make any more progress | |||
****** I made 2 suggestions on how to fix, Katie messaged me on IRC saying she was looking into them. | |||
***** The changes made in https://bugzilla.mozilla.org/show_bug.cgi?id=1298449 are invisible in dark themes ("dark mode", which I assume means dark devedition) | |||
**** Also, filed good-first-bug for https://bugzilla.mozilla.org/show_bug.cgi?id=1309260 | |||
*** <select> dropdown | |||
**** Styling changes landed for Windows to make the <select> dropdown look better there with more padding and removed hover effects for disabled options | |||
**** Patches are up on https://bugzilla.mozilla.org/show_bug.cgi?id=1309935 to allow filtering of options in <select> elements that have over 40 items | |||
**** The non-e10s -> e10s porting of the select implementation is proceeding, but the students are stuck on a failing test. They have been in contact with Neil and Felipe. | |||
** Patch up for review on https://bugzilla.mozilla.org/show_bug.cgi?id=1232357 to delay hiding the sound indicator on tabs until audio has stopped for > 3 seconds. | |||
**** This matches Chrome behavior and should make it easier to find the tab that *just* made noise but stopped right afterwards. | |||
** Mike | |||
*** Fixed very few findbar modal highlighting bugs this week | |||
**** Only fixes for edge-case scenarios | |||
**** Still waiting on platform support | |||
*** Firefox Theming | |||
**** Finished LWT compat demo | |||
**** Chrome Theme API compat demo in review | |||
**** Working on DevEdition dark theme demo | |||
*** PTO this Thursday for my b-day :o) | |||
** Stephen | |||
** Verdi | |||
** pdol | |||
** philipp | |||
* Roundtable | |||
'''Oct 11''' | |||
* GIF du jour: lunar rover? http://i.imgur.com/yyGF2Ud.gifv | |||
* Status updates | |||
** Dao | |||
*** Bug 582951 - Visual indication of checkbox focus insufficient when in Windows High Contrast Mode | |||
**** in review | |||
*** Bug 1306584 - Lightweight theme button icon and Restore Defaults button disabled state don't update when selecting a theme in customize mode | |||
**** landed | |||
*** Bug 1304708 - Use icon-colors.inc.svg in notification-icons.svg | |||
**** uplifted | |||
*** Bug 658467 - Fade out tab label on overflow instead of ellipsis | |||
**** getting new perf numbers since bug 1305259 (support subpixel AA in CSS mask) landed | |||
** Gijs | |||
*** Automatic Migrations malarkey. | |||
**** Still puzzled about bookmarks stuff | |||
***** Have some avenues to explore but skeptical at this point that we'll get everything sorted out for b50. Need to file + fix what we know + get more data | |||
**** Fixed some sync stuff and had it uplifted | |||
**** Talked with rnewman about how to deal with sync + automatic migration | |||
***** TL;DR: it's doable but it will take quite a bit of work. | |||
**** Basic plan right now: | |||
***** fix what we can about bookmarks-removing-undo-option telemetry | |||
***** add telemetry for how often we show notification bar | |||
***** add telemetry for how many items we import (so we can see if lots of the users who undo are basically not getting any value out of the import anyway) | |||
***** add telemetry for custom homepage / automatic session restore so we have a better idea about how that impacts where we're showing the 'would you like to undo this' UI. | |||
***** re-run experiment on 51 | |||
***** have a meeting (because of course we'll have a meeting!) to keep everybody in the loop and decide how best to move forward / trade off "ship now but imperfect" vs. "ship eventually when we're really really confident it's amazeballs" | |||
*** Pulled into reviewing SHIELD add-on (my own fault, really, but it's a big chunk of code). | |||
*** Also trying to help Evan Tseng with reader mode fix reviews / guidance | |||
**** Slow going because reader mode is complicated. :( | |||
*** misc other fixes | |||
** Jared | |||
*** Bug 1305195 - URL bar zoom button unreadable in devedition dark-mode private browsing windows | |||
**** landed | |||
*** Bug 1291839 - Changing narrate speed does not restart paragraph | |||
**** uplifted to beta50 along with two dependency bugs (bug 1295719, bug 1286509) | |||
*** Dug out of review barrage (request queue depth was at 24), though it is coming back quickly. | |||
**** Might be a good idea for mikedeboer to find a second reviewer for findbar changes to spread the workload as well as knowledge-share | |||
***** Volunteers? Dão? Gijs? | |||
****** Suuuuuuuure... | |||
*** Bug 1307202 - The 'theme' API should be able to set the background of about:home | |||
**** Landed | |||
** Mike | |||
*** Was the source of half of Jared's review queue :/ | |||
**** But it's shaping up quite nicely :) | |||
*** Interesting dev-platform thread started by bsmedberg - added my 2cts | |||
*** Fixed the find toolbar on Fennec | |||
*** Working on LWT compat demo on cedar branch | |||
** Stephen | |||
** Verdi | |||
** pdol | |||
*** In a User Research virtual conference today | |||
** philipp | |||
* Roundtable | |||
'''Oct 4''' | '''Oct 4''' | ||