42
edits
Firefox/Meeting/15-Nov-2022: Difference between revisions
Formatting changes to Nov 15 2022 page
(Added content for Nov 15, 2022 page) |
(Formatting changes to Nov 15 2022 page) |
||
| Line 6: | Line 6: | ||
<li><p>[mconley] Tips for growing new reviewers!</p> | <li><p>[mconley] Tips for growing new reviewers!</p> | ||
<ul> | <ul> | ||
<li | <li><p>Step 1: Find someone you’d like to grow into a reviewer and let them know your intent</p></li> | ||
<li | <li><p>Step 2: For something you’ve been assigned a review for, mark the person from Step 1 as a blocking reviewer along with yourself</p></li> | ||
<li | <li><p>Step 3: Do an initial review of the patch(es) and note down in a review what you think the person from Step 1 should look at / watch out for</p></li> | ||
<li | <li><p>Step 4: Person from Step 1 does a review</p></li> | ||
<li | <li><p>Step 5: Then you do a full review of the patch(es). Bonus points if you set up a meeting and review the patch(es) in a Zoom meeting live in front of the person from Step 1 so that they can see what you’re doing.</p></li></ul> | ||
</li></ul> | </li></ul> | ||
| Line 42: | Line 42: | ||
<li><p>'''As part of the work related to “Origin Controls “ and “Unified Extensions UI”:'''</p> | <li><p>'''As part of the work related to “Origin Controls “ and “Unified Extensions UI”:'''</p> | ||
<ul> | <ul> | ||
<li | <li><p>'''browserAction widgets have been integrated into the “Unified Extensions” panel''' (and browserAction widgets pinned on the toolbar to be auto-overflowed into the “Unified Extensions” panel): [https://bugzilla.mozilla.org/show_bug.cgi?id=1784947 ''Bug 1784947''], [https://bugzilla.mozilla.org/show_bug.cgi?id=1797155 ''Bug 1797155''], [https://bugzilla.mozilla.org/show_bug.cgi?id=1798324 ''Bug 1798324''], [https://bugzilla.mozilla.org/show_bug.cgi?id=1797548 ''Bug 1797548''], [https://bugzilla.mozilla.org/show_bug.cgi?id=1799842 ''Bug 1799842'']</p></li> | ||
<li | <li><p>'''Added origin controls attention indicator to the “Unified Extensions” button: '''[https://bugzilla.mozilla.org/show_bug.cgi?id=1793629 ''Bug 1793629''] </p></li> | ||
<li | <li><p>Others related follow-ups: [https://bugzilla.mozilla.org/show_bug.cgi?id=1799203 ''Bug 1799203''], [https://bugzilla.mozilla.org/show_bug.cgi?id=1799143 ''Bug 1799143''], [https://bugzilla.mozilla.org/show_bug.cgi?id=1798968 ''Bug 1798968''], [https://bugzilla.mozilla.org/show_bug.cgi?id=1796559 ''Bug 1796559''], [https://bugzilla.mozilla.org/show_bug.cgi?id=1799497 ''Bug 1799497''], [https://bugzilla.mozilla.org/show_bug.cgi?id=1798777 ''Bug 1798777''], [https://bugzilla.mozilla.org/show_bug.cgi?id=1796987 ''Bug 1796987''], [https://bugzilla.mozilla.org/show_bug.cgi?id=1794427 ''Bug 1794427'']</p></li> | ||
<li | <li><p>'''Thanks a lot to mconley, dao and Itiel for their help on the work needed on the Firefox Desktop frontend side of this project '''</p></li></ul> | ||
</li> | </li> | ||
<li><p>'''“applications” manifest key is fully deprecated (and not supported anymore) in Manifest Version 3 extensions, superseded by the existing “browser_specific_settings” manifest.json property - '''[https://bugzilla.mozilla.org/show_bug.cgi?id=1797050 '''''Bug 1797050''''']</p> | <li><p>'''“applications” manifest key is fully deprecated (and not supported anymore) in Manifest Version 3 extensions, superseded by the existing “browser_specific_settings” manifest.json property - '''[https://bugzilla.mozilla.org/show_bug.cgi?id=1797050 '''''Bug 1797050''''']</p> | ||
<ul> | <ul> | ||
<li | <li><p>'''Please do not use the “applications” key in manifest.json files anymore'''</p></li> | ||
<li | <li><p>[https://bugzilla.mozilla.org/show_bug.cgi?id=1797777 ''Bug 1797777''] - Tracking meta for updating all non-test extensions in tree to use “browser_specific_settings” in their manifest</p></li></ul> | ||
</li> | </li> | ||
<li><p>'''In Firefox >= 108, a simplified extension version string format is now recommended (warnings only but AMO/addons-linter will enforce this new format for Manifest Version 3 extensions) - '''[https://bugzilla.mozilla.org/show_bug.cgi?id=1793925 '''''Bug 1793925''''']</p> | <li><p>'''In Firefox >= 108, a simplified extension version string format is now recommended (warnings only but AMO/addons-linter will enforce this new format for Manifest Version 3 extensions) - '''[https://bugzilla.mozilla.org/show_bug.cgi?id=1793925 '''''Bug 1793925''''']</p> | ||
<ul> | <ul> | ||
<li | <li><p>Updated manifest.json version format documentation: [https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/version#version_format ''https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/version#version_format'']</p></li></ul> | ||
</li> | </li> | ||
<li>Fixed a regression on calling “confirm” from extension action popups (regression originally introduced in Firefox 107 from [https://bugzilla.mozilla.org/show_bug.cgi?id=1791972 ''Bug 1791972''], fix landed Firefox 108 and uplifted to 107) - [https://bugzilla.mozilla.org/show_bug.cgi?id=1796972 ''Bug 1796972'']</li> | <li>Fixed a regression on calling “confirm” from extension action popups (regression originally introduced in Firefox 107 from [https://bugzilla.mozilla.org/show_bug.cgi?id=1791972 ''Bug 1791972''], fix landed Firefox 108 and uplifted to 107) - [https://bugzilla.mozilla.org/show_bug.cgi?id=1796972 ''Bug 1796972'']</li> | ||
<li><p>Investigated and identified underlying issues of the regression reported on LastPass in Firefox Nightly 108 [https://bugzilla.mozilla.org/show_bug.cgi?id=1791415 ''Bug 1791415 - LastPass extension not working'']</p> | <li><p>Investigated and identified underlying issues of the regression reported on LastPass in Firefox Nightly 108 [https://bugzilla.mozilla.org/show_bug.cgi?id=1791415 ''Bug 1791415 - LastPass extension not working'']</p> | ||
<ul> | <ul> | ||
<li | <li><p>Turned out that the regression was triggered by the addition of the implementation for the JS Array grouping proposal ([https://bugzilla.mozilla.org/show_bug.cgi?id=1739648 ''Bug 1739648''])</p></li> | ||
<li | <li><p>Regression currently fixed by disabling the Array grouping proposal by default in Nightly ([https://bugzilla.mozilla.org/show_bug.cgi?id=1799619 ''Bug 1799619'']) </p></li></ul> | ||
</li></ul> | </li></ul> | ||
| Line 70: | Line 70: | ||
<li><p>Lifting user activation requirement on the action.openPopup API method (to align it with Chromium and Safari per agreement between browser vendors part of the W3C WebExtensions Community Group) - [https://bugzilla.mozilla.org/show_bug.cgi?id=1755763 ''Bug 1755763'']</p> | <li><p>Lifting user activation requirement on the action.openPopup API method (to align it with Chromium and Safari per agreement between browser vendors part of the W3C WebExtensions Community Group) - [https://bugzilla.mozilla.org/show_bug.cgi?id=1755763 ''Bug 1755763'']</p> | ||
<ul> | <ul> | ||
<li | <li><p>Currently limited on Nightly builds (locked behind the “extensions.openPopupWithoutUserGesture.enabled" about:config pref)</p></li> | ||
<li | <li><p>[https://bugzilla.mozilla.org/show_bug.cgi?id=1799344 ''Bug 1799344''] is tracking removing the pref and enabling the new behavior on all channels.</p></li></ul> | ||
</li> | </li> | ||
<li>Fixed an issue with browser.runtime.onStartup not being fired on event pages after the event page got suspended once - [https://bugzilla.mozilla.org/show_bug.cgi?id=1796586 ''Bug 1796586'']</li> | <li>Fixed an issue with browser.runtime.onStartup not being fired on event pages after the event page got suspended once - [https://bugzilla.mozilla.org/show_bug.cgi?id=1796586 ''Bug 1796586'']</li> | ||
| Line 83: | Line 83: | ||
<li><p>Thank you</p> | <li><p>Thank you</p> | ||
<ul> | <ul> | ||
<li | <li><p>Thanks to :luke.swiderski, DOM mutation breakpoints are correctly synchronized between Inspector and Debugger panels ([https://bugzilla.mozilla.org/show_bug.cgi?id=1581213 ''bug'']).</p></li> | ||
<li | <li><p>Thanks to :zacnomore who fixed a JSON Viewer bug, which now correctly checks key modifiers before handling a keyboard shortcut ([https://bugzilla.mozilla.org/show_bug.cgi?id=1537712 ''bug'']).</p></li> | ||
<li | <li><p>:zacnomore updated the toolbar height of the JSON Viewer to be consistent with the rest of our Toolbox UI ([https://bugzilla.mozilla.org/show_bug.cgi?id=1617474 ''bug'']).</p></li> | ||
<li | <li><p>Thanks a lot to Emilio, who fixed several UI issues around flexbox in DevTools as soon as they were reported ([https://bugzilla.mozilla.org/show_bug.cgi?id=1796746 ''bug 1''], [https://bugzilla.mozilla.org/show_bug.cgi?id=1798140 ''bug 2''], [https://bugzilla.mozilla.org/show_bug.cgi?id=1798483 ''bug 3''])</p></li></ul> | ||
</li> | </li> | ||
<li><p>Container queries</p> | <li><p>Container queries</p> | ||
<ul> | <ul> | ||
<li | <li><p>Nicolas (:nchevobbe) improved Container Queries support in the Inspector's Rule View:</p> | ||
<ul> | <ul> | ||
<li>Hover on the container's information to get more details in a tooltip ([https://bugzilla.mozilla.org/show_bug.cgi?id=1796095 ''bug'']).<br /> | <li>Hover on the container's information to get more details in a tooltip ([https://bugzilla.mozilla.org/show_bug.cgi?id=1796095 ''bug'']).<br /> | ||
| Line 96: | Line 96: | ||
<li>Click on the icon next to the name to select it in the inspector ([https://bugzilla.mozilla.org/show_bug.cgi?id=1796090 ''bug'']).</li></ul> | <li>Click on the icon next to the name to select it in the inspector ([https://bugzilla.mozilla.org/show_bug.cgi?id=1796090 ''bug'']).</li></ul> | ||
</li> | </li> | ||
<li | <li><p>Nicolas also updated the Style Editor's "Media Queries" sidebar to show all "At-rules": @container, @media and @support ([https://bugzilla.mozilla.org/show_bug.cgi?id=1788033 ''bug'']).<br /> | ||
[https://snipboard.io/xSo2IN.jpg ''https://snipboard.io/xSo2IN.jpg''] </p | [https://snipboard.io/xSo2IN.jpg ''https://snipboard.io/xSo2IN.jpg''] </p></li></ul> | ||
</li> | </li> | ||
<li><p>Improvements</p> | <li><p>Improvements</p> | ||
<ul> | <ul> | ||
<li | <li><p>Hubert (:bomsy) improved the Debugger's Pretty Print availability. The feature should now be more consistently available, and in the few cases where it really can't be provided, the icon is still visible but disabled with an explanatory tooltip ([https://bugzilla.mozilla.org/show_bug.cgi?id=1361271 ''bug'']).<br /> | ||
<br /> | <br /> | ||
[https://snipboard.io/0FQnwv.jpg ''https://snipboard.io/0FQnwv.jpg''] </p | [https://snipboard.io/0FQnwv.jpg ''https://snipboard.io/0FQnwv.jpg''] </p></li> | ||
<li | <li><p>In the Network Monitor, Hubert added a feature to copy requests in a new format: "Copy as PowerShell" ([https://bugzilla.mozilla.org/show_bug.cgi?id=1795595 ''bug''])<br /> | ||
<br /> | <br /> | ||
[https://snipboard.io/kRM8Na.jpg ''https://snipboard.io/kRM8Na.jpg''] </p | [https://snipboard.io/kRM8Na.jpg ''https://snipboard.io/kRM8Na.jpg''] </p></li></ul> | ||
</li> | </li> | ||
<li><p>Maintenance</p> | <li><p>Maintenance</p> | ||
<ul> | <ul> | ||
<li | <li><p>Alex (:ochameau) removed the devtools-source-map bundle ([https://bugzilla.mozilla.org/show_bug.cgi?id=1794693 ''bug''], [https://bugzilla.mozilla.org/show_bug.cgi?id=1794692 ''bug'']), which was manually built and checked-in by our team, and used the occasion to add performance tests for our sourcemap usage ([https://bugzilla.mozilla.org/show_bug.cgi?id=1797274 ''bug''], [https://bugzilla.mozilla.org/show_bug.cgi?id=1797690 ''bug''])</p></li> | ||
<li | <li><p>Hubert also fixed a memory leak in our sourcemap implementation ([https://bugzilla.mozilla.org/show_bug.cgi?id=1687951 ''bug'']).</p></li> | ||
<li | <li><p>Alex fixed a regression where DevTools would no longer close when Firefox was closed ([https://bugzilla.mozilla.org/show_bug.cgi?id=1797730 ''bug'']).</p></li> | ||
<li | <li><p>Julian (:jdescottes) fixed a bug where the Inspector's RuleView was blank when trying to render very long base64 URLs ([https://bugzilla.mozilla.org/show_bug.cgi?id=1414361 ''bug'']).</p></li> | ||
<li | <li><p>Julian fixed the Add New Rule feature of the Inspector, which no longer worked on websites with CSPs ([https://bugzilla.mozilla.org/show_bug.cgi?id=1798848 ''bug'']).</p></li></ul> | ||
</li></ul> | </li></ul> | ||
| Line 130: | Line 130: | ||
<li><p>ESMified status:</p> | <li><p>ESMified status:</p> | ||
<ul> | <ul> | ||
<li | <li><p>browser: 39.1%</p></li> | ||
<li | <li><p>toolkit: 29.1%</p></li> | ||
<li | <li><p>Total: 38.4% (up from 31.1%)</p></li></ul> | ||
</li> | </li> | ||
<li>#esmification on Matrix</li> | <li>#esmification on Matrix</li> | ||
| Line 142: | Line 142: | ||
<li><p>[https://bugzilla.mozilla.org/show_bug.cgi?id=1778107 ''storybook''] and [https://bugzilla.mozilla.org/show_bug.cgi?id=1778110 ''devtools''] now use mjs file extensions for module files</p> | <li><p>[https://bugzilla.mozilla.org/show_bug.cgi?id=1778107 ''storybook''] and [https://bugzilla.mozilla.org/show_bug.cgi?id=1778110 ''devtools''] now use mjs file extensions for module files</p> | ||
<ul> | <ul> | ||
<li | <li><p>Simpler for ESLint and allows to enable more rules</p></li></ul> | ||
</li> | </li> | ||
<li>[https://bugzilla.mozilla.org/show_bug.cgi?id=1799101 ''Fixed an issue''] when having storybook's node_modules installed, ./mach eslint would run forever.</li> | <li>[https://bugzilla.mozilla.org/show_bug.cgi?id=1799101 ''Fixed an issue''] when having storybook's node_modules installed, ./mach eslint would run forever.</li> | ||
| Line 157: | Line 157: | ||
<li><p>Work underway:</p> | <li><p>Work underway:</p> | ||
<ul> | <ul> | ||
<li | <li><p>[https://bugzilla.mozilla.org/show_bug.cgi?id=1795462 ''A migrator for Opera GX'']</p></li> | ||
<li | <li><p>[https://bugzilla.mozilla.org/show_bug.cgi?id=1792230 ''A migrator for DuckDuckGo'']</p></li> | ||
<li | <li><p>[https://bugzilla.mozilla.org/show_bug.cgi?id=711995 ''Importing favicons from Chrome and Chrome-based browsers'']</p></li> | ||
<li | <li><p>[https://bugzilla.mozilla.org/show_bug.cgi?id=1393332 ''Importing credit card and address autofill data from Chrome and Chrome-based browsers'']</p></li> | ||
<li | <li><p>[https://bugzilla.mozilla.org/show_bug.cgi?id=1467094 ''Explorations on how to support migration when Firefox is installed as a Snap package on Ubuntu'']</p></li></ul> | ||
</li></ul> | </li></ul> | ||
| Line 182: | Line 182: | ||
<li><p>added 2 new transforms: collapse indirect recursion, and focus category</p> | <li><p>added 2 new transforms: collapse indirect recursion, and focus category</p> | ||
<ul> | <ul> | ||
<li | <li><p>Reminder: transforms are available from the right-click menu in the call tree, flame graph or stack chart. They transform the call tree to make it simpler to read.</p></li> | ||
<li | <li><p>([https://github.com/firefox-devtools/profiler/pull/4232 ''#4232'']) Collapse indirect recursion: this removes the nodes if they end up calling the same function. For example: From A -> B -> C -> A -> D, this keeps only A -> D. Thanks [https://github.com/sim642 ''Simmo Saan'']!</p></li> | ||
<li | <li><p>([https://github.com/firefox-devtools/profiler/pull/4212 ''#4212'']) Focus category: this will keep only the nodes that belong to the same category as the currently right clicked node. Thanks [https://github.com/parttimenerd ''Johannes Bechberger'']!</p></li></ul> | ||
</li></ul> | </li></ul> | ||
* ([https://github.com/firefox-devtools/profiler/pull/4286 ''#4286'']) add an item to show all local tracks for a process, and make that double clicking on the global track in the menu also shows all its local tracks. | * ([https://github.com/firefox-devtools/profiler/pull/4286 ''#4286'']) add an item to show all local tracks for a process, and make that double clicking on the global track in the menu also shows all its local tracks. | ||
* ([https://github.com/firefox-devtools/profiler/pull/4292 ''#4292'']) show the CPU model in the profile info panel | * ([https://github.com/firefox-devtools/profiler/pull/4292 ''#4292'']) show the CPU model in the profile info panel | ||
* ([https://github.com/firefox-devtools/profiler/pull/4295 ''#4295'']) sort the extensions list in the profile info panel | * ([https://github.com/firefox-devtools/profiler/pull/4295 ''#4295'']) sort the extensions list in the profile info panel | ||
* ([https://github.com/firefox-devtools/profiler/pull/4296 ''#4296'']) fix a bug in the linux perf converter where single-letter executables wouldn't be parsed. From our contributor [https://github.com/l4l ''Kitsu'']. | * ([https://github.com/firefox-devtools/profiler/pull/4296 ''#4296'']) fix a bug in the linux perf converter where single-letter executables wouldn't be parsed. From our contributor [https://github.com/l4l ''Kitsu'']. | ||
* ([https://github.com/firefox-devtools/profiler/pull/4305 ''#4305'']) display a blue border for selected tracks | * ([https://github.com/firefox-devtools/profiler/pull/4305 ''#4305'']) display a blue border for selected tracks | ||
* ([https://github.com/firefox-devtools/profiler/pull/4193 ''#4193'']) display categories in the flame graph's tooltip -- only available for converters, not available for gecko profiles yet. The style for the graphs in the tooltip changed for everybody though. From our contributor [https://github.com/parttimenerd ''Johannes Bechberger'']. | * ([https://github.com/firefox-devtools/profiler/pull/4193 ''#4193'']) display categories in the flame graph's tooltip -- only available for converters, not available for gecko profiles yet. The style for the graphs in the tooltip changed for everybody though. From our contributor [https://github.com/parttimenerd ''Johannes Bechberger'']. | ||
* ([https://github.com/firefox-devtools/profiler/pull/4261 ''#4261'']) The sourceview is now focusable, which makes it possible to copy paste text out of it. | * ([https://github.com/firefox-devtools/profiler/pull/4261 ''#4261'']) The sourceview is now focusable, which makes it possible to copy paste text out of it. | ||
* ([https://github.com/firefox-devtools/profiler/pull/4199 ''#4199'']) When moving between panels, the sidebar categories stays open (previously the state was forgotten). Thanks [https://github.com/parttimenerd ''Johannes Bechberger'']! | * ([https://github.com/firefox-devtools/profiler/pull/4199 ''#4199'']) When moving between panels, the sidebar categories stays open (previously the state was forgotten). Thanks [https://github.com/parttimenerd ''Johannes Bechberger'']! | ||
| Line 219: | Line 205: | ||
<li><p>[https://bugzilla.mozilla.org/show_bug.cgi?id=1786324 ''mcheang finished a substantial rework on how search engines are references in SearchService''] whereby they are now referenced by a unique id rather than by name. </p> | <li><p>[https://bugzilla.mozilla.org/show_bug.cgi?id=1786324 ''mcheang finished a substantial rework on how search engines are references in SearchService''] whereby they are now referenced by a unique id rather than by name. </p> | ||
<ul> | <ul> | ||
<li | <li><p>Moving forward when trying to get an engine outside SearchService prefer[https://searchfox.org/mozilla-central/rev/219df29d0fb5d8928ae41bba4a605046de411cf0/toolkit/components/search/SearchService.sys.mjs#326-337 ][https://searchfox.org/mozilla-central/rev/219df29d0fb5d8928ae41bba4a605046de411cf0/toolkit/components/search/SearchService.sys.mjs#326-337 ''getEngineById(engineId)''] over[https://searchfox.org/mozilla-central/rev/219df29d0fb5d8928ae41bba4a605046de411cf0/toolkit/components/search/SearchService.sys.mjs#292-306 ][https://searchfox.org/mozilla-central/rev/219df29d0fb5d8928ae41bba4a605046de411cf0/toolkit/components/search/SearchService.sys.mjs#292-306 ''getEngineByName(engineName)'']''.''</p></li></ul> | ||
</li></ul> | </li></ul> | ||
| Line 227: | Line 213: | ||
<li><p>adw did refactors in Quick Suggest in preparation for upcoming future work:</p> | <li><p>adw did refactors in Quick Suggest in preparation for upcoming future work:</p> | ||
<ul> | <ul> | ||
<li | <li><p>[https://bugzilla.mozilla.org/show_bug.cgi?id=1798595 ''Moved unrelated/loosely related code from UrlbarProviderQuickSuggest and UrlbarQuickSuggest''] into QuickSuggest (The core quick suggest module that is the external initialization point), QuickSuggestRemoteSettingsClient (manages Quick Suggest remote settings data such as configuration and suggestions), and UrlbarProviderQuickSuggest (a urlbar provider which records related engagement telemetry when a result is picked).</p></li> | ||
<li | <li><p>[https://bugzilla.mozilla.org/show_bug.cgi?id=1799264 ''Create a new BaseFeature class''] to make it easier to toggle various Quick Suggest features on/off depending on Nimbus variables and preferences.</p></li></ul> | ||
</li></ul> | </li></ul> | ||
| Line 240: | Line 226: | ||
* We’re starting to identify and burn down the list of [https://bugzilla.mozilla.org/show_bug.cgi?id=1789727 ''blocking issues''] to ship the new component implementation and replace the extension implementation | * We’re starting to identify and burn down the list of [https://bugzilla.mozilla.org/show_bug.cgi?id=1789727 ''blocking issues''] to ship the new component implementation and replace the extension implementation | ||
* Check it out by flipping the `screenshots.browser.component.enabled` pref. | * Check it out by flipping the `screenshots.browser.component.enabled` pref. | ||
* We’re starting to assemble and line up ideas for next steps for Screenshots. If you are a heavy screenshots-taker - or think you would be if only Screenshots did x - please tell us about x. We’re in #fx-screenshots in matrix, or you can post to [https://connect.mozilla.org/ ''connect.mozilla.org''] or file a bug in [https://bugzilla.mozilla.org/enter_bug.cgi?product=Firefox&component=Screenshots ''bugzilla'']. | * We’re starting to assemble and line up ideas for next steps for Screenshots. If you are a heavy screenshots-taker - or think you would be if only Screenshots did x - please tell us about x. We’re in #fx-screenshots in matrix, or you can post to [https://connect.mozilla.org/ ''connect.mozilla.org''] or file a bug in [https://bugzilla.mozilla.org/enter_bug.cgi?product=Firefox&component=Screenshots ''bugzilla'']. | ||
| Line 248: | Line 233: | ||
<li><p>[standard8] Cu.reportError does not support multiple arguments like console.error does. [https://searchfox.org/mozilla-central/rev/0062309958c212504556ae21a7e3eb120c9bd093/js/xpconnect/idl/xpccomponents.idl#109-124 ''The second argument to Cu.reportError is for a stack'']. </p> | <li><p>[standard8] Cu.reportError does not support multiple arguments like console.error does. [https://searchfox.org/mozilla-central/rev/0062309958c212504556ae21a7e3eb120c9bd093/js/xpconnect/idl/xpccomponents.idl#109-124 ''The second argument to Cu.reportError is for a stack'']. </p> | ||
<ul> | <ul> | ||
<li | <li><p>Generally prefer console.error unless you know you have a specific case for reportError (if so, please let Standard8 know).</p></li> | ||
<li | <li><p>reportError doesn't report stdout unlike console.error (if devtools.console.stdout.* preference is set)</p></li> | ||
<li | <li><p>There is a bug about [https://bugzilla.mozilla.org/show_bug.cgi?id=877389 ''replacing Cu.reportError with console.error''], that Standard8 is likely to get progressed via ESLint roll-out.</p></li></ul> | ||
</li> | </li> | ||
<li>[mconley] moz-phab submit -m “Applying fixes”</li> | <li>[mconley] moz-phab submit -m “Applying fixes”</li> | ||
</ul> | </ul> | ||