Confirmed users
395
edits
Gaia/Hacking: Difference between revisions
→Contributing Code
Benfrancis (talk | contribs) |
Benfrancis (talk | contribs) |
||
| Line 122: | Line 122: | ||
To submit a patch: | To submit a patch: | ||
* Assign an un-owned Gaia bug to yourself on [https://bugzilla.mozilla.org/buglist.cgi?product=Boot2Gecko&component=Gaia&resolution=--- Bugzilla] | * Assign an un-owned Gaia bug to yourself on [https://bugzilla.mozilla.org/buglist.cgi?product=Boot2Gecko&component=Gaia&resolution=--- Bugzilla] (you'll need a Bugzilla account). | ||
* Fork Gaia on Github | * Fork [https://github.com/mozilla-b2g/gaia Gaia on Github] (you'll need a GitHub account) and clone your fork | ||
$ git clone https://github.com/USERNAME/gaia.git gaia | |||
* Develop in a branch on your fork (remembering to keep to the [https://wiki.mozilla.org/Gaia#Coding_Style Coding Style guidelines] for Gaia) | * Develop in a branch on your fork (remembering to keep to the [https://wiki.mozilla.org/Gaia#Coding_Style Coding Style guidelines] for Gaia) | ||
$ git branch BRANCHNAME | |||
$ git checkout BRANCHNAME | |||
* Commit your changes | |||
$ git add /FILE/TO/ADD | |||
$ git commit -m "COMMIT MESSAGE INCLUDING BUG NUMBER" | |||
* Push to your branch | * Push to your branch | ||
* Send a pull request | $ git push origin branchname | ||
* Send a pull request by navigating to the branch in your fork on GitHub and finding the pull request button | |||
* Paste a link to the pull request in the bug on Bugzilla | * Paste a link to the pull request in the bug on Bugzilla | ||
* Your patch will be reviewed on Github | * Your patch will be reviewed on Github (if it isn't getting reviewed try asking around on IRC or the mailing list or commenting on the bug) | ||
* To make changes in response to the code review, just push more commits to the same branch and your pull request will get updated automatically | * To make changes in response to the code review, just push more commits to the same branch and your pull request will get updated automatically | ||
$ git add /FILE/TO/ADD | |||
$ git commit -m "COMMIT MESSAGE" | |||
$ git push | |||
(ideally squash all your changes into a single commit using git rebase) | |||
* Once the reviewer is happy with your patch, they will merge it into the master branch for you | * Once the reviewer is happy with your patch, they will merge it into the master branch for you | ||
(ideally the commit message should have r=REVIEWER_NAME added to the commit message of a the squashed commit and your patch includes a passing unit test) | |||
== Contacting The Team == | == Contacting The Team == | ||