18
edits
(added tip on reviewing binary components) |
(added some canned emails) |
||
| Line 31: | Line 31: | ||
==Reviewing Addons with Binary Components== | ==Reviewing Addons with Binary Components== | ||
Unlike with addons with minified/obfuscated code, we do not request the reproduction steps, and then reproduce it. We simply review the attached files, and then run all the binary files through a virus scan on the [http://www.virustotal.com Virus Total Website]. If you are prompted, "a previous scan exists", make sure to do a new scan, as the old one probably is no longer applicable. | Unlike with addons with minified/obfuscated code, we do not request the reproduction steps, and then reproduce it. We simply review the attached files, and then run all the binary files through a virus scan on the [http://www.virustotal.com Virus Total Website]. If you are prompted, "a previous scan exists", make sure to do a new scan, as the old one probably is no longer applicable. | ||
==Canned Emails== | |||
* How to make my unlisted addon - listed? | |||
Hi, | |||
Unlisted addons are automatically approved without review, therefore we do not allow a quick way to jump to listed status. | |||
To go from unlisted to listed. You have two options: | |||
1) Change the addon id in install.rdf and create a new submission | |||
2) Keep the same addon id, but delete the listing, then email an admin to delete that id from the database, then create new listing | |||
The benefit of option 1, you can link in the "notes for reviewers" to the old listing so the reviewer can do a diff of the code. Otherwise they will do a brand new review which can take time. | |||
Here is some more information on the subject - https://developer.mozilla.org/en-US/Add-ons/Distribution | |||
Thank you | |||
* How to update users of my unlisted addon? | |||
Hi, | |||
Please see https://developer.mozilla.org/en-US/Add-ons/Install_Manifests#updateURL and https://developer.mozilla.org/en-US/docs/Extension_Versioning,_Update_and_Compatibility | |||
Thank you | |||
* No need for sources attachment | |||
Hi, | |||
This is a note. Please do not attach source files unless it is the human readable version of your minified/obfuscated/binary code. Third party libraries do not needed source attachments, you just need to provide us the URL to the location of its repository/commit/version/zip. | |||
I have removed your addon from the admin queue so it does not unnecessarily go through this extended process. | |||
Thank you | |||
* How to provide sources for minimized/obfuscated 3rd party libraries | |||
Dear Author, | |||
Please provide links to each of the minimized/obfuscated 3rd party library contained in your addon. For example if you included "jquery_slipbhover.min.js" you would link us to the exact commit, of the version you use. This commit should contain a bit exact version of the minified version in your addon, and also the human readable version. If no repository exists, then you would link us to the zip file, or etc. | |||
Another example: If you include jQuery UI custom build, you would tell me go here - http://jqueryui.com/download/ - and then you would tell me what options to use to build that. | |||
Please update this information in the "Notes for Reviewers" section (which is version specific), or in the "Whiteboard" section, and then let me know by replying to this email so I may continue. | |||
Thank you | |||
* If they threaten to ditch Firefox, you should make clear to them we aren't acting due to that comment | |||
Hi, | |||
[reply to their non-threat parts of their email] | |||
I am not very happy about the threat that you want to ask your users to switch browsers. Not because of the browser switch itself, but because you are using this as an argument to persuade me into accepting the review. The add-on review process is not guided by business decisions or number of active users, we want to make sure users are safe and look at the code to decide on this. I would appreciate if you could refrain from making such statements in the future. | |||
Thank you | |||
edits