130
edits
DevTools/Hacking: Difference between revisions
Updating the link to the code review checklist
(Moved the documentation section, and added a link to the devtools code review checklist) |
(Updating the link to the code review checklist) |
||
| Line 366: | Line 366: | ||
Once you have a patch file, add it as an attachment to the Bugzilla ticket you are working on and add the '''feedback?''' or '''review?''' flag depending on if you just want feedback and confirmation you're doing the right thing or if you think the patch is ready to land respectively. Read more about [https://developer.mozilla.org/en-US/docs/Developer_Guide/How_to_Submit_a_Patch how to submit a patch and the Bugzilla review cycle here]. | Once you have a patch file, add it as an attachment to the Bugzilla ticket you are working on and add the '''feedback?''' or '''review?''' flag depending on if you just want feedback and confirmation you're doing the right thing or if you think the patch is ready to land respectively. Read more about [https://developer.mozilla.org/en-US/docs/Developer_Guide/How_to_Submit_a_Patch how to submit a patch and the Bugzilla review cycle here]. | ||
You can also take a look at the [[DevTools Code Review Checklist]] as it contains a list of checks that your reviewer is likely to go over when reviewing your code. | You can also take a look at the [[DevTools/Code Review Checklist]] as it contains a list of checks that your reviewer is likely to go over when reviewing your code. | ||
= Coding Standards = | = Coding Standards = | ||