Confirmed users
207
edits
Add-ons/Reviewers/Admins: Difference between revisions
remove ref to old editors list, fix terminology
(→How to add an add-on to the Language Tools page: remove ref to old editors list) |
(remove ref to old editors list, fix terminology) |
||
| Line 26: | Line 26: | ||
*[https://addons.mozilla.org/firefox/collections/mozilla/featured-add-ons/ Set featured add-ons] (cycles through the Featured Extensions box on the homepage and appears when the Featured filter is applied] | *[https://addons.mozilla.org/firefox/collections/mozilla/featured-add-ons/ Set featured add-ons] (cycles through the Featured Extensions box on the homepage and appears when the Featured filter is applied] | ||
==Re-reviewing an Add-on== | |||
This section requires use of the "Admin" page. This add-on page looks easy but is very complicated. It allows you select and submit invalid choice combinations without telling you. You cannot know which ones are valid without being very familiar with the code internals. Therefore, if you are not familiar with the code or valid combinations, do not do this. Instead reach out to seniors. | |||
==Re-reviewing an | |||
This section requires use of the "Admin" page. This | |||
This is a workaround for a current bug. In order to change a review, do not go to the admin page and change the review, but go to the admin page and set it to "Awaiting Review". [https://addons.mozilla.org/en-US/admin/addon/manage/512640/ (example of Admin page)]. Then return to the review page [https://addons.mozilla.org/en-US/editors/review/octotree (example of review page)] then submit your new review. | This is a workaround for a current bug. In order to change a review, do not go to the admin page and change the review, but go to the admin page and set it to "Awaiting Review". [https://addons.mozilla.org/en-US/admin/addon/manage/512640/ (example of Admin page)]. Then return to the review page [https://addons.mozilla.org/en-US/editors/review/octotree (example of review page)] then submit your new review. | ||
| Line 37: | Line 34: | ||
When you see a .xpt in a file do not worry about it, it is just definitions. What you need to review, is the javascript in the file backing those function definitions. | When you see a .xpt in a file do not worry about it, it is just definitions. What you need to review, is the javascript in the file backing those function definitions. | ||
==Reviewing | ==Reviewing Add-ons with Binary Components== | ||
Unlike with | Unlike with add-ons with minified/obfuscated code, we do not request the reproduction steps, and then reproduce it. We simply review the attached files, and then run all the binary files through a virus scan on the [http://www.virustotal.com Virus Total Website]. If you are prompted, "a previous scan exists", make sure to do a new scan, as the old one probably is no longer applicable. | ||
==Canned Emails== | ==Canned Emails== | ||
* How to make my unlisted | * How to make my unlisted add-on - listed? | ||
Hi there, | Hi there, | ||
Unlisted | Unlisted add-ons are automatically approved without review, therefore we do not allow a quick way to jump to listed status. | ||
To go from unlisted to listed. You have two options: | To go from unlisted to listed. You have two options: | ||
1) Change the | 1) Change the add-on id in install.rdf and create a brand new listing from https://addons.mozilla.org/developers/addon/submit/agreement | ||
2) Keep the same | 2) Keep the same add-on id, but delete the listing, then email an admin (amo-admins@mozilla.org) to delete that id from the database, then create new listing | ||
The benefit of option 1, you can link in the "notes for reviewers" to the old listing so the reviewer can do a diff of the code. Otherwise they will do a brand new review which can take time. | The benefit of option 1, you can link in the "notes for reviewers" to the old listing so the reviewer can do a diff of the code. Otherwise they will do a brand new review which can take time. | ||
| Line 55: | Line 52: | ||
Thank you | Thank you | ||
* How to update users of my unlisted | * How to update users of my unlisted add-on? | ||
Hi, | Hi, | ||
Please see https://developer.mozilla.org/en-US/Add-ons/Install_Manifests#updateURL and https://developer.mozilla.org/en-US/docs/Extension_Versioning,_Update_and_Compatibility | Please see https://developer.mozilla.org/en-US/Add-ons/Install_Manifests#updateURL and https://developer.mozilla.org/en-US/docs/Extension_Versioning,_Update_and_Compatibility | ||
| Line 65: | Line 62: | ||
This is a note. Please do not attach source files unless it is the human readable version of your minified/obfuscated/binary code. Third party libraries do not needed source attachments, you just need to provide us the URL to the location of its repository/commit/version/zip. | This is a note. Please do not attach source files unless it is the human readable version of your minified/obfuscated/binary code. Third party libraries do not needed source attachments, you just need to provide us the URL to the location of its repository/commit/version/zip. | ||
I have removed your | I have removed your add-on from the admin queue so it does not unnecessarily go through this extended process. | ||
Thank you | Thank you | ||
| Line 71: | Line 68: | ||
* How to provide sources for minimized/obfuscated 3rd party libraries | * How to provide sources for minimized/obfuscated 3rd party libraries | ||
Dear Author, | Dear Author, | ||
Please provide links to each of the minimized/obfuscated 3rd party library contained in your | Please provide links to each of the minimized/obfuscated 3rd party library contained in your add-on. For example if you included "jquery_slipbhover.min.js" you would link us to the exact commit, of the version you use. This commit should contain a bit exact version of the minified version in your add-on, and also the human readable version. If no repository exists, then you would link us to the zip file, or etc. | ||
Another example: If you include jQuery UI custom build, you would tell me go here - http://jqueryui.com/download/ - and then you would tell me what options to use to build that. | Another example: If you include jQuery UI custom build, you would tell me go here - http://jqueryui.com/download/ - and then you would tell me what options to use to build that. | ||
| Line 103: | Line 100: | ||
* Unix Based - Use [https://github.com/creationix/nvm nvm] npm package | * Unix Based - Use [https://github.com/creationix/nvm nvm] npm package | ||
==Reviewing | ==Reviewing Add-on with Node/NPM Based Build Tools== | ||
# Sometimes the version of node and the version of npm make a difference. Make sure they provide that. | # Sometimes the version of node and the version of npm make a difference. Make sure they provide that. | ||
# Review the package.json, ensure that the scripts pointed too (usually on npm website or github repositories) are safe. Most are popular stuff | # Review the package.json, ensure that the scripts pointed too (usually on npm website or github repositories) are safe. Most are popular stuff | ||