1,698
edits
WebExtensions/Contribution Onramp: Difference between revisions
WebExtensions/Contribution Onramp (view source)
Revision as of 16:37, 17 October 2018
, 17 October 2018→Submitting a Patch: more info on phabricator
Caitmuenster (talk | contribs) (→Setting Up Developer Environment: removed the word "quickly" from searchfox description) |
Caitmuenster (talk | contribs) (→Submitting a Patch: more info on phabricator) |
||
| Line 83: | Line 83: | ||
** Then, use [https://moz-conduit.readthedocs.io/en/latest/arcanist-user.html these instructions] to submit the patch. Choose your mentor as the reviewer. | ** Then, use [https://moz-conduit.readthedocs.io/en/latest/arcanist-user.html these instructions] to submit the patch. Choose your mentor as the reviewer. | ||
** Note that you may go through a few iterations before your code is ready to go. | ** Note that you may go through a few iterations before your code is ready to go. | ||
* If you need to make a change to a patch that has already been submitted to Phabricator, make sure you update the existing revision so the reviewers can check the interdiff and history of changes. | |||
* When working on unrelated changes at the same time, it is useful to work on them into separate hg bookmarks (or entire separate mozilla-central clones if you are not yet feeling confident enough with how the hg bookmarks works) | |||
* When the patch is approved, add the keyword “checkin-needed” to the bug on Bugzilla. If you cannot add the keyword, please ask your mentor to add it for you. | * When the patch is approved, add the keyword “checkin-needed” to the bug on Bugzilla. If you cannot add the keyword, please ask your mentor to add it for you. | ||
* QA will verify your patch after it lands, unless your mentor has added a “qa-not-needed” keyword. | * QA will verify your patch after it lands, unless your mentor has added a “qa-not-needed” keyword. | ||
* Once your patch is accepted, you can expect to see your code in an upcoming version of Firefox! | * Once your patch is accepted, you can expect to see your code in an upcoming version of Firefox! | ||