47
edits
WebExtensions/Contribution Onramp: Difference between revisions
WebExtensions/Contribution Onramp (view source)
Revision as of 11:55, 20 February 2019
, 20 February 2019→Submitting a Patch: Explicitly mention the need to create an account, and mention moz-phab and phlay.
(Add testing tips and reference to new Try server article) |
(→Submitting a Patch: Explicitly mention the need to create an account, and mention moz-phab and phlay.) |
||
| Line 81: | Line 81: | ||
* When you are ready to have your patch reviewed, submit your patch to [https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html Phabricator]: | * When you are ready to have your patch reviewed, submit your patch to [https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html Phabricator]: | ||
** First, install the [https://phabricator.services.mozilla.com/book/phabricator/article/arcanist_quick_start/ arc tool]. | ** First, [https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html#creating-an-account create an account] and install the [https://phabricator.services.mozilla.com/book/phabricator/article/arcanist_quick_start/ arc tool]. | ||
*** If your contribution consists of multiple separate patches, then [https://github.com/mozilla-conduit/review#readme moz-phab] may be an easier way to submit all patches at once. <br>If you [https://github.com/glandium/git-cinnabar/wiki/Mozilla:-A-git-workflow-for-Gecko-development use git], then the standalone [https://github.com/mystor/phlay phlay tool] can also be used instead. | |||
** Then, use [https://moz-conduit.readthedocs.io/en/latest/arcanist-user.html these instructions] to submit the patch. Choose your mentor as the reviewer. | ** Then, use [https://moz-conduit.readthedocs.io/en/latest/arcanist-user.html these instructions] to submit the patch. Choose your mentor as the reviewer. | ||
** Note that you may go through a few iterations before your code is ready to go. | ** Note that you may go through a few iterations before your code is ready to go. | ||