68
edits
Firefox/Projects/TabCandy/Work: Difference between revisions
no edit summary
No edit summary |
|||
| Line 52: | Line 52: | ||
= Development = | = Development = | ||
There's a variety of useful info over at the [https://developer.mozilla.org/En/Developer_Guide MDC Developer Guide]. | |||
''These instructions assume you're on a Mac; please update with info for other platforms as needed.'' | ''These instructions assume you're on a Mac; please update with info for other platforms as needed.'' | ||
| Line 106: | Line 108: | ||
= Landing = | = Landing = | ||
Also see [https://developer.mozilla.org/En/Developer_Guide/How_to_Submit_a_Patch How to Submit a Patch] on MDC. | |||
# Create a bug in bugzilla describing what your patch will do/fix, or use an existing bug if appropriate | # Create a bug in bugzilla describing what your patch will do/fix, or use an existing bug if appropriate | ||
| Line 138: | Line 142: | ||
Also, don't forget to rebuild minefield with all the new code to make sure nothing's broken. Whether you do this before or after pushing is up to your sense of risk. :) | Also, don't forget to rebuild minefield with all the new code to make sure nothing's broken. Whether you do this before or after pushing is up to your sense of risk. :) | ||
= Committing to mozilla-central = | |||
Also see [https://developer.mozilla.org/en/Developer_Guide/Committing_Rules_and_Responsibilities Committing Rules and Responsibilities] on MDC. | |||
You'll need [http://www.mozilla.org/hacking/commit-access-policy/ level 3 access] and a patch that's ready to go (see the section on Landing, above). These instructions assume you're using Mercurial Queues. | |||
# Take a [http://tests.themasta.com/tinderboxpushlog/ look at the tree] to make sure the coast is clear | |||
# Check in with the sheriff on duty (you can find them on the user list for #developers on IRC) | |||
# In bugzilla, grab the URL patch you want to apply (e.g. https://bug601863.bugzilla.mozilla.org/attachment.cgi?id=480853) | |||
# In the terminal, go to your local repository and make sure you don't have any unpushed changes | |||
# '''hg qimport ''<patch url>'' && hg push''' | |||
# '''hg pull -u --rebase''' | |||
# Take care of merge conflicts if needed | |||
# Make sure the patch has the correct commit message including bug number, bug title, and reviewers. '''hg qrefresh -e''' | |||
# Make sure the patch has the correct username. '''hg qrefresh -u 'User Name <user@domain.com>'''' | |||
# '''hg qfinish -a''' | |||
# '''hg outgoing''' to make sure everything looks cool | |||
# '''hg push''' | |||
# Update the bug with a link to the change (e.g. https://hg.mozilla.org/mozilla-central/rev/beb044c602a7), and resolve it as fixed. | |||
# [https://developer.mozilla.org/en/Developer_Guide/Committing_Rules_and_Responsibilities#Watch_The_Tree Watch the tree] to make sure you didn't burn it down! | |||
= Code Documentation = | = Code Documentation = | ||