Confirmed users
250
edits
AMO:Editors/EditorGuide/AddonReviews: Difference between revisions
AMO:Editors/EditorGuide/AddonReviews (view source)
Revision as of 22:49, 27 December 2011
, 27 December 2011→Policies and Actions: Mentioning that if you know a addon needs work, and you are unsure if it is safe as it is, then do not do anything..
(→Policies and actions: revert last commit, there is a difference in local vs remote) |
(→Policies and Actions: Mentioning that if you know a addon needs work, and you are unsure if it is safe as it is, then do not do anything..) |
||
| Line 308: | Line 308: | ||
In general you should apply your judgement and try to identify code that may appear suspicious or out of place. Try to understand what everything does and how it all fits together. | In general you should apply your judgement and try to identify code that may appear suspicious or out of place. Try to understand what everything does and how it all fits together. | ||
By the end of the code review, you'll may have a series of notes that will require the add-on to be significantly rewritten. If you think that's the case, it's OK to resolve the review without proceeding to the next step. If the add-on needs work but is safe to use, it can be given a preliminary review approval without performing any testing. | By the end of the code review, you'll may have a series of notes that will require the add-on to be significantly rewritten. If you think that's the case, it's OK to resolve the review without proceeding to the next step. If the add-on needs work but is safe to use, it can be given a preliminary review approval without performing any testing. If the add-on needs work and you are not sure if it is safe to use, then leave the add-on for someone else to review, request a admin review, or ask for help in the mailing list. | ||
=== Step 4: Feature Review === | === Step 4: Feature Review === | ||