Security/Reviews/Gaia/FacebookIntegration: Difference between revisions

Security/Reviews/Gaia/FacebookIntegration (view source)

Revision as of 13:41, 20 December 2013

15 bytes added , 20 December 2013

no edit summary

Arroway

Confirmed users

152

edits

@@ Line 1: / Line 1: @@
 === App Review Details ===
 * App: Facebook Integration
-* Review Date: 6th March 2003
+* Review Date: November 22th 2013
-* Review Lead: Stefan Arentz
+* Review Lead: Stéphanie Ouillon
 * Bugs: https://bugzilla.mozilla.org/showdependencytree.cgi?id=847929&hide_resolved=0
+{bug|941199}
+* Reviewed branch: master
+* Latest commit: https://github.com/mozilla-b2g/gaia/commit/9470d15828db48a5558c63a3d9981df9e72eb624
 === Overview ===
-The Facebook integration code is primarily about integrating Facebook in the contacts application. It allows you to import Facebook contacts and after that also use Facebook features from the Contacts app.
+The Facebook integration code is primarily about integrating Facebook in the Contacts application. It allows you to import Facebook contacts and after that also use Facebook features from the Contacts app.
 Imported contacts from Facebook have lots of meta data in the Gaia contacts database: birthday, email addresses, phone numbers, addresses and profile picture.
@@ Line 27: / Line 30: @@
 (Mentioning the dialer here is relevant since all apps are really the same Communications app)
-In this case, 'connecting to facebook' really means that we ask the user to login to facebook and then connect to the custom Facebook app hosted at the Heroku URL. That will give us an OAuth token which can be used for further API calls to Facebook.
+In this case, 'connecting to facebook' really means that we ask the user to login to facebook and then connect to the custom Facebook app hosted by the partner. That will give us an OAuth token which can be used for further API calls to Facebook.
 ===Architecture===
@@ Line 40: / Line 43: @@
 The main source code is contained at:
-* https://github.com/mozilla-b2g/gaia/tree/v1-train/apps/communications/facebook/
+* https://github.com/mozilla-b2g/gaia/tree/master/apps/communications/facebook/
-* https://github.com/mozilla-b2g/gaia/tree/v1-train/apps/communications/contacts/js/fb/
+* https://github.com/mozilla-b2g/gaia/tree/master/apps/communications/contacts/js/fb/
 The following files have been looked at for this review:
-* communications/contacts/js/fb/fb_contact.js
-* communications/contacts/js/fb/fb_contact_utils.js
-* communications/contacts/js/fb/fb_data.js
-* communications/contacts/js/fb/fb_import.js
-* communications/contacts/js/fb/fb_import_init.js
-* communications/contacts/js/fb/fb_init.js
-* communications/contacts/js/fb/fb_link.js
-* communications/contacts/js/fb/fb_link_init.js
-* communications/contacts/js/fb/fb_messaging.js
-* communications/contacts/js/fb/fb_oauth.js
-* communications/contacts/js/fb/fb_query.js
-* communications/contacts/js/fb/fb_utils.js
-* communications/contacts/js/fb/friends_list.js
-* communications/facebook/js/console.js
+In communications:
-* communications/facebook/js/curtain.js
+* ./contacts/js/fb/fb_contact.js - Encapsulates the logic to obtain the data for a DB Contact
-* communications/facebook/js/fb_oauth_frame.js
+* ./contacts/js/fb/fb_contact_utils.js - Utilities to get/display contacts info
-* communications/facebook/js/fb_sync.js
+* ./contacts/js/fb/fb_data.js - Defines proxy methods for fb_data_reader
-* communications/facebook/js/fb_sync_init.js
+* ./contacts/js/fb/fb_init.js - Load contacts/config.json settings for facebook
-* communications/facebook/js/sync_worker.js
+* ./contacts/js/fb/fb_link.js - Ask a contact to be a Facebook FB and manages proposals
+* ./contacts/js/fb/fb_link_init.js
+* ./contacts/js/fb/fb_messaging.js - Post a message on the wal, send a private message
+* ./contacts/js/fb/fb_query.js - Performs FQL queries through FB APIs to get friends
+* ./contacts/js/fb/fb_utils.js
+* ./contacts/js/fb/friends_list.js - Friends list renderer
-* communications/ftu/js/fb_launcher.js
+[File:Facebook_api_access.jpg‎]
 ====Permissions====