canmove, Confirmed users
1,448
edits
AMO:Editors/EditorGuide/AddonReviews: Difference between revisions
AMO:Editors/EditorGuide/AddonReviews (view source)
Revision as of 21:57, 28 November 2011
, 28 November 2011→Possible resolutions
| Line 35: | Line 35: | ||
Clicking on any of them will open a form below it. | Clicking on any of them will open a form below it. | ||
The comments textbox is where you should write all of your review notes. There's also a canned response list below it, that contains useful reusable snippets of text for your notes. Selecting any of them will just add the text to the textbox. You can use as many as you need. Take some time to familiarize yourself with the canned response list. It can give you a good idea of the issues we frequently encounter and what we have to say about it. | The comments textbox is where you should write all of your review notes. There's also a canned response list below it, that contains useful reusable snippets of text for your notes. Selecting any of them will just add the text to the textbox. You can use as many as you need. | ||
Take some time to familiarize yourself with the canned response list. It can give you a good idea of the issues we frequently encounter and what we have to say about it. | |||
You should normally use one of the first three resolutions: | You should normally use one of the first three resolutions: | ||
*Push to Public: the version doesn't have any problems and it's OK for the public. | *Push to Public: the version doesn't have any problems and it's OK for the public. | ||
*Grant Preliminary Review: the version has problems that prevent us from making it fully public, but it | *Grant Preliminary Review: the version has problems that prevent us from making it fully public, but it is still safe to use. | ||
*Reject: the version has security issues and must be rejected. | *Reject: the version has security issues and must be rejected. | ||
The other | The other 3 are used on special situations: | ||
*Request More Information: this allows you to ask the author for information necessary to perform the review, without removing the add-on from the queue. A very common case for this is when the add-on is site-specific and the author didn't provide a test account. Since we can't be registering to every site on the web just to test, we ask authors to provide the necessary information. | *Request More Information: this allows you to ask the author for information necessary to perform the review, without removing the add-on from the queue. A very common case for this is when the add-on is site-specific and the author didn't provide a test account. Since we can't be registering to every site on the web just to test, we ask authors to provide the necessary information. | ||
*Request Super-Review: this is for very special cases where you think an admin editor should review this add-on. It can be because you think there's some malicious intent from the author; in this case you should also notify the mailing list about it. It can also be because you are aware Mozilla has received a DMCA notice about this add-on. It is critical that you do '''not''' try to resolve this issue yourself. Copyright complaints should be escalated to admins and, at most, you can point the person making the complaint to the Digital Millennium Copyright Act Notice section of our [http://www.mozilla.com/en-US/about/legal.html legal notices page] for an explanation of the protocol to follow. The add-on will remain in the queue, and in this case the comments aren't sent to the author. They're only readable from the review page. | *Request Super-Review: this is for very special cases where you think an admin editor should review this add-on. It can be because you think there's some malicious intent from the author; in this case you should also notify the mailing list about it. It can also be because you are aware Mozilla has received a DMCA notice about this add-on. It is critical that you do '''not''' try to resolve this issue yourself. Copyright complaints should be escalated to admins and, at most, you can point the person making the complaint to the Digital Millennium Copyright Act Notice section of our [http://www.mozilla.com/en-US/about/legal.html legal notices page] for an explanation of the protocol to follow. The add-on will remain in the queue, and in this case the comments aren't sent to the author. They're only readable from the review page. | ||
* Comment. This allows you to add a comment that is only readable by other editors. It can have testing information, partial notes that you had from reviewing a version that you couldn't finish, etc. | |||
While you perform your review, you should be keeping notes of everything you observed about the add-on: | While you perform your review, you should be keeping notes of everything you observed about the add-on: code validation flags, errors in the error console, bugs, areas for improvement, etc. You can either use a note-taking program, or just type your notes in the comments textbox of the review page. Changing the resolution won't clear your notes. Just make sure you selected the right resolution when you're ready to submit! | ||
The sections below include tables with the recommended action for the most common situations. If there are | The sections below include tables with the recommended action for the most common situations. If there are more than one policy problems in a review, you must take the strictest of all required actions. | ||
'''Editor Tour:''' | '''Editor Tour:''' request your admin editor to point you to an add-on to review. Don't submit your first review without their pre-approval! | ||
=== Step 1: Review Add-on Info === | === Step 1: Review Add-on Info === | ||