Confirmed users
116
edits
AMO:Editors/EditorGuide/ThemeReviews: Difference between revisions
AMO:Editors/EditorGuide/ThemeReviews (view source)
Revision as of 23:30, 4 January 2012
, 4 January 2012→Firefox Theme Tests
| Line 27: | Line 27: | ||
====Special Considerations==== | ====Special Considerations==== | ||
Windows and OS-X use different CSS rules to generate OS native scrollbars. As a result any cross OS theme either needs to target different scrollbar rules for each OS or use custom XUL scrollbars. | Windows and OS-X use different CSS rules to generate OS native scrollbars. As a result any cross OS theme either needs to target different scrollbar rules for each OS or use custom XUL scrollbars. | ||
=== Test Dialogs === | |||
As soon as Firefox has started with theme to be tested installed, open the error console and make notes about any "skin" related CSS errors. Use the add-on [https://addons.mozilla.org/en-US/firefox/addon/console%C2%B2/ Console%C2%B2] to replace the standard error console as it will allow you copy all errors at once making it easier to past those errors into review notes. It also allows you to disable content errors thus eliminating a lot of webpage related noise. Instructions assume the menubar is enabled. | |||
{| cellspacing="0" cellpadding="1" border="0" style="width: 800px; height: 393px;" | |||
|+ | |||
|- | |||
! style="border-bottom: 2px solid black" scope="col" | Dialog/Feature | |||
! style="border-bottom: 2px solid black" scope="col" | Policy on failure | |||
! style="border-bottom: 2px solid black" scope="col" | What to test | |||
|- style="vertical-align: top;" | |||
| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | View > Toolbars > Customize | |||
| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | <ol><li>Preliminary Review<li>Preliminary Review<li>Add Note</ol> | |||
| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | <ol><li>Make sure customize toolbar dialog is formatted reasonably. | |||
<li>With the "show" options set to "icons", check and uncheck "use small icons", toolbar icons needs to display properly in both states (ideally they will be different sizes). Repeat test using show "icons and text". | |||
<li>With "use small icons" checked, change "show" to "text". Make sure toolbar button height is reasonable for text only buttons and that the text is vertically aligned in middle of buttons. If it is not provide this note or something similar in the review: | |||
<blockquote>When text only toolbar buttons are selected in customize toolbars, text labels in toolbar buttons are not aligning properly. The common cause of this is style rules that reference [iconsize="small"] without excluding [mode="text"]. The solution usually is to append :not([mode="text"]) to those style rules. For instance use 'toolbar[iconsize="small"]:not([mode="text"])'. A little experimenting may be required to fully address this issue with your theme.</blockquote></ol> | |||
|- style="vertical-align: top;" | |||
| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | Check 'View > Toolbars > Bookmarks Toolbar' | |||
| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | Preliminary Review | |||
| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | Make sure toolbar is formatted reasonably. | |||
|- style="vertical-align: top;" | |||
| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | Check 'View > Toolbars > Add-on Toolbar' | |||
| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | Preliminary Review | |||
| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | Using customize toolbars, add a toolbar button to this toolbar (at the bottom of the browser window). Make sure toolbar is formatted reasonably. | |||
|- style="vertical-align: top;" | |||
| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | Check 'View > Toolbars > Tabs on Top' and uncheck 'View > Toolbars > Tabs on Top' | |||
| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | <ol><li>Preliminary Review<li>Preliminary Review</ol> | |||
| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | <ol><li>Make sure Firefox button is formatted reasonably. On Windows, with browser window maximized, make sure tabs display properly between Firefox button and right hand window control buttons.<li>Go to private browsing mode (Firefox > Start Private Browsing), and verify that Firefox button changes appearance when in private browsing mode on Windows. Exit private browsing mode, enable menu bar (check Firefox > Options/Preferences > Menu Bar) and uncheck "tabs on top".</ol> | |||
|- style="vertical-align: top;" | |||
| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | 'Edit > Find' | |||
| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | Preliminary Review | |||
| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | Make sure find toolbar is formatted reasonably. | |||
|} | |||
=== Test Pages === | === Test Pages === | ||
| Line 41: | Line 75: | ||
| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | about:addons | | style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | about:addons | ||
| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | <ol><li>Preliminary Review<li>Preliminary Review<li>Add Note</ol> | | style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | <ol><li>Preliminary Review<li>Preliminary Review<li>Add Note</ol> | ||
| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | <ol><li>Make sure | | style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | <ol><li>Make sure formatting is reasonable. Addon type tabs need distinct icons. Make sure there is a significant difference between enabled and disabled addons. It is strongly encouraged but not required that the icons of disabled addons be greyed out.<li>Pin this tab to make sure pinned tabs work correctly.<li>Assuming that this was the only tab that loaded per the instructions above, open the error console and see if there are any CSS errors/warnings.</ol> | ||
|- style="vertical-align: top;" | |- style="vertical-align: top;" | ||
| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | about:home (<FF8) | | style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | about:home (<FF8) | ||