Confirmed users
976
edits
No edit summary |
|||
| Line 55: | Line 55: | ||
* Once your patch has landed on master or 1.4 branch, set request approval-gaia-1.3: ? on patch attachment and fill in the approval request comment | * Once your patch has landed on master or 1.4 branch, set request approval-gaia-1.3: ? on patch attachment and fill in the approval request comment | ||
= Guidelines on approval comments = | |||
* [Bug caused by] (feature/regressing bug #): If you this is a fallout from a feature/bug, or a backout please state the reason along with the bug number | * [Bug caused by] (feature/regressing bug #): If you this is a fallout from a feature/bug, or a backout please state the reason along with the bug number | ||
* [User impact] if declined: In addition to the STR reported in the bug if you can explain on a deeper level aspect of how an end user would be impacted with/without your change | * [User impact] if declined: In addition to the STR reported in the bug if you can explain on a deeper level aspect of how an end user would be impacted with/without your change | ||