Calendar:QA Chat:2007-06-21:Log
From MozillaWiki
mschroeder: We lost our win32 branch tinderboxen yesterday... strange [10:57am] ctalbert: mschroeder: Oh no. It hasn't come back? [10:57am] • ctalbert stares at tinderbox. [10:58am] mschroeder: ctalbert: no. [10:58am] ctalbert: That is weird [10:58am] Fallen: perfect timing [10:58am] ctalbert: heh [10:58am] ctalbert: we still have one on trunk [10:59am] mschroeder: I think it dropped when Sunbird building didn't come to an end. [11:00am] ctalbert: It hit an infinite loop? I've seen cygwin do that before on some machines I had at Simdesk. [11:00am] ctalbert: Never figured out why, though. [11:02am] You were promoted to operator by ChanServ. [11:03am] mschroeder was promoted to operator by ChanServ. [11:03am] Fallen was promoted to operator by ChanServ. [11:04am] mschroeder: wow... the checkin after 0.5 queue is steadily increasing. The Sun guys have done some reviews today. [11:04am] Fallen: yeah mickey cleared his review queue [11:04am] ctalbert: I need to go on and clear mine too. I think Sebo's been waiting on a reivew for 2 months [11:08am] Fallen: btw, I do reviews now too [11:09am] mschroeder: jminta has three reviews left [11:09am] ctalbert: I remember. But, I only have three or so in my queue. I was just trying to get 0.5 out the door before having to mess with my build trees, but it doesn't look like that is going to be feasible. [11:09am] ctalbert: Fallen: Perhaps you should take those from jminta [11:17am] Andreas joined the chat room. [11:17am] Fallen: 2 of jmintas bugs are in general and internal components. I might be able to do those, but I'd rather have someone else look at them. The third bug has ui-review-, so we should cancel review there and wait for ui-review+ [11:24am] ctalbert: I agree [11:25am] ctalbert: (with the UI review part) [11:26am] Fallen: Ok, I'm marking that one [11:27am] ctalbert: What are the other bugs? [11:28am] firebot: philipp@bugzilla.kewis.ch cancelled review?(jminta@gmail.com) for attachment 261063 on bug 199732. [11:28am] firebot: Bug https://bugzilla.mozilla.org/show_bug.cgi?id=199732 nor, --, ---, MarkusAdrario@web.de, ASSI, Events spanning days are seen as multiple events (display) [11:28am] ctalbert: hmm...that's ^^^ going to depend on war on boxes [11:29am] Fallen: bug 328996 and bug 363441 are the others [11:29am] firebot: Fallen: Bug https://bugzilla.mozilla.org/show_bug.cgi?id=328996 nor, --, ---, nobody@mozilla.org, NEW, guessSystemTimezone doesn't take northern/southern hemisphere into account [11:29am] firebot: Fallen: Bug https://bugzilla.mozilla.org/show_bug.cgi?id=363441 maj, --, ---, nobody@mozilla.org, NEW, Same item from different calendars [11:29am] mschroeder: 199732 will add icons for days spanning multiple days, so not directly related to the waronboxes [11:30am] mschroeder: for events spanning multiple days [11:30am] ctalbert: mschroeder: that's true, but depending on how we fix war on boxes, those icons may not be necessary. That's what I was thinking. Either way, the issue is UI review. [11:32am] mschroeder: that's true [11:33am] ulf joined the chat room. [11:33am] ctalbert: Fallen, I can look at those two. I think that 363441 may be somewhat addressed already. [11:33am] ctalbert: Hi ulf and andreas [11:34am] ulf: Hi, ctalbert! [11:34am] ctalbert: I think it is time for the calendar-qa chat [11:34am] Andreas: hi Clint [11:34am] ctalbert: I have nothing prepared. I just got back from vacation, and still have about 500 emails to read [11:35am] Fallen: I'd say we just go through the qa discussion [11:35am] ctalbert: Sounds good, I was just bringing it up... [11:35am] Fallen: (two of those are my bugs [11:35am] ctalbert: heh [11:35am] ctalbert: looks like we have 4 bugs [11:36am] mschroeder: and the other two I put on that list [11:36am] ctalbert: First one is bug 346540 [11:36am] firebot: ctalbert: Bug https://bugzilla.mozilla.org/show_bug.cgi?id=346540 nor, --, ---, philipp@bugzilla.kewis.ch, ASSI, empty "select calendar" dialog when import .ics [11:36am] Fallen: The question is basically in comment #10 and #7 [11:37am] ctalbert: I think we should create the calendar, the way Lightning does. [11:38am] Fallen: lightning does this? [11:38am] ctalbert: And I agree with ssitter that this patch should unify the code in those two places. [11:38am] mschroeder: I think there should be an error message and after that a prompt to create a new calendar, but no auto creation. [11:38am] ctalbert: mschroeder: Something like: [11:39am] ctalbert: "There are no calendars created, would you like to create one now?" And a choice of what to call it? [11:39am] mschroeder: and a color chooser [11:39am] ctalbert: Essentially take the last panel from the "calendar creation wizard" [11:39am] mschroeder: If you autocreate, the user has to revisit the properties of this calendar [11:40am] Fallen: I don't think we should create a new dialog if we already have a new calendar dialog [11:41am] Fallen: What about a message in the select calendar screen saying "You have no calendar. A calendar will be autocreated. If you want to customize your calendar, please use the new calendar dialog and import again" ? [11:41am] ctalbert: No, I don't want them to have to import twice [11:41am] mschroeder: I agree with ctalbert. [11:41am] Fallen: does the select calendar dialog of the import block the rest of the app? [11:42am] • ctalbert tries [11:42am] Fallen: yes [11:42am] ctalbert: yes [11:44am] Fallen: so I think we need to find a way to reuse the new calendar wizard then. Maybe an additional wizard page at the beginning that shows up instead of the select calendar window, telling the user that no calendar exists, and that he should follow the wizard [11:44am] Fallen: but then again we have very many wizard pages [11:44am] Fallen: an additional text on the first wizard page maybe? [11:45am] ctalbert: Text that could be hidden in a [11:45am] ssitter|afk joined the chat room. [11:45am] ctalbert: "normal creation" setting, and only unhidden when called this way [11:45am] Fallen: right [11:46am] mschroeder: good idea [11:46am] ctalbert: That'd probably be ok. Does this give you a good enough direction to get started? [11:46am] ctalbert: Fallen ^^ [11:47am] Fallen: I think so, yes [11:47am] Fallen: I'll comment in the bug so I don't forget [11:47am] ctalbert: Cool, sounds like a plan. I'll clear QA Wanted on that one. Next is bug 372410 [11:47am] firebot: ctalbert: Bug https://bugzilla.mozilla.org/show_bug.cgi?id=372410 enh, --, ---, nobody@mozilla.org, UNCO, time notation [11:48am] Fallen: let me, otherwise we will collide [11:48am] mschroeder: The question is in comment#1. [11:48am] ctalbert: Fallen: ok [11:49am] ctalbert: mschroeder: Sounds like a dupe to me. [11:50am] mschroeder: Linux with KDE desktop, so it's a similar setup [11:50am] firebot: ctalbert@mozilla.com set the Resolution field on bug 372410 to DUPLICATE of bug 351459. [11:50am] firebot: Bug https://bugzilla.mozilla.org/show_bug.cgi?id=351459 nor, --, ---, nobody@mozilla.org, VERI WONTFIX, Calendar displays in 12 hour format; no option to change to 24 hour (on KDE) [11:50am] ctalbert: true [11:50am] ctalbert: Next bug is bug 301117 [11:51am] firebot: ctalbert: Bug https://bugzilla.mozilla.org/show_bug.cgi?id=301117 enh, --, ---, nobody@mozilla.org, UNCO, Possibility to transform an event to a task by sliding it from the calendar to the task list. [11:52am] Fallen: I think you misunderstood? He asks if you can use drag and drop to do the task/event transformation [11:52am] ctalbert: mschroeder: I think this is still valid, It would be an interesting way to transform the event into a task. [11:52am] Fallen: i.e take a task from the task list and drag it onto a certain date [11:52am] mschroeder: Fallen: I also think so... now. [11:53am] mschroeder: But if you drag a task from the view and drop it on the list.... [11:53am] ctalbert: A task should not allow you to drop onto the task list [11:53am] ctalbert: But an event should allow the drop and on drop it should convert to a task [11:54am] Fallen: another question, when dragging the task, does this mean the task will have its dates changed to that day, or does it just do the transformation? [11:54am] Fallen: oh and what about a task that is shown in the view? (i.e tasks in view) That should not be dropped to an event [11:54am] ctalbert: I think that if you're dragging a task onto a calendar date, then you intend to change its "due date" to that day. [11:55am] Fallen: wait I think that was the first question [11:55am] ctalbert: true, with tasks in view turned on, this would be really complicated. [11:55am] ctalbert: But in that case, I would argue that the drag should not be allowed [11:55am] ctalbert: (if tasks in view is on) [11:56am] Fallen: tasks in view are getting an icon anyway, I think its ok as long as dragging a task around in the view doesnt do any conversion [11:57am] Fallen: i.e the only thing that does any conversion is dragging between the view and the task list and vice versa. Dragging an item (independant of being event or task) around in the view, just moves the date [11:58am] mschroeder: maybe we should ask Christian, if this makes sense for an UI expert pov [11:58am] Fallen: yeah [12:02pm] Fallen: I'm writing a comment and ccing christian [12:02pm] mschroeder: thanks [12:05pm] Fallen: ok, done [12:05pm] mschroeder: Last one is bug 366680. [12:05pm] firebot: mschroeder: Bug https://bugzilla.mozilla.org/show_bug.cgi?id=366680 enh, --, ---, philipp@bugzilla.kewis.ch, ASSI, Event tool tips in calendar views should display list attendees [12:07pm] ctalbert: oh sorry guys, I fell asleep. I am on some powerful cold meds... [12:07pm] • ctalbert is ashamed [12:07pm] ssitter|afk is now known as ssitter. [12:08pm] damian joined the chat room. [12:09pm] mschroeder: Participation should be shown as icon imo. [12:09pm] Fallen: thats ok, don't worry [12:09pm] Fallen: an icon before the name and email probably? [12:10pm] ctalbert: yes, I think so [12:10pm] mschroeder: we should cut off the tooltip if it gets too large [12:10pm] ctalbert: right, maybe with ... [12:10pm] ctalbert: I think that delegation issues are too far out on the horizon for us to worry about at this point, so I would ignore that for now. [12:11pm] ctalbert: Unless, wcap already supports that. [12:11pm] ulf: hmm, good question - I don't think so [12:11pm] Fallen: there is a ready function in the mouseoverPreview.js that shortens the text to xxx lines. But how many shoud we show? A certain number? Or do you mean make it dependant on how much information is already there? [12:11pm] mschroeder: so it's doesn't depend on the attendees list if the tooltip should get cut off, it could also bet the title [12:12pm] ctalbert: Fallen: the number of lines to show is a question that Christian would probably have an answer to. [12:12pm] ctalbert: I think the size of the tooltip should be related to the size of the application window. [12:13pm] mschroeder: agreed [12:13pm] ctalbert: Pick some kind of ratio between those two, and enforce that number of lines to show. But, I'd like to get Christian's thoughts on that. [12:14pm] Fallen: if we make it relative to the app window size, we dont really have to enforce max lines, right? [12:14pm] ctalbert: And since it doesn't appear that wcap currently handles delegation, I think we should just ignore it for now and focus on cleaning up our invitation management infrastructure before we worry about the UI of "delegated-to" and "delegated-from". [12:15pm] ctalbert: Fallen: that's probably true. [12:15pm] Fallen: ulf: does wcap use calIAttendee's .commonName ? [12:16pm] Fallen: right now the old dialog sets the .id to mailto:email@example.com, no other info [12:16pm] ulf: ough - I don't know the spec that well [12:16pm] ulf: have to pass that question to daniel [12:17pm] Fallen: ah they do... http://mxr.mozilla.org/mozilla/source/calendar/providers/wcap/calWcapCalendarItems.js#63 [12:18pm] Fallen: So then I should probably use (icon) commonName <email@example.com> [12:18pm] ctalbert: ^^ That sounds like a good idea [12:18pm] Fallen: with the icons. Since the icons themselves wont be able to have a tooltip (at least I'd think so), they need to be very descriptive... [12:19pm] ctalbert: yes, I don't think we'd want tooltips in tooltips [12:19pm] mschroeder: [12:19pm] ctalbert: I thought the wcap icons were pretty good in this area [12:19pm] Fallen: I haven't had a close look at them [12:20pm] ulf: ? [12:20pm] ctalbert: ulf: Aren't there Participation status icons on the Attendee panel of the prototype event dialog? [12:20pm] ctalbert: An icon for "Accepted" an icon for "Declined" etc [12:21pm] Fallen: http://mxr.mozilla.org/mozilla/source/calendar/prototypes/themes/winstripe/ [12:21pm] ctalbert: Ah, yep, there they are. [12:21pm] Fallen: there is only accepted and declined though [12:21pm] ulf: yes, they are there [12:22pm] ctalbert: we need something for tentative [12:22pm] ctalbert: maybe '~' [12:22pm] ctalbert: [12:22pm] ctalbert: or better: '?' [12:22pm] Fallen: We can leave that to the great artists [12:22pm] ctalbert: yeah [12:23pm] ctalbert: But, I think we can start out with that icon set. [12:23pm] ctalbert: And Christian can direct us from there. [12:23pm] ssitter was promoted to operator by ChanServ. [12:26pm] ctalbert: So, does this resolve the questions with bug 366680? [12:26pm] firebot: ctalbert: Bug https://bugzilla.mozilla.org/show_bug.cgi?id=366680 enh, --, ---, philipp@bugzilla.kewis.ch, ASSI, Event tool tips in calendar views should display list attendees [12:26pm] Fallen: yes, I think so. I'm almost done with my comment [12:26pm] ctalbert: cool. [12:28pm] ctalbert: Is there anything else that folks want to bring up? We're almost out of time. [12:28pm] mschroeder: ctalbert: You should sleep now. [12:29pm] ulf: what do people think about 0.5? do we need another test day? [12:29pm] Fallen: I remember someone asked if there was going to be a testday for rc2 [12:29pm] ulf: i know [12:29pm] ctalbert: We do want a test day on RC2, just to be sure that it's ok. [12:30pm] ctalbert: But first, we need RC2. Does anyone have info on where that effort is at? It sounded like Ause had taken on that fight [12:30pm] mschroeder: We still need to verify some blocking bugs, especially on Mac. [12:30pm] ssitter: ctalbert: you mean RC3? [12:31pm] ctalbert: Uh...yeah, I guess. Did we have an RC 2? [12:32pm] ssitter: RC2 (except lightning for Mac) was out 5 days ago [12:32pm] ulf: ctalber: afaik Ause still has no access to the tinderboxes [12:32pm] mschroeder: Fallen: Can we clear [qa discussion needed] on 366680? [12:32pm] ssitter: but there was another bug fixed in between by daniel [12:32pm] ctalbert: ssitter: do you have the number? I still have 153 bugmail messages to read [12:32pm] Fallen: oh I forgot that there, go ahead [12:33pm] ssitter: ctalbert: bug 384726 [12:33pm] firebot: ssitter: Bug https://bugzilla.mozilla.org/show_bug.cgi?id=384726 nor, --, ---, daniel.boelzle@sun.com, ASSI, Todo items are duplicated (ICS Calendar only) [12:33pm] ctalbert: thanks [12:36pm] ctalbert: So, we don't need a test day on RC2, in my opinion, we should probably push ahead with making an RC3 and have a test day for that. [12:36pm] ctalbert: Thoughts? [12:37pm] mschroeder: +1 [12:38pm] ulf: +1 [12:38pm] ctalbert: ulf: Can you ask Ause to get online (IRC) tomorrow, and I'll get on early and we'll talk about getting a new RC done? [12:39pm] ulf: yes, sure! [12:39pm] ssitter: first step would be to get solaria back online [12:39pm] ctalbert: ssitter, was that the name of the windows tbox? [12:40pm] ssitter: solaria [12:40pm] ctalbert: cool. I'll ask preed about that. [12:41pm] ctalbert: Anything else? [12:43pm] Fallen: I think thats it [12:43pm] ctalbert: sounds like it. Ok. Thanks for being around guys. Good night, ulf, andreas [12:44pm] • ctalbert will update wiki with notes [12:44pm] ulf: have a nice day, Clint
