Firefox OS/Comms/Dialer/Sprint/v2.2-S7/20140302-StandupNotes

From MozillaWiki
< Firefox OS‎ | Comms‎ | Dialer‎ | Sprint
Jump to: navigation, search


  • Admin:
    • Nothing new.
  • Next steps:
    • bug 1133621 - [RTL][Dialer] Vertical scrollbar appears shortly at left side of prompt text.
      • Going to investigate.
  • Patches:
    • Nothing new.
  • Reviews:
    • bug 1125409 - [Dialer] Double Tapping the Add Contact button will bring up the context menu twice.
      • r?
    • bug 1017966 - [Flame][V1.4][Dialer]There is no prompts when you tap on "Call" without any number in the dialer field.
      • r?
    • bug 1068224 - Limit the amount of calls shown in the call info view
      • f?
  • Other:


  • Admin - not much to report on dialer as I spent most of yesterday on metrics work due to deadline.
    • bug 1131246 - Posted a feedback on this one. Will try and get this ready for review.
      • this has a problem where it’s truncating the number with multiple calls when it shouldn’t be. Need to fix this
    • bug 1135067 - Restarted the tests on this as they seem to have disappeared from the PR.
    • bug 1134961 - I have a line on fix for this one.
      • wrapping in bdi fixes the + direction in rtl.
      • The fix is is in the contact_overlay so this also affects emergency-dialer and the ice contacts. So, I’m checking to make sure it all works there. The only spot I found where it gets invoked is when the user goes to the ice contacts. This is in shared but there aren’t any other uses of this file other than emergency dialer and dialer.
      • I have an NI to Ahmed for the following issue: in LTR, we have |+14085551212, Mobile|. When this gets wrapped in BDI, we have |+14085551212 ,Mobile| So the space is before the comma vs. after. I’m not sure if this is correct, so sent NI to figure out what we should do here. If the comma is supposed to have the space after, then probably an entirely different fix that what I have right now.
    • bug 1011066 - Started looking at this. Have an NI out to make sure how it’s supposed to look.
      • This was erroneously (I believe) marked as a regression. However, not sure who changes that flag. See Comment 13
      • I have an ni to swilkes on this to make sure that the SIM should be on the left. I don’t believe this is just an overlap fix.
    • Bug
    • Uplifts:
    • Reviews:
      • bug 1134871 - Finished this review - r+
      • bug 1131261 - Finished this review - r+ with some minor comments.
      • bug 1135023 - Did a semi-review of this and found some issues when I tested so paused on review.
    • New Bugs Filed
      • bug 1134961 - Dialer suggestion is not bdi (the + is on the wrong side)


  • Admin:
    • Will be on PTO next week from Tuesday 10th to Sunday 15th
  • Done:
    • Nothing to report today
  • Next steps:
    • Nothing currently planned for the dialer.


  • Admin:
    • I’ll take some PTO on Friday, probably 4h
  • Bugs:
    • bug 1102814 - Make the dialer use the `notification' channel for playing the touch tones
      • Landed on master
    • bug 1131490 - [RTL][Dialer]The number of calls handled is shown at the right of call number.
    • Approved for v2.2, waiting for the uplift
    • bug 1135023 - Recent contact's name disappears if you call him back with the call log
      • The patch I had prepared only partially fixes the problem, more investigation is needed
  • Reviews
    • None


  • Absent/no report