Confirm, emeritus
2,088
edits
Changes
m
no edit summary
3) Upon first run, I have to add the frecency column to the moz_places table, create an index for that column, and make sure that livemark items and "place:" urls get a frecency of 0, and it should not appear in the ac results. Another way for a place to have a 0 frecency is if the url only has "embedded" visits.
5) If I don't know the frececny frecency of a place, the value is -1. This is what I call an "invalid" frecency. If something has an invalid frecency, it will show up in the ac results.
6) the url bar drop down shows "typed" sites, ordered by frecency descending.
7) When inserting a bookmark, we attempt to calculate a frecency for it. This will impact the performance of bookmark import and also fx 2 - > fx 3 migration. (spin off bug coming about how to deal with it.)
8) for how we calculate a freceny frecency for a site, see http://wiki.mozilla.org/User:Mconnor/PlacesFrecency (and option 3). I use the 10 most recent visits, and this is pref controlled, as all are the buckets, weights and bonus values.
9) if we don't have any visits for a site, I make an attempt to estimate the frecency. more on this in a spin off bug (including when we should estimate and when we should not.)
5)
issue: if when autocompleteingautocompleting, we will prefer moz_place title over bookmark title, and so when showing match, we will show that one. because of the fix for bug #407292 – When adding a bookmark with no title, we should use the uri as the title, you might get the uri as the title if it matches the user text, as we prefer it.
6)
21)
for the ac queries, sort by frecenyfrecency, then typed, then visit_count because we might not have frecency. in the case of 3b2 migration or clear all private data, lots of places have frecency = -1 (until idle), so we will have lots of frecency ties, so use typed and visit_count to break the ties and provide better results.
22)
25)
improved mDBOldFrecnecy mDBOldFrecency query, explain why to deitrichdietrich
26)
29) would like to order autocomplete by frecency DESC, typed DESC visit_count DESC to break ties, but this is slow, even with an index. (spin off bug)
30) comment about why we add typed bonus to bookmark bonus for frecency of
// not the same logic above, as a single visit could not both
x)
for calc frecncyfrecency, never calc 0 unless place: or unvisit livemark item, so do 1.
x)
x)
when calc frecncyfrecency, never calc 0 unless place: or unvisit livemark item, so do 1.
x)
2 -> 3 migration, frecency = -1, but do we have visit counts? force place: and unvisited livemarks to be zero, do one on idle, wait for rest?
3b2 - > 3 migraitonmigration, frecency = -1, but we do have visit counts. force place: and unvisited livemarks to be zero, do on idle, wait for rest.
clear all private data, frecency = -1, but we do have visit counts. force place: and unvisited livemarks to be zero, do on idle, wait for rest.
small area:
partial expiration, frecency = -1 for a few places, but we do have visit counts. don't think we need to force place and unvisited livemarks, (maybe we do for unvisit livemakslivemarks) , do on idle, wait for rest.
small, but could be big:
