Confirmed users, Bureaucrats and Sysops emeriti
1,680
edits
Obj-C Exceptions In Gecko: Difference between revisions
Jump to navigation
Jump to search
no edit summary
No edit summary |
No edit summary |
||
| Line 11: | Line 11: | ||
I have checked in a set of macros for doing that, see this file: | I have checked in a set of macros for doing that, see this file: | ||
mozilla/xpcom/base/nsObjCExceptions.h | [http://mxr.mozilla.org/firefox/source/xpcom/base/nsObjCExceptions.h mozilla/xpcom/base/nsObjCExceptions.h] | ||
Before you start doing anything, please read through every line of that file and make sure you understand what all of it is for. If you don't understand anything please ask me on email or irc. It wouldn't be very awesome if you posted a bunch of work and had to do it all over again. | Before you start doing anything, please read through every line of that file and make sure you understand what all of it is for. If you don't understand anything please ask me on email or irc. It wouldn't be very awesome if you posted a bunch of work and had to do it all over again. | ||
Another thing to read over is nsAppShell.mm. I have done the work for nsAppShell.mm already and checked it in. Make sure you understand why I made the choices I did there, and again ask if you are unclear about anything. | Another thing to read over is [http://mxr.mozilla.org/firefox/source/widget/src/cocoa/nsAppShell.mm nsAppShell.mm]. I have done the work for nsAppShell.mm already and checked it in. Make sure you understand why I made the choices I did there, and again ask if you are unclear about anything. | ||
When wrapping calls in a method, the first choice you'll have to make is whether to wrap specific calls or the whole method impl. Which one you pick is usually a matter of cleanliness. If there is a big method with a single Apple framework call in it, you might just want to wrap that specific call. Your choice of macros are these: | When wrapping calls in a method, the first choice you'll have to make is whether to wrap specific calls or the whole method impl. Which one you pick is usually a matter of cleanliness. If there is a big method with a single Apple framework call in it, you might just want to wrap that specific call. Your choice of macros are these: | ||