TPE-Layout/2017-09-19

Weekly Announcement

Weekly Sharing

Weekly Status

Astley Chen

• bug 1398613 NEW:: clientWidth for select elements is returning size of largest option value instead size of the entire select element
  • Bug 1398613 - confirmed and working on regression check.
  • Bug 1398613 - regression window found and ni bz to check.
• Taipei Developer Conference
  • CSS Grid and DevTools study
  • Slide deck

Boris Chiou

• bug 1390026 ASSIGNED:: stylo: make shape-outside animatable on <basic-shape>
  • Wrote a patch for bug 1390026 - stylo: make shape-outside animatable on <basic-shape>
• bug 1388601 ASSIGNED:: stylo: Implement test cases for ComputeSquaredDistance on BasicShape and FilterList
  • Wrote patches for bug 1388601 - stylo: Implement test cases for ComputeSquaredDistance on BasicShape and FilterList
• bug 1334582 RESOLVED::FIXED WebAnimation crash: Assertion failure: result.mCurrentIteration != 0 (Should not have zero current iteration) [@mozilla::dom::AnimationEffectReadOnly::GetComputedTimingAt]
  • Reviewed bug 1334582 - WebAnimation crash: Assertion failure: result.mCurrentIteration != 0
• bug 1399714 RESOLVED::FIXED Do not need to iterate animation segments twice for setting start/end values and timing functions
  • Reviewed bug 1399714 - Do not need to iterate animation segments twice for setting start/end values and timing functions
• bug 1392161 RESOLVED::FIXED stylo: Length values should not be rounded to Au for computed transform
  • Landed bug 1392161 - stylo: Length values should not be rounded to Au for computed transform
• bug 1399799 ASSIGNED:: stylo: Values of amount over 100% are allowed but UAs must clamp the values to 1 for some filter fuctions
  • Filed Bug 1399799 - stylo: Values of amount over 100% are allowed but UAs must clamp the values to 1 for some filter fuctions

Cameron McCormack

• Did some experiments to see how ineffective style sharing cache is in dynamic documents, and did lots more AWSY try pushes
• Reviewed https://github.com/servo/servo/pull/18497
• Reviewed https://github.com/servo/servo/pull/18519#pullrequestreview-62973972
• bug 1397971 RESOLVED::FIXED stylo: lots of memory used for SpecifiedURLs relating to images for gmail
  • Reviewed bug 1397971
• bug 1398993 RESOLVED::FIXED stylo: disable stylo in e10s parent process
  • Landed bug 1398993
  • Upload patch for bug 1398993
• bug 1363805 ASSIGNED:: Only flush styles on nsComputedDOMStyle::UpdateCurrentStyleSources if we know that the child or one of its ancestors need a restyle.
  • Reviewed bug 1363805
• bug 1399758 ASSIGNED:: stylo: Measure ImageValue objects
  • Reviewed bug 1399758
• bug 1367635 RESOLVED::FIXED stylo: share reset structs during the style traversal
  • Uploaded patches for bug 1367635

CJ Ku

• bug 1385239 RESOLVED::FIXED incorrect SVG mask with transformed/filtered graphic object
  • Bug 1385239 landed
• bug 1290782 NEW:: SVG border-image without viewport size and viewBox is broken when changing the opacity.
  • Bug 1290782 reviewed
  • Bug 1290782 working on patch

Eric Tsai

• Issue triage and diagnosis
• Prepare Mozilla Developer Conference slides

Farmer Tseng

• Uploaded a WIP patch to create a sandboxed process
• bug 1399787 NEW:: Create a new sandboxed process to run pdfium
  • Filed Bug 1399787
  • Uploaded a WIP patch to create a sandboxed process on Bug 1399787

Jeremy Chen

• bug 1400167 NEW:: investigate why animating between matched transform lists with singular matrix is not discrete in Gecko
  • Filed Bug 1400167
• bug 1399805 RESOLVED::FIXED can't run wpt tests without specifying the path of fix_macosx_stack.py by "--stackfix-dir"
  • Filed Bug 1399805
  • Landed Bug 1399805
• bug 613693 RESOLVED::WORKSFORME Use fix_macosx_stack.py instead of fix-macosx-stack.pl
  • Resolved Bug 613693
• bug 1394284 ASSIGNED:: stylo: animate transform with singular matrix as discrete
  • Updated the patchset and re-request review [bug 1394284]
  • Updated the patchset, added tests, request for review again [Bug 1394284]
  • Updated the patchset, wrote a wip for Gecko part, still have one try failure [Bug 1394284]
• bug 1399049 NEW:: stylo: do not use InterpolateMatrix as a fallback for interpolation errors in a matched transform function pair
  • Filed Bug 1399049

Louis Chang

• bug 1290782 - SVG border-image without viewport size and viewBox is broken when changing the opacity.
  • r+cj | r?dholbert
• bug 1399776 - background-color: transparent makes the checkbox disappear on Firefox Android
  • r+mats
• bug 1398081 - e10s / non-e10s choose a option in <select> then refresh will not set to default selected disabled option
  • open

Ting-Yu Lin

• bug 1396743 NEW:: Video is not resized accordingly when page zoom level is reset on new YouTube UI
  • Investigate bug 1396743.
• bug 1399767 RESOLVED::FIXED Remove preference "layout.css.clip-path-shapes.enabled"
  • Filed bug 1399767 - Remove preference "layout.css.clip-path-shapes.enabled"
  • Landed bug 1399767.
  • Uploaded a patch for bug 1399767.
• bug 1302423 RESOLVED::FIXED Update web-platform-tests to revision 6b48d45a1c7f3243945bf1678008f607e70acf2e
  • NI for a missing test in bug 1302423.
• bug 1398704 RESOLVED::WORKSFORME paste replace
  • Close bug 1398704 as WORKSFORME.
• bug 1341009 ASSIGNED:: Eliminate unneeded nsReflowStatus::Reset() calls
  • Uploaded new patchset for review (bug 1341009)
  • Uploaded patches for bug 1341009.
• bug 1400773 ASSIGNED:: Reland basic shape wpt test added in bug 1290864
  • Filed and landed bug 1400773.

Tommy Kuo

• Preparing the demo of web extension for Mozilla developer day
• Validate the bug (bug ) 1363152
• bug 1229979 RESOLVED::FIXED Multi-color shadow shouldn't be allowed when the color of text is different to the color of decoration line.
  • Re-landed (bug 1229979)
• bug 1363152 RESOLVED::INVALID [e10s] text color of <option> not shown
  • Validate the bug (bug 1363152)
• bug 1376443 UNCONFIRMED:: Select option inherited background-color differs between initial focus/open state and subsequent focus/open states
  • Validate the bug (bug 1376443)

Ya-Chieh Wu

• bug 895096 - border-collapsed table borders have inconsistent widths when device pixel scale is not 1 (zoom)
  • r+
• bug 1379038 RESOLVED::FIXED Border Collapse causing 1px off
  • Fixed bug 1379038
• bug 410959 RESOLVED::FIXED [BC] Table cell border widths render incorrectly at various zoom levels
  • Fixed bug 410959

Rule of Thumb

Status code:

• OOAD: In analysis or design phase.
• WIP: working on WIP patch.
• feedback(f): feedback a patch
• feedback?(f?): WIP is ready for feedback grant.
• feedback+(f+): Get positive feedback.
• feedback-(f-): Get negative feedback.
• review(r): review a patch.
• review?(r?): patch is under review
• review+(r+): get review+ and ready to check-in
• review-(r-): get negative review feedback. Fix problems and switch back to r? again.
• land: patch check in.
• debug: Figure out the root cause of a bug/ try to repro that bug, etc...
• file: file a bug
• PTO: take personal leave
• interview(I)
• study: Spend time on domain knowledge study, such as multimedia transport technology, compress format, real-time rendering.
• presentation
  • Write a personal blog, which is relative to work, such as articles on MozTech, or what you experience in a work week.
  • WIKI/ MDN article writing.
  • If you write a technical blog or anything relative to work, it's welcome to share it on weekly report.
  • Do a presentation of technical topics