Update:Remora Developers/developers/add

From MozillaWiki
Jump to: navigation, search

Phase 1

Phase 1 of additem is now complete, and I'd appreciate any comments/suggestions/bugs added to the section below.

The list of "features" is quite long, so I'll wait until I finish the tests for them (hopefully tomorrow) and then start closing some bugs.

Feel free to check out a copy or use this one and test it. You can use some sample files here for testing.

  • google.src and extension.png can be tested with Search Plugins
  • enaudic can be tested as an update to an existing addon (if using remora-with-data.sql data -- just upload it as new or go to /developers/add/1)
  • english_australian_dictionary-etc is an extension with invalid target apps
  • extension.xpi is a new extension

Comments/Bugs/Suggestions

  • I think identical versions are allowed if newAddon is swapped via recognized GUID Fligtar 12:33, 27 September 2006 (PDT)
  • We should detect if users are submitting dictionaries as extensions or extensions as dictionaries, and "error their shit into the stone age"
    • A basic description of a dictionary:
      • .xpi file extension
      • Has a /dictionaries/ directory
      • Has a file called *.dic in /dictionaries/
    • That oughta be enough to keep us going
  • Filenames should not be escaped for HTML Fligtar 23:06, 28 September 2006 (PDT)
  • Trailing dash on filename when moved to approval dir

Phase 2

This phase will be started on after sessions, ACL, approval queue, and other components have been completed.

  • allow HTML in description, developer comments, version notes
  • fix default author
  • deny any pending versions in queue
  • Amo component: checkOwnership revisit()
  • Error message/success message revisit
  • Localization/translation stuff, like multiple descriptions
  • Getting file from external URL