WebDriver/Meetings/2019/03/04

From MozillaWiki
Jump to: navigation, search

Agenda

  • WebDriver spec for HTTP authentication (Henrik)
    • Brian doesn’t have the time to write that content
    • Maybe David as the editor of the spec can pick it up?
  • Proposal to run each wdspec test in its own tab for better test isolation (Henrik)
    • Currently this is only done for tests covering the navigation and send alert text commands
    • Global session fixture could be used to correctly set this up
    • No modification of tests should be necessary

Roster

Present
whimboo, AutomatedTester, ato
Regrets

Minutes

Action item followup

whimboo
I’ve filed bugs about the marionette-startup-requested system observer notification.
Been in touch with Gijs and various other engineers to get this implemented.

WebDriver spec for HTTP authentication

whimboo
I asked Brian if he had time to get this written up for the spec, but he does not have time at the moment.
I wonder if AutomatedTester could pick this up, seeing as you’re the editor of the spec?
AutomatedTester
How many people are asking for this feature?
whimboo
Directly asking, not that many.
But I wonder how many people want it.
AutomatedTester
Anecdotally, from the Selenium project, this is a feature that was requested regularly but not frequently.
But it will not happen quickly right now.
whimboo
OK, so I also wonder how we can do it in a general way? How has this been handled in the past?
AutomatedTester
We’ve tried to nominate people, that didn’t work.
We have tried to leave it alone, that didn’t work.
whimboo
I don’t know all the details.
What does ‘editor’ actually mean in this context?
AutomatedTester
From the W3C point of view, an editor is as the name implies, people will come with different spec prose and the editor will check it.
In reality, spec writing and editing is often the same thing.
In CSS for example there are three editors and they also do all the work of writing the specification.
I still need to revisit all the shadow DOM stuff and fix that up, and that is a higher priority than this.
ato
I just want to add that I think this is not hard.
I can offer guidance in helping anyone who want to, to write this.

Proposal to run each wdspec test in its own tab for better test isolation

whimboo
[Tabs have limits to how many times HTTP auth dialogues can appear.]
In the verify jobs, we run a specific test a couple of times.
This caused the problem because we run the tests in the same tab.
In other tests we open a new tab which give us some level of separation.
We only have to change some global fixtures.
ato
The only limitation I can think of is that it has historically been hard to open new top-level browsing contexts with WebDriver.
I think this sounds like the right thing to do, but I wonder how this would affect the other browser implementations.
Before giving an r+ on this I would like to hear what the other vendors think.
I expect they will say that this is the right thing to do.

ACTION: whimboo to file issue on WPT, asking for feedback on running certain tests (HTTP auth et al.) in new tabs

Intermittents update (whimboo)

  • [fixed by bug 1520062] Intermittent Assertion failure: m_refCount == 1, at /builds/worker/workspace/build/src/js/src/jit/ExecutableAllocator.cpp:51 (Bug 1486101)
  • [fixed] The upgrade of Windows workers from 1703 to 1803 fixed a couple of Fxui intermittents
  • [fixed] Moving Sleep() from TimedPromise to Promise caused high frequent hangs in Action tests (1529633, 1529649, 1529699)
    • Due to some reason the Promise in combination with setTimeout never resolves - needs further investigation
  • [needs feedback] Marionette client hangs 1000s due to channel errors (Bug 1521447)
    • There is a hang of Firefox when `ProcessChild::QuickExit()` is called.
    • The main process never exits and as such is causing this timeout in mozprocess
  • [needs patch] Lots of Mochitest and Mn failures on Windows10 64bit due to missing sessionstore-windows-restored notification. Maybe having our own marionette-startup-requested notification (bug 1530979) could fix it.

Status updates

(Spoken status updates in bold.)

  • ato
    • Outreachy applicant mentoring
  • henrik
    • [geckodriver] Package binary of geckodriver into its own artifact (Bug 1493948)
    • [marionette] Release marionette_driver 2.8.0 and marionette_harness 4.6.0 (Bug 1530794)
    • [marionette] "Marionette:SetScreenOrientation" has to wait for "orientationchange" event (Bug 1529938)
    • [marionette] Error stack for logging in TimedPromise only contains it's own frame (Bug 1529516)
    • [marionette] New window command can timeout because of missing focus events when switching back to original window (Bug 1523234)

PTO (🌷)