Security/Tracking protection/Bug triage: Difference between revisions

From MozillaWiki
Jump to navigation Jump to search
m (typo)
(→‎Initial triage: Fix the links to the metabugs.)
 
(9 intermediate revisions by 2 users not shown)
Line 1: Line 1:
Once the bugs are fully triaged, there should be:
* a priority on each bug
* nothing with '''tp-needsrepro'''
* no webcompat bugs linked to the '''trackingprotection''' meta bug
==Initial triage==
As bugs come into the [https://bugzilla.mozilla.org/buglist.cgi?component=Tracking%20Protection&product=Firefox&bug_status=__open__&list_id=13299377 Firefox::Tracking Protection] component, the bug triage owner should follow these steps:
As bugs come into the [https://bugzilla.mozilla.org/buglist.cgi?component=Tracking%20Protection&product=Firefox&bug_status=__open__&list_id=13299377 Firefox::Tracking Protection] component, the bug triage owner should follow these steps:


Line 5: Line 13:
#* Server-side bugs should be moved into '''Cloud Services::Server: Shavar'''
#* Server-side bugs should be moved into '''Cloud Services::Server: Shavar'''
# Breakage bugs should block one of these meta bugs:
# Breakage bugs should block one of these meta bugs:
#* <tt>tppaywall</tt> if TP is triggering a paywall / adblocker detection script (e.g. [https://github.com/sitexw/FuckAdBlock FuckAdBlock])
#* <tt>[https://bugzilla.mozilla.org/showdependencytree.cgi?id=1400031&hide_resolved=1 tppaywall]</tt> if TP is triggering a paywall / adblocker detection script (e.g. [https://github.com/sitexw/FuckAdBlock FuckAdBlock])
#* <tt>tpvideo</tt> if TP is blocking the playing of videos
#* <tt>[https://bugzilla.mozilla.org/showdependencytree.cgi?id=1400025&hide_resolved=1 tpvideo]</tt> if TP is blocking the playing of videos
#* <tt>trackingprotection</tt> otherwise
#* <tt>[https://bugzilla.mozilla.org/showdependencytree.cgi?id=1470298&hide_resolved=1 tplogin]</tt> if TP is breaking the login/registration flow of a site (including SSO providers)
# Close paywall-related bugs as <tt>WONTFIX</tt>.
#* <tt>[https://bugzilla.mozilla.org/showdependencytree.cgi?id=1470301&hide_resolved=1 tpimages]</tt> if TP is blocking necessary/useful images (excluding display ads)
# Mark bugs that have the same root cause (e.g. Facebook videos are blocked on site X) as <tt>DUPLICATE</tt> of one another.
#* <tt>[https://bugzilla.mozilla.org/showdependencytree.cgi?id=1486425&hide_resolved=1 tpcomments]</tt> if TP is blocking the display of comments
#* <tt>[https://bugzilla.mozilla.org/showdependencytree.cgi?id=1101005&hide_resolved=1 trackingprotection]</tt> otherwise
# Close paywall-related bugs as <tt>WONTFIX</tt> (look at [https://bugzilla.mozilla.org/show_bug.cgi?id=1449319#c2 this comment] for an example).
# Add the '''tp-entitylist''' whiteboard tag if the breakage could be mitigated by expanding the entity whitelist to linked domains owned by the same organization.
# Add the '''tp-entitylist''' whiteboard tag if the breakage could be mitigated by expanding the entity whitelist to linked domains owned by the same organization.
# Add the '''tp-needsrepro''' whiteboard tag if the problematic resource is not mentioned in the bug.
# Add the '''tp-needsrepro''' whiteboard tag if the problematic resource is not mentioned in the bug (see next section).
# For feature requests and bugs that require a product decision:
# For feature requests and bugs that require a product decision:
## Tag with the '''tp-product''' whiteboard tag.
## Tag with the '''tp-product''' whiteboard tag.
## '''NEEDINFO :pdol''' with a suggested decision (typically <tt>P3</tt> or <tt>WONTFIX</tt>).
## '''NEEDINFO :pdol''' with a suggested decision (typically <tt>P3</tt> or <tt>WONTFIX</tt>).
# Move to '''Tech Evangelism: Desktop''' any bug that needs to be resolved by the site owners (e.g. to avoid relying on trackers for their site's functionality to work).
# Set a priority on the bug:
# Set a priority on the bug:
#* '''tp-needsrepro''': <tt>P3</tt>
#* '''tp-needsrepro''': <tt>P3</tt>
#* '''tp-product''': <tt>--</tt>
#* '''tp-product''': <tt>--</tt>
#* '''tp-entitylist''': <tt>P2</tt>
#* '''tp-entitylist''': <tt>P2</tt>
#* '''Tech Evangelism''': <tt>--</tt>


==Reproducing bugs==
==Reproducing bugs==
Line 26: Line 34:
Someone looking at the [https://bugzilla.mozilla.org/buglist.cgi?list_id=13780003&status_whiteboard_type=allwordssubstr&query_format=advanced&status_whiteboard=tp-needsrepro&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&component=Tracking%20Protection&product=Firefox <tt>tp-needsrepro</tt> bugs] should:
Someone looking at the [https://bugzilla.mozilla.org/buglist.cgi?list_id=13780003&status_whiteboard_type=allwordssubstr&query_format=advanced&status_whiteboard=tp-needsrepro&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&component=Tracking%20Protection&product=Firefox <tt>tp-needsrepro</tt> bugs] should:


# Ensure the URL of the broken page is in the URL field
# Close any unreproducible bugs with <tt>WORKSFORME</tt>.
# Close any unreproducible bugs with <tt>WORKSFORME</tt>.
# Find the offending blocked resource and add a comment to the bug.
# Mark bugs that have the same root cause (e.g. Facebook videos are blocked on site X) as <tt>DUPLICATE</tt> of one another.
# Tag bugs with the list that causes the breakage in the whiteboard field.
# Find the blocked resource(s) responsible for the breakage (using [https://addons.mozilla.org/firefox/addon/umatrix/ uMatrix]) and add it to the '''user story''' field.
#* '''tp-base''' for the standard list
# Tag bugs with the category that causes the breakage in the '''whiteboard''' field (use [https://github.com/mozilla-services/shavar-list-creation/blob/master/disconnect_mapping.py this mapping] for Twitter, Google and Facebook resources in the ''Disconnect'' category):
#* '''tp-content''' for the strict list
#* '''tp-ads''' for the Advertising category
#* '''tp-analytics''' for the Analytics category
#* '''tp-social''' for the Social category
#* '''tp-content''' for the Content category (only part of the strict list)
# Remove the '''tp-needsrepro''' tag.
# Move the bug to '''Tech Evangelism: Desktop''' and reset the priority to <tt>--</tt>.

Latest revision as of 15:48, 27 August 2018

Once the bugs are fully triaged, there should be:

  • a priority on each bug
  • nothing with tp-needsrepro
  • no webcompat bugs linked to the trackingprotection meta bug

Initial triage

As bugs come into the Firefox::Tracking Protection component, the bug triage owner should follow these steps:

  1. Move misplaced bugs into the right component:
    • Platform bugs should be moved into Toolkit::Safe Browsing
    • Server-side bugs should be moved into Cloud Services::Server: Shavar
  2. Breakage bugs should block one of these meta bugs:
    • tppaywall if TP is triggering a paywall / adblocker detection script (e.g. FuckAdBlock)
    • tpvideo if TP is blocking the playing of videos
    • tplogin if TP is breaking the login/registration flow of a site (including SSO providers)
    • tpimages if TP is blocking necessary/useful images (excluding display ads)
    • tpcomments if TP is blocking the display of comments
    • trackingprotection otherwise
  3. Close paywall-related bugs as WONTFIX (look at this comment for an example).
  4. Add the tp-entitylist whiteboard tag if the breakage could be mitigated by expanding the entity whitelist to linked domains owned by the same organization.
  5. Add the tp-needsrepro whiteboard tag if the problematic resource is not mentioned in the bug (see next section).
  6. For feature requests and bugs that require a product decision:
    1. Tag with the tp-product whiteboard tag.
    2. NEEDINFO :pdol with a suggested decision (typically P3 or WONTFIX).
  7. Set a priority on the bug:
    • tp-needsrepro: P3
    • tp-product: --
    • tp-entitylist: P2

Reproducing bugs

Someone looking at the tp-needsrepro bugs should:

  1. Ensure the URL of the broken page is in the URL field
  2. Close any unreproducible bugs with WORKSFORME.
  3. Mark bugs that have the same root cause (e.g. Facebook videos are blocked on site X) as DUPLICATE of one another.
  4. Find the blocked resource(s) responsible for the breakage (using uMatrix) and add it to the user story field.
  5. Tag bugs with the category that causes the breakage in the whiteboard field (use this mapping for Twitter, Google and Facebook resources in the Disconnect category):
    • tp-ads for the Advertising category
    • tp-analytics for the Analytics category
    • tp-social for the Social category
    • tp-content for the Content category (only part of the strict list)
  6. Remove the tp-needsrepro tag.
  7. Move the bug to Tech Evangelism: Desktop and reset the priority to --.
Retrieved from "https://wiki.mozilla.org/index.php?title=Security/Tracking_protection/Bug_triage&oldid=1200059"