Security/Tracking protection/Bug triage: Difference between revisions

From MozillaWiki
Jump to navigation Jump to search
(Add instructions on when to NEEDINFO Peter)
(Add the tp-needsrepro tag and split the triage into two parts)
Line 1: Line 1:
==How==
As bug come into the [https://bugzilla.mozilla.org/buglist.cgi?component=Tracking%20Protection&product=Firefox&bug_status=__open__&list_id=13299377 Firefox::Tracking Protection] component, the bug triage owner should follow these steps:


# Look through all [https://bugzilla.mozilla.org/buglist.cgi?component=Tracking%20Protection&product=Firefox&bug_status=__open__&list_id=13299377 Firefox::Tracking Protection bugs] and webcompat.com issues linked from the [https://bugzilla.mozilla.org/show_bug.cgi?id=1101005 breakage metabug] looking for things we can fix:
# Move misplaced bugs into the right component:
#* Platform bugs should be moved into '''Toolkit::Safe Browsing'''
#* Platform bugs should be moved into '''Toolkit::Safe Browsing'''
#* Server-side bugs should be moved into '''Cloud Services::Server: Shavar'''
#* Server-side bugs should be moved into '''Cloud Services::Server: Shavar'''
# Close any unreproducible bugs with <tt>WORKSFORME</tt>.
# Breakage bugs should block one of these meta bugs:
# Breakage bugs should block one of these meta bugs:
#* <tt>tppaywall</tt> if TP is triggering a paywall / adblocker detection script (e.g. [https://github.com/sitexw/FuckAdBlock FuckAdBlock])
#* <tt>tppaywall</tt> if TP is triggering a paywall / adblocker detection script (e.g. [https://github.com/sitexw/FuckAdBlock FuckAdBlock])
#* <tt>tpvideo</tt> if TP is blocking the playing of videos
#* <tt>tpvideo</tt> if TP is blocking the playing of videos
#* <tt>trackingprotection</tt> otherwise
#* <tt>trackingprotection</tt> otherwise
# Check that breakage bugs include the offending blocked resource in the comments.
# Tag bugs with the list that causes the breakage in the whiteboard field.
#* '''tp-base''' for the standard list
#* '''tp-content''' for the strict list
# Mark bugs that have the same root cause (e.g. Facebook videos are blocked on site X) as <tt>DUPLICATE</tt> of one another.
# Mark bugs that have the same root cause (e.g. Facebook videos are blocked on site X) as <tt>DUPLICATE</tt> of one another.
# Add the '''tp-entitylist''' whiteboard tag if the breakage could be mitigated by expanding the entity whitelist to linked domains owned by the same organization.
# Add the '''tp-entitylist''' whiteboard tag if the breakage could be mitigated by expanding the entity whitelist to linked domains owned by the same organization.
# Add the '''tp-needsrepro''' whiteboard tag if the problematic resource is not mentioned in the bug.
# For feature requests and bugs that require a product decision:
# For feature requests and bugs that require a product decision:
## Tag with the '''tp-product''' whiteboard tag.
## Tag with the '''tp-product''' whiteboard tag.
Line 20: Line 16:
# Move to '''Tech Evangelism: Desktop''' any bug that needs to be resolved by the site owners (e.g. to avoid relying on trackers for their site's functionality to work).
# Move to '''Tech Evangelism: Desktop''' any bug that needs to be resolved by the site owners (e.g. to avoid relying on trackers for their site's functionality to work).
# Set a priority on the bug:
# Set a priority on the bug:
#* '''tp-needsrepro''': <tt>P3</tt>
#* '''tp-product''': <tt>--</tt>
#* '''tp-product''': <tt>--</tt>
#* '''tp-entitylist''': <tt>P2</tt>
#* '''tp-entitylist''': <tt>P2</tt>
#* '''Tech Evangelism''': <tt>--</tt>
#* '''Tech Evangelism''': <tt>--</tt>
==Reproducing bugs==
Someone looking at the [https://bugzilla.mozilla.org/buglist.cgi?list_id=13780003&status_whiteboard_type=allwordssubstr&query_format=advanced&status_whiteboard=tp-needsrepro&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&component=Tracking%20Protection&product=Firefox <tt>tp-needsrepro</tt> bugs]] should:
# Close any unreproducible bugs with <tt>WORKSFORME</tt>.
# Find the offending blocked resource and add a comment to the bug.
# Tag bugs with the list that causes the breakage in the whiteboard field.
#* '''tp-base''' for the standard list
#* '''tp-content''' for the strict list

Revision as of 00:16, 15 September 2017

As bug come into the Firefox::Tracking Protection component, the bug triage owner should follow these steps:

  1. Move misplaced bugs into the right component:
    • Platform bugs should be moved into Toolkit::Safe Browsing
    • Server-side bugs should be moved into Cloud Services::Server: Shavar
  2. Breakage bugs should block one of these meta bugs:
    • tppaywall if TP is triggering a paywall / adblocker detection script (e.g. FuckAdBlock)
    • tpvideo if TP is blocking the playing of videos
    • trackingprotection otherwise
  3. Mark bugs that have the same root cause (e.g. Facebook videos are blocked on site X) as DUPLICATE of one another.
  4. Add the tp-entitylist whiteboard tag if the breakage could be mitigated by expanding the entity whitelist to linked domains owned by the same organization.
  5. Add the tp-needsrepro whiteboard tag if the problematic resource is not mentioned in the bug.
  6. For feature requests and bugs that require a product decision:
    1. Tag with the tp-product whiteboard tag.
    2. NEEDINFO :pdol with a suggested decision (typically P3 or WONTFIX).
  7. Move to Tech Evangelism: Desktop any bug that needs to be resolved by the site owners (e.g. to avoid relying on trackers for their site's functionality to work).
  8. Set a priority on the bug:
    • tp-needsrepro: P3
    • tp-product: --
    • tp-entitylist: P2
    • Tech Evangelism: --

Reproducing bugs

Someone looking at the tp-needsrepro bugs] should:

  1. Close any unreproducible bugs with WORKSFORME.
  2. Find the offending blocked resource and add a comment to the bug.
  3. Tag bugs with the list that causes the breakage in the whiteboard field.
    • tp-base for the standard list
    • tp-content for the strict list
Retrieved from "https://wiki.mozilla.org/index.php?title=Security/Tracking_protection/Bug_triage&oldid=1180494"