Security/Tracking protection/Bug triage: Difference between revisions

From MozillaWiki
Jump to navigation Jump to search
(→‎Reproducing bugs: Use of the "user story" field)
(Move the Tech Evangelism: Desktop part to the second section and mention removing the tp-needsrepro tag.)
Line 14: Line 14:
# Mark bugs that have the same root cause (e.g. Facebook videos are blocked on site X) as <tt>DUPLICATE</tt> of one another.
# Mark bugs that have the same root cause (e.g. Facebook videos are blocked on site X) as <tt>DUPLICATE</tt> of one another.
# Add the '''tp-entitylist''' whiteboard tag if the breakage could be mitigated by expanding the entity whitelist to linked domains owned by the same organization.
# Add the '''tp-entitylist''' whiteboard tag if the breakage could be mitigated by expanding the entity whitelist to linked domains owned by the same organization.
# Add the '''tp-needsrepro''' whiteboard tag if the problematic resource is not mentioned in the bug.
# Add the '''tp-needsrepro''' whiteboard tag if the problematic resource is not mentioned in the bug (see next section).
# For feature requests and bugs that require a product decision:
# For feature requests and bugs that require a product decision:
## Tag with the '''tp-product''' whiteboard tag.
## Tag with the '''tp-product''' whiteboard tag.
## '''NEEDINFO :pdol''' with a suggested decision (typically <tt>P3</tt> or <tt>WONTFIX</tt>).
## '''NEEDINFO :pdol''' with a suggested decision (typically <tt>P3</tt> or <tt>WONTFIX</tt>).
# Move to '''Tech Evangelism: Desktop''' any bug that needs to be resolved by the site owners (e.g. to avoid relying on trackers for their site's functionality to work).
# Set a priority on the bug:
# Set a priority on the bug:
#* '''tp-needsrepro''': <tt>P3</tt>
#* '''tp-needsrepro''': <tt>P3</tt>
#* '''tp-product''': <tt>--</tt>
#* '''tp-product''': <tt>--</tt>
#* '''tp-entitylist''': <tt>P2</tt>
#* '''tp-entitylist''': <tt>P2</tt>
#* '''Tech Evangelism''': <tt>--</tt>


==Reproducing bugs==
==Reproducing bugs==
Line 36: Line 34:
#* '''tp-social''' for the Social category
#* '''tp-social''' for the Social category
#* '''tp-content''' for the Content category (only part of the strict list)
#* '''tp-content''' for the Content category (only part of the strict list)
# Remove the '''tp-needsrepro''' tag.
# Move the bug to '''Tech Evangelism: Desktop''' and reset the priority to <tt>--</tt>.

Revision as of 23:28, 21 June 2018

As bugs come into the Firefox::Tracking Protection component, the bug triage owner should follow these steps:

  1. Move misplaced bugs into the right component:
    • Platform bugs should be moved into Toolkit::Safe Browsing
    • Server-side bugs should be moved into Cloud Services::Server: Shavar
  2. Ensure the URL of the broken page is in the URL field
  3. Breakage bugs should block one of these meta bugs:
    • tppaywall if TP is triggering a paywall / adblocker detection script (e.g. FuckAdBlock)
    • tpvideo if TP is blocking the playing of videos
    • tplogin if TP is breaking the login/registration flow of a site (including SSO providers)
    • tpimages if TP is blocking necessary/useful images (excluding display ads)
    • trackingprotection otherwise
  4. Close paywall-related bugs as WONTFIX.
  5. Mark bugs that have the same root cause (e.g. Facebook videos are blocked on site X) as DUPLICATE of one another.
  6. Add the tp-entitylist whiteboard tag if the breakage could be mitigated by expanding the entity whitelist to linked domains owned by the same organization.
  7. Add the tp-needsrepro whiteboard tag if the problematic resource is not mentioned in the bug (see next section).
  8. For feature requests and bugs that require a product decision:
    1. Tag with the tp-product whiteboard tag.
    2. NEEDINFO :pdol with a suggested decision (typically P3 or WONTFIX).
  9. Set a priority on the bug:
    • tp-needsrepro: P3
    • tp-product: --
    • tp-entitylist: P2

Reproducing bugs

Someone looking at the tp-needsrepro bugs should:

  1. Close any unreproducible bugs with WORKSFORME.
  2. Find the blocked resource(s) responsible for the breakage (using uMatrix) and add it to the user story field.
  3. Tag bugs with the category that causes the breakage in the whiteboard field (use this mapping for Twitter, Google and Facebook resources in the Disconnect category):
    • tp-ads for the Advertising category
    • tp-analytics for the Analytics category
    • tp-social for the Social category
    • tp-content for the Content category (only part of the strict list)
  4. Remove the tp-needsrepro tag.
  5. Move the bug to Tech Evangelism: Desktop and reset the priority to --.
Retrieved from "https://wiki.mozilla.org/index.php?title=Security/Tracking_protection/Bug_triage&oldid=1195943"