Gaia/SMS/Scrum/FxOS-S6

List of bugs

SMS issues handled by the SMS subteam (blocks the sprint bug 1198259)

Bugzilla link

Full Query

ID	Assigned to	Summary	Blocking b2g	Feature-b2g	Whiteboard	Resolution
818000	Julien Wajsberg [:julienw]	system messages are ignored if the handler pathname is not the same as the foreground application pathname	---	No cf_feature-b2g	[sms-sprint FxOS-S7 p=3][sms-sprint FxOS-S6 p=2][sms-sprint FxOS-S5 p=3]	WONTFIX
1180592	Steve Chung [:steveck]	[Messages][NG] mozMobileConnections shim Implementation	---	No cf_feature-b2g	[sms-sprint FxOS-S7 p=1][sms-sprint FxOS-S6 p=2]	FIXED
1198266		[Messages] Use ConversationService in the application	---	No cf_feature-b2g	[sms-sprint FxOS-S8 p=1][sms-sprint FxOS-S7 p=3][sms-sprint FxOS-S6 p=2]	WONTFIX

3 Total; 3 Open (100%); 0 Resolved (0%); 0 Verified (0%);

Remaining points and burndown chart

google chart api url for Sprint FxOS-S6

Burndown chart

	Remaining points
Start	6
Day 2	6
Day 3	6
Day 4	6
Day 5
Day 6
Day 7
Day 8
Day 9
Day 10
End

SMS issues handled by the SMS subteam outside of the sprint (contains whiteboard "sms-sprint-FxOS-S6")

Full Query

ID	Assigned to	Summary	Blocking b2g	Feature-b2g	Whiteboard	Resolution
1199593	Julien Wajsberg [:julienw]	[Message]The text content lost when forward the MMS.	2.5+	No cf_feature-b2g	[2.5-aries-test-run-2][sms-sprint-FxOS-S6]	FIXED
1199612	Oleg Zasypkin [:azasypkin]	[Messages][NG] API shim host didn't initialize correctly and break the MMS retrieval	2.5+	No cf_feature-b2g	[sms-sprint-FxOS-S6]	FIXED
1200116	Oleg Zasypkin [:azasypkin]	[Messages][Tests] ThreadGenerator should be able to create threads with MMS	---	No cf_feature-b2g	[sms-sprint-FxOS-S6]	FIXED

3 Total; 3 Open (100%); 0 Resolved (0%); 0 Verified (0%);

All SMS issues tracked for this sprint (target milestone)

Bugzilla link

Full Query

ID	Assigned to	Summary	Blocking b2g	Feature b2g	Resolution
1169576	Oleg Zasypkin [:azasypkin]	[Messages][NG] Implement Conversation service: method for streaming joined threads and drafts list	---	---	FIXED
1197104	Steve Chung [:steveck]	[Messages][Drafts] Threadless drafts are broken	2.5+	---	FIXED
1198259		SMS sprint FxOS-S6	---	---	INCOMPLETE

3 Total; 3 Open (100%); 0 Resolved (0%); 0 Verified (0%);

Sprint planning

Minutes are on a separate page.

Daily meetings

Day 3: 27th August

Steve

• bug 1179628 - [Messages][NG] Lay out Settings service structure
  • Start mozMobileConnections.
• bug 1180592 - [Messages][NG] mozMobileConnections shim Implementation
  • WIP is ready but not fully tested yet. Will request feedback if everything works fine.
• bug 1198658 - [Flame KK][Message]Press the download button, there is no message indicating that you need to switch data connection
  • Found a dataclone problem with DOMError instance. Patch created for review.

    (Oleg) Wilson told me some time ago, that he should deal with this errors in the bridge (like extract error message or name from Error instance), can we confirm with him why it doesn't work? Or it's not in reject callback?

    (Steve) For the normal Error instance I think he did extract the message of error instance, and in the reject we will only get message instead of error instance. But seems like DOMError is not considered. Do you think bridge should be able to dealing with the DOMError as well?

    (Julien) I think it should !

    (Oleg) Yeah, I think we'll have ton of cases where such error can occur.

    (Steve) So, redirect the bug to Wilson, or create another issue for him?

    (Julien) I would create another issue and still fix our bug with a comment to this issue. Like "We need to clone the DOMError manually until bug XXX is resolved". Unless he can look at it soon, or you can do a PR to the threads.js lib :)

    (Steve) Got it.

Today:

• Create a bug to disable the message event broadcast
• Layout for mozConnections shim
• Confirm with Etienne about the profiling and make the list layout close to master.

Julien

• worked more on system messages issue: I have a working solution with (I think) no bug for the current apps; I'm doing a test app with split views + event handling that could be even closer to what we'll need in SMS (esp opening a specific conversation when the user taps the notification) to see if this works with this solution. Will continue today.
• spent some time on the "low storage condition" spec; I'll file some bugs later this week, there is small work for us.
• some bug triaging

Today: I want to:

• do left-over reviews (I left them for some days ;) )
• work on the system messages issue

If all this moves forward well, I could:

• continue the prototype caching the thread list to a single db (including contacts/drafts/etc).

Oleg

• bug 1155534 - [Messages][NG] Extract NewMessage view from Conversation view
  • No updates (in background).
• bug 1176976 - [Messages][Drafts] Remove the draft saving/replacing action menu
  • Rebased on latest master to re-run integration tests (in review).
• bug 1169576 - [Messages][NG] Implement Conversation service: method for streaming joined threads and drafts list
  • Finally added "checkin-needed" (checkin-needed).

    (Julien) I think you could add it earlier already :) Sheriffs don't land when the tree is closed ;)

    (Oleg) Ahhhhh, good to know :)

• bug 1198266 - [Messages] Use ConversationService in the application
  • Analyzing data I've got with WebIDE - will dump first portion to the bug soon (in progress).

    (Julien) you can share profiles from cleopatra too. You can upload a profile to https://people.mozilla.org/~bgirard/cleopatra/ and share from here.

    (Oleg) I thought cleopatra kind of replaced with built-in profiler or not yet? I admit I don't remember what type of data cleopatra provides :)

  • So far l10n.js and gaia-header are the most time consuming things on the startup.

    (Julien) more than in normal master ? l10n I'm not surprised but gaia-header should not :/

    (Oleg) I think the same as in master, just my statement of disappointment :) gaia-header doesn't look like the main thing in the app, but it consumes a lot of time :)

    (Julien) I'll look at it, maybe it regressed. Or maybe it's only JS and not Reflow/Repaint and in that case why not.

    (Oleg) Basically both, initially it spends a lot of time for createShadowRoot (~90ms) and later on it causes huge reflow (~160ms, if I understood it correctly) with sumButtonWidth - I'll comment on the bug.

    (Julien) OK, this should not happen at all :/ in Inbox, I did work (with title-start/title-end) to avoid reflows at startup, and other panels have "skip-font-fit". So I'll look and file a bug if needed.

    (Julien) also you should capture Gecko as well (there is an option, I think)

Other:

• Started to look at "bug 1160049 - [Messages] Attach menu should not dismiss when user cancel the replace attachment request", left on question at github;
• Looked through Bevis's proposal, need some time to digest it first.

Today:

• Will handle review/feedback/need-info requests;
• Will work on review comments and assigned bugs.

Day 4: 28th August

Steve

• bug 1179628 - [Messages][NG] Lay out Settings service structure
  • Start mozMobileConnections.
• bug 1180592 - [Messages][NG] mozMobileConnections shim Implementation
  • Rebase to master (Still in test)
• bug 1198658 - [Flame KK][Message]Press the download button, there is no message indicating that you need to switch data connection
  • Create a github issue https://github.com/gaia-components/bridge/issues/80 and update in the comment.
• Mail to Etienne about how to utilize raptor profiling with fast-list

Today:

• Create a bug to disable the message event broadcast
• Layout for mozConnections shim

Julien

Was a slow day because of some meetings.

• Still happy we discussed and estimated the NGA plan.
• reviewed the 2 simple patches from Gandalf, regressions from the l10n changes he did: bug 1171206 and bug 1192744
• no work on system messages issue

Today: I want to:

• do left-over reviews
• work on the system messages issue

If all this moves forward well, I could:

• continue the prototype caching the thread list to a single db (including contacts/drafts/etc).

Oleg

• bug 1155534 - [Messages][NG] Extract NewMessage view from Conversation view
  • No updates (in background).
• bug 1176976 - [Messages][Drafts] Remove the draft saving/replacing action menu
  • No progress (in review).
• bug 1169576 - [Messages][NG] Implement Conversation service: method for streaming joined threads and drafts list
  • Landed (landed).
• bug 1198266 - [Messages] Use ConversationService in the application
  • Added my analysis to the bug and ni? Zibi and Julien for the pieces they know better.
  • Zibi clarified that some bottlenecks in l10n are resolved in l20n - good :) Julien, do you know if plan to have l20n in Messages in 2.5?
  • Noticed twice that "Intl.DateTimeFormat" initialization could take ~80ms, but don't see it with the latest PVT build anymore.

    (Julien) yeah we know this is long, that's why we cache it (don't remember the exact place). If it doesn't happen with current build, it's good ! I'd like to see which bug made this better :)

    (Oleg) Ah, okay, I'll double check and figure out what fixed that.

  • Some preliminary checks: removing gradient photo placeholders didn't improve thread node paint time, didn't notice big difference between "setTimeout(0)" and setImmediate shim via window.postMessage though I expected it to be much faster - will look deeper.

    (Julien) why did you expect to be faster ? postMessage is using the event loop, just like setTimeout.

    (OIeg) I've seen several _synthetic_ jsperf tests, were setTimeout was significantly slower, but it's just _synthetic_. That was the main reason I was thinking so :)

    (Julien) I think setTimeout has the 4ms penalty, but not in all cases (usually nested setTimeout have the penalty). But in our case I don't think this helps because we have a stream of things, we don't wait for the setTimeout before doing the next task. (or I think ?). Not sure the 'nested' rule apply to us, in my previous tests I did see differences between apps and browsing... but don't remember exactly what :p

    (Oleg) Yeah, like mentioned here https://developer.mozilla.org/en-US/docs/Web/API/Window/setImmediate, yeah we don't have nested.

  • Started to profile with Built-In profile, trying to figure out if I can get more details from it. One thing that I don't understand is tiny consequent restyles, do you know what is it? Looks like incremental restyle :)

    (Julien) when you click on the restyle itself, you have the "HINT" on the panel that can tell you where it comes from. It could be an animation for example.

    (Oleg) They almost all "StyleAttribute", didn't find much info what is this exactly.

    (Julien) a "style" attribute change ? :)

    (Oleg) Yeah, but I can't think of cases where we change style attribute that much.

    (Julien) yeah; I'll look at your profile later today anyway :) Right now I'm just guessing :p

    (Oleg) Good!

Other:

• Reviewed "bug 1160049 - [Messages] Attach menu should not dismiss when user cancel the replace attachment request", just one last question at github.

Today:

• Will handle review/feedback/need-info requests;
• Will work on review comments and assigned bugs.