Gaia/SMS/Scrum/FxOS-S3: Difference between revisions

/* Day 12: July 17th
(/* Day 12: July 17th)
Line 551: Line 551:


=== Day 12: July 17th ===
=== Day 12: July 17th ===
====Steve====
* {{Bug|1169573}} - [Messages][NG] Lay out Messaging service structure
** Addressed the last suggestion and rebase.
* {{Bug|1179628}} - [Messages][NG] Lay out Settings service structure
** Starting {{Bug|1180591}} for settings shim.
* {{Bug|1180593}} -  [Messages][NG] Reorganize settings methods for settings service and views separately
** Landed and mark  {{Bug|1170461}} as duplicate.
* {{Bug|1180591}} -  [Messages][NG] mozSettings shim Implementation
** Give a WIP for mozSettings shim, simply for get/set/add Observer(I'm fine if we agree that we don't cache any changeable value in settings service) methods.
Today:
* Land messaging service.
* Layout for mozSettings/mozConnections shim
====Julien====
* still worked on navigation ({{Bug|1162030}}):
** worked a lot on unit tests. Focussing on fixing existing ones (fixed the tests for navigation and conversation). Fixed some issues in navigation.js in the process.
** today I'll fix the next ones + create new tests for the new use cases
** Also I had a look at integration tests, I think I missed some use cases (forward especially); I'll look on a phone to see if this works in real-life.
* Briefly looked at other review requests from Steve (MessagingService + SettingsService)
Today:
I want to:
* move forward the navigation patch -- today is more tests day
* do some reviews asked some days ago
If all this moves forward well, I could:
* continue the prototype caching the thread list to a single db (including contacts/drafts/etc).
* I'd like to work on the deduplication logic for network alerts, it seems important for users ({{Bug|1067938}})
====Oleg====
* {{Bug|1155534}} - [Messages][NG] Extract NewMessage view from Conversation view
** No updates (in background).
* {{Bug|1176976}} - [Messages][Drafts] Remove the draft saving/replacing action menu
** Still working on tests in background, pushed the latest changes to Github (in background).
* {{Bug|1172902}} - [Messages][NG] Use SimpleOfflineCache to cache all app resources
** Received feedback from Fernando and Francisco, digesting, will check the issue with "DOMContenLoaded" and file a bug if needed, it's fired for the hosted apps, need to check why it didn't work for me with raptor runs... (in progress)
Other:
* Flashed both v18D and v18D_v3 to verify that "{{Bug|1166211}} - [Messages] There are black artifacts visible when user navigates to another panel right after dialog dismissal" is fixed - and yes we don't have this issue anymore!
*: (Julien) yay, I need to flash then :)
* Reviewed "{{Bug|1180593}} - [Messages][NG] Reorganize settings methods for settings service and views separately"
* Talked to Wilson about our case when service hosted inside SharedWorker wants to access another service hosted in iframe, looks like we have "built-in" solution with BroadcastChannelAPI, commented on the bug.
*: (JUlien) but how do you create the iframe ?
*: (Oleg) Manually? We need several JS files (like utils) for some shims, I guess creating iframe manually is the only way to do this since we don't have "importScripts" in window context, or what you mean?
*: (Julien) OK. still not completely clear in my head but we'll work it out :) Yep!
*: (Oleg) Need to confirm though if channel is shut down when handshake is completed, will be a mess if it's still kept alive together with MessageChannel.
* Talked to Eli to have raptor result tables in markdown-compatible format, so that it's easy to insert them as GitHub comments :) I believe it's accepted.
* Created simple enable-sw/disable-sw PR for the Julien's addpref tool: https://github.com/julienw/config-files/pull/4. But now I see some new SW related prefs added, hesitating to add them since everything works without toggling them anyway :)
*: (Julien) disabled prefs is for features in development; if we don't need them, don't toggle them :)
Today:
* Will handle review/feedback/need-info requests;
* Will work on review comments and assigned bugs.
=== Day 13: July 20th ===
=== Day 13: July 20th ===


== Demos ==
== Demos ==
== Retrospective ==
== Retrospective ==
Confirmed users
821

edits