ReleaseEngineering/PuppetAgain/HowTo/Hack on PuppetAgain: Difference between revisions

ReleaseEngineering/PuppetAgain/HowTo/Hack on PuppetAgain (view source)

Revision as of 14:05, 14 August 2017

873 bytes removed , 14 August 2017

no edit summary

Dcrisan

12

edits

@@ Line 101: / Line 101: @@
 == Test your code on the local machine ==
-  Each developer should test his puppet code on the local machine. You can do this, by running setup/test_puppetcode.py, or manually run these 2 commands:
+  Each developer should test his puppet code on the local machine. You can do this using a docker image:
+* install and configure docker on your local machine: https://docs.docker.com/engine/installation/#supported-platforms
-* puppet parser validate `find manifests modules -name '*.pp' -not -name 'site.pp'`
+* run: docker run --rm --name puppet-linter -v <path to your local puppet environment>:/puppet dividehex/releng-puppet-test:0.8
-* puppet-lint \
-      --no-140chars-check \
-      --no-case_without_default-check \
-      --no-only_variable_string-check \
-      --no-unquoted_file_mode-check \
-      --no-nested_classes_or_defines \
-      --no-quoted_booleans \
-      --no-puppet_url_without_modules \
-      --no-selector_inside_resource \
-      --no-file_mode-check \
-      --no-variable_scope-check \
-      --no-double_quoted_strings-check \
-      --no-autoloader_layout-check \
-      --log-format '%{path} - %{KIND}: %{message} on line %{line} - %{check}' \
-      `find manifests modules -name '*.pp' \
-       -not -path 'modules/acl/*' \
-       -not -path 'modules/assert/*' \
-       -not -path 'modules/concat/*' \
-       -not -path 'modules/firewall/*' \
-       -not -path 'modules/java_ks/*' \
-       -not -path 'modules/powershell/*' \
-       -not -path 'modules/registry/*' \
-       -not -path 'modules/stdlib/*' \
-       -not -path 'modules/windows_firewall/*' \
-       -not -path 'modules/windows_path/*'`
 = Patch Guidelines / Review Checklist =