Confirmed users
1,927
edits
Phabricator/TestPlan: Difference between revisions
→Creating a secure revision is successful: updates for clarity
(→Updating a revision is successful: Simplify to just using amend) |
(→Creating a secure revision is successful: updates for clarity) |
||
| Line 91: | Line 91: | ||
=== Creating a secure revision is successful === | === Creating a secure revision is successful === | ||
Your Bugzilla user must belong to a security group, e.g. core-security. | |||
====Test Plan==== | ====Test Plan==== | ||
* Go to bugzilla and create a security bug. | * Go to bugzilla and create a security bug: | ||
** Click "Edit Bug", open the "Security" panel, and check one of the security-sensitive boxes, e.g. "Security-Sensitive Core Bug". | |||
* Create a new hg commit. | * Create a new hg commit. | ||
* Run | * Run <code>arc diff .^</code>. | ||
* Enter the title, summary, test plan, and the bug id of the security bug. | * Enter the title, summary, test plan, and the bug id of the security bug. | ||
* Submit the revision. | * Submit the revision. | ||
| Line 107: | Line 110: | ||
* The revision is NOT visible to the public without logging in. | * The revision is NOT visible to the public without logging in. | ||
* The revision is NOT visible to logged in members without the correct permission. | * The revision is NOT visible to logged in members without the correct permission. | ||
* There is an x-phabricator-request attachment on the bug in Bugzilla. | * There is an <code>x-phabricator-request</code> attachment on the bug in Bugzilla. | ||
=== Creating a revision checks the bug id === | === Creating a revision checks the bug id === | ||